Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40765

Make Release Plugin compatible with pipeline

XMLWordPrintable

      Allow to trigger release plugin from a pipeline dsl. It should be similar to trigger job's build.

      To support this the plugin would need to be refactored according to pipeline development instructions: https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md

          [JENKINS-40765] Make Release Plugin compatible with pipeline

          Alexey M created issue -

          Alexey M added a comment -

          Hi,

          I made a corresponding change, see the pull request https://github.com/jenkinsci/release-plugin/pull/22
          Could you please take a look on the modification.

          oleg_nenashev FYI

          Cheers

          Alexey M added a comment - Hi, I made a corresponding change, see the pull request https://github.com/jenkinsci/release-plugin/pull/22 Could you please take a look on the modification. oleg_nenashev FYI Cheers
          Jesse Glick made changes -
          Labels New: pipeline
          Alexey M made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: estarter
          Path:
          pom.xml
          src/main/java/hudson/plugins/release/SafeParametersAction.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseQueueListener.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseStep.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseStepExecution.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerAction.java
          src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerListener.java
          src/main/resources/hudson/plugins/release/pipeline/Messages.properties
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/DescriptorImpl/parameters.groovy
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly
          src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.properties
          src/test/java/hudson/plugins/release/pipeline/ReleaseStepTest.java
          http://jenkins-ci.org/commit/release-plugin/1f9b17f72bdab24531cf7eb8f8ef52fdbadca417
          Log:
          JENKINS-40765 add pipeline support (#22)

          • fix after code review
          • remove guice
          • allow to schedule release when build is in queue

          rewrite SafeParametersAction in order to use parent's parameters field
          that allows to benefit on correct execution of ParametersAction#shouldSchedule method

          • acquire the lock only when needed
          • fix after code review

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: estarter Path: pom.xml src/main/java/hudson/plugins/release/SafeParametersAction.java src/main/java/hudson/plugins/release/pipeline/ReleaseQueueListener.java src/main/java/hudson/plugins/release/pipeline/ReleaseStep.java src/main/java/hudson/plugins/release/pipeline/ReleaseStepExecution.java src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerAction.java src/main/java/hudson/plugins/release/pipeline/ReleaseTriggerListener.java src/main/resources/hudson/plugins/release/pipeline/Messages.properties src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/DescriptorImpl/parameters.groovy src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.jelly src/main/resources/hudson/plugins/release/pipeline/ReleaseStep/config.properties src/test/java/hudson/plugins/release/pipeline/ReleaseStepTest.java http://jenkins-ci.org/commit/release-plugin/1f9b17f72bdab24531cf7eb8f8ef52fdbadca417 Log: JENKINS-40765 add pipeline support (#22) JENKINS-40765 add pipeline support fix after code review remove guice allow to schedule release when build is in queue rewrite SafeParametersAction in order to use parent's parameters field that allows to benefit on correct execution of ParametersAction#shouldSchedule method acquire the lock only when needed fix after code review
          Oleg Nenashev made changes -
          Assignee Original: Peter Hayes [ petehayes ] New: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Oleg Nenashev added a comment -

          Another PR with fixes of the implementation by estarter: https://github.com/jenkinsci/release-plugin/pull/24

          Oleg Nenashev added a comment - Another PR with fixes of the implementation by estarter : https://github.com/jenkinsci/release-plugin/pull/24
          Oleg Nenashev made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/pipeline-plugin/b293156039a223ee592298cbd762fed9291f68a5
          Log:
          Merge pull request #426 from estarter/patch-1

          JENKINS-40765 JENKINS-40766 Add release/m2release plugins to the list

          Compare: https://github.com/jenkinsci/pipeline-plugin/compare/be4c63608ad5...b293156039a2

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/pipeline-plugin/b293156039a223ee592298cbd762fed9291f68a5 Log: Merge pull request #426 from estarter/patch-1 JENKINS-40765 JENKINS-40766 Add release/m2release plugins to the list Compare: https://github.com/jenkinsci/pipeline-plugin/compare/be4c63608ad5...b293156039a2

            oleg_nenashev Oleg Nenashev
            estarter Alexey M
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: