Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Duplicate
-
None
Description
If I have a Jenkins job with 'Trigger phrase' set to 'redo', then when I type 'redo' on the PR a Jenkins job is correctly triggered with 'ghprbCommentBody' set to 'redo'.
However, if I then push another commit to this PR, then a Jenkins job is created with 'ghprbCommentBody' again set to 'redo', rather than 'null'.
It looks like at the same time as setting `int commentsChecked = 0;` at GhprbPullRequest.java:245 we should also set `commentBody = null;`.
Attachments
Issue Links
- links to
Activity
Field | Original Value | New Value |
---|---|---|
Description |
If I have a Jenkins job with 'Trigger phrase' set to 'redo', then when I type 'redo' on the PR a Jenkins job is correctly triggered with 'ghprbCommentBody' set to 'redo'. However, if I then push another commit to this PR, then a Jenkins job is created with 'ghprbCommentBody' again set to 'redo', rather than 'null'. I'm afraid not able to easily test this at the moment, but from a quick look at the code, it looks like at the same time as setting `int commentsChecked = 0;` at GhprbPullRequest.java:245 we should also set `commentBody = null;`. |
If I have a Jenkins job with 'Trigger phrase' set to 'redo', then when I type 'redo' on the PR a Jenkins job is correctly triggered with 'ghprbCommentBody' set to 'redo'. However, if I then push another commit to this PR, then a Jenkins job is created with 'ghprbCommentBody' again set to 'redo', rather than 'null'. I'm afraid I'm not able to easily test this at the moment, but from a quick look at the code, it looks like at the same time as setting `int commentsChecked = 0;` at GhprbPullRequest.java:245 we should also set `commentBody = null;`. |
Description |
If I have a Jenkins job with 'Trigger phrase' set to 'redo', then when I type 'redo' on the PR a Jenkins job is correctly triggered with 'ghprbCommentBody' set to 'redo'. However, if I then push another commit to this PR, then a Jenkins job is created with 'ghprbCommentBody' again set to 'redo', rather than 'null'. I'm afraid I'm not able to easily test this at the moment, but from a quick look at the code, it looks like at the same time as setting `int commentsChecked = 0;` at GhprbPullRequest.java:245 we should also set `commentBody = null;`. |
If I have a Jenkins job with 'Trigger phrase' set to 'redo', then when I type 'redo' on the PR a Jenkins job is correctly triggered with 'ghprbCommentBody' set to 'redo'. However, if I then push another commit to this PR, then a Jenkins job is created with 'ghprbCommentBody' again set to 'redo', rather than 'null'. It looks like at the same time as setting `int commentsChecked = 0;` at GhprbPullRequest.java:245 we should also set `commentBody = null;`. |
Assignee | ben patterson [ bpatterson ] | Sam Gleske [ sag47 ] |
Resolution | Duplicate [ 3 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Remote Link | This issue links to "PR 233 (Web Link)" [ 19972 ] |
Remote Link | This issue links to "PR 233 (Web Link)" [ 19972 ] |
Remote Link | This issue links to "GitHub issue 233 (Web Link)" [ 19973 ] |