vivek cliffmeyers can you please discuss what API changes might be needed to allow Github Enterprise server URL to be used?

I have asked CloudBees internal OPs team to get you access to the testing server

jamesdumay I recall seeing an e-mail about this but I am not sure if our access was ever granted or how to go about testing it?

vivek if we can confirm this week we have access then perhaps I'll schedule a meeting to talk about what changes are needed. I think your API design for Github might already account for this with the URL field.

note: @zhouhaibing089 was interested in this

bighappyface is also very interested in GHE support!

nice bighappyface. The main blocker now is nearly done: having end to end tests that run the flow with a real github org (and also better test coverage in general). As believe me, without that, Murphys law kicks in and something stupid happens... 

There is some discussion as to whether the GitHub API endpoint URL should be specified via the UI (as in the screen comps) or via a system property set on Jenkins. This needs to be clarified as the former will require some changes in the backend code.

jamesdumay should we remove the "create an access key here" link? Now it points to github.com which won't help obviously. I'm not sure if GitHub Enterprise supports similar functionality, although the user would need to enter the URL first anyways.

cliffmeyers FYI – the "create access key here" is the same link in GitHub Enterprise, provided that you use the GitHub Enterprise address (and not github.com).

First PR with some backend changes is open and linked above.

cliffmeyers just to confirm, this feature should land with organisation folders. We will figure out what to do with org folders after Bitbucket (which won't have it). Bitbucket will serve as an an example on how to do creation the right way without org folders.

cliffmeyers jamesdumay we can change our approach if there is a lot of work to make it work with org folders. I am working on the assumption that there is no real change to that area as the code this is it better to proceed as is, but if I am wrong, we should rethink the order of things. 

Should be fairly quick to make a final round of backend changes in PR #1145 and then get testing against a real GHE environment.

cliffmeyers Feel free to reach out if you need to test on GHE

Thank you very much for working on this. I am waiting to use it once it's done.

comscience15 if you are keen and can build this pull request: https://github.com/jenkinsci/blueocean-plugin/pull/1189 you can actually try it already (close to complete). 

michaelneale Thanks, Michael.  I will wait until officially done.

Landed this to master earlier today. Note that the organization avatars load as broken images presently. I am working on a follow-on PR to show a placeholder instead.

Fix for avatar icons is up.

cliffmeyers Thanks. I would like to ask you after I updated Blue Ocean, I still don't see enterprise option. Could you please guiding me what should I do? see attached screenshot

Nat, this will be in next weeks beta so you will be able to try it then

jamesdumay I see thanks James