Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41037

Unable to serialize lists because of ConcurrentModificationException

    XMLWordPrintable

Details

    • workflow-cps-global-lib 2.18

    Description

      This keeps up reported as Flaked tests as it seems to clash with some other test (related activity) and gets retried correctly. (Using synchronized mocks makes no difference).

      Reproducible by https://github.com/jenkinsci/resource-disposer-plugin/commit/bc5f00008cc31a680e103dd7bd804bd64b0a4668 and mvn clean package. Not by mvn clean package -Dtest=AsyncResourceDisposerTest#combined of course.

      Caused by: java.util.ConcurrentModificationException
	at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:953)
	at java.util.LinkedList$ListItr.next(LinkedList.java:886)
	at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:73)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:223)
	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:210)
	... 128 more

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-19561 Unsafe & inefficient concurrency in XStream

          • Critical - Crashes, loss of data, severe memory leak.
          • Fixed but Unreleased

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-42720 ConcurrentModificationException when serializing LockableResourcesManager

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link resource-disposer-plugin #8

          Web Link workflow-cps-global-lib-plugin #100

          Web Link xstream-fork #1

          Activity

            Ascending order - Click to sort in descending order
            View 8 older comments
            jglick Jesse Glick added a comment -

            Under discussion in https://github.com/x-stream/xstream/pull/222 but probably this will need to be split into distinct issues, one for each collection which is being concurrently modified during save, and each case fixed independently.

            jglick Jesse Glick added a comment - Under discussion in https://github.com/x-stream/xstream/pull/222 but probably this will need to be split into distinct issues, one for each collection which is being concurrently modified during save, and each case fixed independently.
            jglick Jesse Glick added a comment -

            workflow-cps-global-lib-plugin #100 should solve the most-reported issues. Looks like there are a couple more in other plugins.

            jglick Jesse Glick added a comment - workflow-cps-global-lib-plugin #100 should solve the most-reported issues. Looks like there are a couple more in other plugins.
            basil Basil Crow added a comment - - edited

            jenkinsci/resource-disposer-plugin#8 fixes this issue in Resource Disposer's test suite. At the time of this writing, the only remaining known instance of this issue is in Cloud Statistics, as described in this comment.

            basil Basil Crow added a comment - - edited jenkinsci/resource-disposer-plugin#8 fixes this issue in Resource Disposer's test suite. At the time of this writing, the only remaining known instance of this issue is in Cloud Statistics, as described in this comment .
            a1dutch Andrew Holland added a comment -

            is there any plan to release a new version of workflow-cps-global-lib-plugin with the fix?

            a1dutch Andrew Holland added a comment - is there any plan to release a new version of workflow-cps-global-lib-plugin with the fix?
            basil Basil Crow added a comment -

            is there any plan to release a new version of workflow-cps-global-lib-plugin with the fix?

            That was done in 2.18.

            basil Basil Crow added a comment - is there any plan to release a new version of workflow-cps-global-lib-plugin with the fix? That was done in 2.18 .

            People

              Unassigned Unassigned
              olivergondza Oliver Gondža
              Votes:
              4 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated: