Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41522

There is some good stuff in PR#109 that is extra from JENKINS-40652 and should be considered

XMLWordPrintable

      Look at the changes in https://github.com/jenkinsci/github-branch-source-plugin/pull/109 and assess which of the changes additional to the fix for the regression in JENKINS-40652 should be picked up

          [JENKINS-41522] There is some good stuff in PR#109 that is extra from JENKINS-40652 and should be considered

          Stephen Connolly created issue -
          Stephen Connolly made changes -
          Link New: This issue is related to JENKINS-40652 [ JENKINS-40652 ]

          Jesse Glick added a comment -

          Is there anything useful left in that PR? I do not believe so.

          Jesse Glick added a comment - Is there anything useful left in that PR? I do not believe so.

          James Dumay added a comment -

          stephenconnolly I like "Allow PR's from non-fork code" - thats how it should work.

          James Dumay added a comment - stephenconnolly I like "Allow PR's from non-fork code" - thats how it should work.

          Terry Ridgway added a comment - - edited

          I'm still seeing this issue with GitHub Branch Source plugin v2.0.4 and Jenkins v2.32.3, even though I've made sure the user id of the committer is part of the contributors list in Git. I've even uninstalled the plugin and reinstalled it, but I still cannot get Jenkins to use the PR branch version  (from origin, not from a fork) of the JenkinsFile instead of the master branch version. Is there a beta version of the plugin that I can try?

          Terry Ridgway added a comment - - edited I'm still seeing this issue with GitHub Branch Source plugin v2.0.4 and Jenkins v2.32.3, even though I've made sure the user id of the committer is part of the contributors list in Git. I've even uninstalled the plugin and reinstalled it, but I still cannot get Jenkins to use the PR branch version  (from origin, not from a fork) of the JenkinsFile instead of the master branch version. Is there a beta version of the plugin that I can try?
          Stephen Connolly made changes -
          Link New: This issue is blocked by JENKINS-43426 [ JENKINS-43426 ]

          Michal Slusarczyk added a comment -

          I proposed a fix for issue mentioned by ridgway

          Michal Slusarczyk added a comment - I proposed a fix for issue mentioned by ridgway
          Stephen Connolly made changes -
          Resolution New: Done [ 10000 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: