Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: pipeline-model-definition-plugin
-
Labels:None
-
Similar Issues:
Description
This pipeline succeeds:
pipeline {
agent any
stages {
stage ('Build') {
steps {
sh 'cat Jenkinsfile'
}
}
}
}
This pipeline fails:
pipeline {
agent any
stages {
stage ('Build') {
agent any
steps {
sh 'cat Jenkinsfile'
}
}
}
}
The reason this happens is that the agent inside a stage step does not do checkout scm automatically. This is very confusing behavior. Agent initialization should be consistent whether at top or inside a stage.
I would expect to do something like this to make an agent in a stage not do checkout:
pipeline {
agent any
options {
skipDefaultCheckout()
}
stages {
stage ('Build') {
agent any
options {
skipDefaultCheckout()
}
steps {
sh 'cat Jenkinsfile'
}
}
}
}
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
- relates to
-
-
- Closed
-
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
This pipeline succeeds: {code:language=groovy} pipeline { agent any stages { stage ('Build') { steps { sh 'cat Jenkinsfile' } } } } {code} This pipeline fails: {code:language=groovy} pipeline { agent any stages { stage ('Build') { agent any steps { sh 'cat Jenkinsfile' } } } } {code} The reason this happens is that the agent inside a stage step does not do checkout scm automatically. This is very confusing behavior. Agent initialization should be consistent whether at top or inside a stage. |
This pipeline succeeds: {code:language=groovy} pipeline { agent any stages { stage ('Build') { steps { sh 'cat Jenkinsfile' } } } } {code} This pipeline fails: {code:language=groovy} pipeline { agent any stages { stage ('Build') { agent any steps { sh 'cat Jenkinsfile' } } } } {code} The reason this happens is that the agent inside a stage step does not do checkout scm automatically. This is very confusing behavior. Agent initialization should be consistent whether at top or inside a stage. I would expect to do something like this to make an agent in a stage not do checkout: {code:language=groovy} pipeline { agent any options { skipDefaultCheckout() } stages { stage ('Build') { agent any options { skipDefaultCheckout() } steps { sh 'cat Jenkinsfile' } } } } {code} |
| Link |
This issue relates to |
Andrew Bayer, why would you still advocate for it? It's wholly inconsistent behavior between stage-level and pipeline-level agent directives.
| Status | Open [ 1 ] | In Progress [ 3 ] |
So what I'm leaning towards right now is hooking logic so that the label Declarative agent does always do a checkout (assuming skipDefaultCheckout isn't specified at the top-level, that is) - that'll still avoid doing a redundant checkout when docker or dockerfile are used for an individual stage and reuseNode is specified, since we never actually go through the label Declarative agent then. Implementing now on top of https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/109, which is in the same code (that's JENKINS-41900).
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
Added to the existing related PR https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/109
| Remote Link | This issue links to "PR #109 (Web Link)" [ 15452 ] |
| Link |
This issue is duplicated by |
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
Code changed in jenkins
User: Andrew Bayer
Path:
content/doc/book/pipeline/syntax.adoc
http://jenkins-ci.org/commit/jenkins.io/dde1b744c20b737ea45cbec3db4335710d2d0c84
Log:
Uncommenting since JENKINS-41605 landed as well.
| Remote Link | This issue links to "CloudBees Internal OSS-1996 (Web Link)" [ 18472 ] |
Bulk closing resolved issues.
| Status | Resolved [ 5 ] | Closed [ 6 ] |
The reasoning behind automatic checkout only happening at the top level was a conscious decision - and frankly, one I'd still advocate for. But it may make sense to have a per-stage option for "do a fresh checkout of SCM in this stage" - independent of the agent configuration. There've been some other things that have come up that may make sense as part of a stage-level options section.