Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41685

incorrect event received with workflow-api 2.8

XMLWordPrintable

      After upgrading workflow-api from 2.7 to 2.8, blueocean tests started failing. After debugging with svanoort it was discovered an extra event from next branch was was received (so two input step events for left branch in stead of one) from this sample pipeline script below. It results in to incorrect visualization of steps when user selects parallel branch nodes.

      node {
    stage "hey"
    sh "echo yeah"
    
    stage "par"
    
    parallel left : {
            sh "echo OMG BS"
            echo "running"
            def branchInput = input message: 'Please input branch to test against', parameters: [[$class: 'StringParameterDefinition', defaultValue: 'master', description: '', name: 'branch']]
            echo "BRANCH NAME: ${branchInput}"
            sh "echo yeah"
        }, 
        
        right : {
            sh "echo wozzle"
            def branchInput = input message: 'MF Please input branch to test against', parameters: [[$class: 'StringParameterDefinition', defaultValue: 'master', description: '', name: 'branch']]
            echo "BRANCH NAME: ${branchInput}"
        }
    
    stage "ho"
        sh "echo done"
}

      Here are the events generated and this is extra event generated failing test: https://gist.github.com/vivek/ccf3a4ef25fbff267c76c962d265041d#file-event-log-log-L3.

          [JENKINS-41685] incorrect event received with workflow-api 2.8

          Vivek Pandey created issue -
          Jesse Glick made changes -
          Labels New: regression
          Jesse Glick made changes -
          Link New: This issue blocks JENKINS-38536 [ JENKINS-38536 ]
          Sam Van Oort made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Sam Van Oort made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Ryan Campbell made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 15480 ]
          Sam Van Oort made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-1975 (Web Link)" [ 18488 ]
          CloudBees Inc. made changes -
          Remote Link New: This issue links to "CloudBees Internal CLTS-1257 (Web Link)" [ 19163 ]

            svanoort Sam Van Oort
            vivek Vivek Pandey
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: