Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42159

Winstone doesn't exit when boot catastrophically fails

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • winstone-jetty
    • None

      When java -jar jenkins.war catastrophically fails, such as when ServletContextListener fails and the webapp fails to boot, Winstone keeps running without serving anything.

      If the sole webapp fails to deploy, it should terminate with an error message instead.

          [JENKINS-42159] Winstone doesn't exit when boot catastrophically fails

          Kohsuke Kawaguchi added a comment -

          I found this while working on JENKINS-41196.

          Kohsuke Kawaguchi added a comment - I found this while working on JENKINS-41196 .

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          src/java/winstone/HostConfiguration.java
          src/java/winstone/Launcher.java
          http://jenkins-ci.org/commit/winstone/20cbb8afed8305109308be693be5228dc2c21e5e
          Log:
          JENKINS-42159 If startup fails, exit the process.

          As it stands right now, empty Jetty keeps running and makes it difficult
          to detect catastrophic boot error.

          The code change makes any exception thrown from ServletContextListener a
          fatal problem.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/java/winstone/HostConfiguration.java src/java/winstone/Launcher.java http://jenkins-ci.org/commit/winstone/20cbb8afed8305109308be693be5228dc2c21e5e Log: JENKINS-42159 If startup fails, exit the process. As it stands right now, empty Jetty keeps running and makes it difficult to detect catastrophic boot error. The code change makes any exception thrown from ServletContextListener a fatal problem.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          src/java/winstone/HostConfiguration.java
          src/java/winstone/Launcher.java
          http://jenkins-ci.org/commit/winstone/046d0cf8542f7ecd3d064e1a2aff5ea1123b5867
          Log:
          Merge pull request #33 from jenkinsci/abort-on-fail

          [FIXED JENKINS-42159] If startup fails, exit the process.

          Compare: https://github.com/jenkinsci/winstone/compare/7e2241eb05cb...046d0cf8542f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/java/winstone/HostConfiguration.java src/java/winstone/Launcher.java http://jenkins-ci.org/commit/winstone/046d0cf8542f7ecd3d064e1a2aff5ea1123b5867 Log: Merge pull request #33 from jenkinsci/abort-on-fail [FIXED JENKINS-42159] If startup fails, exit the process. Compare: https://github.com/jenkinsci/winstone/compare/7e2241eb05cb...046d0cf8542f

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          src/java/winstone/HostConfiguration.java
          src/java/winstone/Launcher.java
          http://jenkins-ci.org/commit/winstone/7ff7343f66e61c9672a7e83bbadee7e64ec2f8cd
          Log:
          JENKINS-42159 If startup fails, exit the process.

          As it stands right now, empty Jetty keeps running and makes it difficult
          to detect catastrophic boot error.

          The code change makes any exception thrown from ServletContextListener a
          fatal problem.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/java/winstone/HostConfiguration.java src/java/winstone/Launcher.java http://jenkins-ci.org/commit/winstone/7ff7343f66e61c9672a7e83bbadee7e64ec2f8cd Log: JENKINS-42159 If startup fails, exit the process. As it stands right now, empty Jetty keeps running and makes it difficult to detect catastrophic boot error. The code change makes any exception thrown from ServletContextListener a fatal problem.

            kohsuke Kohsuke Kawaguchi
            kohsuke Kohsuke Kawaguchi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: