Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42196

Eliminate overly-eager SSE ping request

XMLWordPrintable

    • 1.0

      Atm, the SSE client executes an immediate ping request to the server on receipt of an SSE channel error. This is too eager. We should wait a few seconds before performing the ping, giving the SSE connection a chance to see if it can "fix" itself (e.g. during a reconnect).

      I was sure this was how it was working already. Maybe I unwittingly introduced this at some point.

          [JENKINS-42196] Eliminate overly-eager SSE ping request

          Tom FENNELLY created issue -

          Tom FENNELLY added a comment -

          Noticed this while investigating JENKINS-42137.

          Tom FENNELLY added a comment - Noticed this while investigating JENKINS-42137 .
          Tom FENNELLY made changes -
          Link New: This issue is related to JENKINS-42137 [ JENKINS-42137 ]
          Tom FENNELLY made changes -
          Component/s New: blueocean-plugin [ 21481 ]
          Tom FENNELLY made changes -
          Epic Link New: JENKINS-35737 [ 171801 ]
          Tom FENNELLY made changes -
          Sprint New: 1.0 [ 221 ]
          Tom FENNELLY made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Tom FENNELLY made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          package.json
          src/main/js/SSEConnection.js
          http://jenkins-ci.org/commit/sse-gateway-plugin/c225bf976b0b0b42aadea1135eef7392e8dcd721
          Log:
          [FIX JENKINS-42196] Eliminate overly-eager SSE ping request (#18)

          • Only ping after giving the connection a chance to heal itself

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: package.json src/main/js/SSEConnection.js http://jenkins-ci.org/commit/sse-gateway-plugin/c225bf976b0b0b42aadea1135eef7392e8dcd721 Log: [FIX JENKINS-42196] Eliminate overly-eager SSE ping request (#18) Only ping after giving the connection a chance to heal itself 0.0.19-tf- JENKINS-42196 -1
          Tom FENNELLY made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            tfennelly Tom FENNELLY
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: