Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42218

Refactor branch filtering control to share logic with JDL controls

      The branch filtering feature (JENKINS-35768) has been implemented using a 3rd party "typeahead" control.

      The design spec for the "branch filtering" control is similar to the JDL Dropdown and ideally would share much of the same logic. A work-in-progress branch exists to refactor out the Dropdown's menu into a "FlyoutMenu" control that could be reused in different components.

      The end state of the code might look something like this:

      • Dropdown
        • button (as today)
        • FlyoutMenu
      • Typeahead (this might be the name for the control that branch filtering uses)
        • TextInput
        • FlyoutMenu

          [JENKINS-42218] Refactor branch filtering control to share logic with JDL controls

          Cliff Meyers created issue -
          Cliff Meyers made changes -
          Link New: This issue relates to JENKINS-35768 [ JENKINS-35768 ]
          Cliff Meyers made changes -
          Link New: This issue is blocked by JENKINS-42109 [ JENKINS-42109 ]

          Cliff Meyers added a comment -

          The start of this refactor is here:

          https://github.com/jenkinsci/jenkins-design-language/commit/46c4577093ae34f846e96881d80ef31bee353449

          master needs to be merged, and there have been non-trivial changes to Dropdown in the intervening time... so I might be the best person to take a stab at this one if/when we prioritize it.

          Cliff Meyers added a comment - The start of this refactor is here: https://github.com/jenkinsci/jenkins-design-language/commit/46c4577093ae34f846e96881d80ef31bee353449 master needs to be merged, and there have been non-trivial changes to Dropdown in the intervening time... so I might be the best person to take a stab at this one if/when we prioritize it.
          James Dumay made changes -
          Epic Link New: JENKINS-35741 [ 171657 ]
          James Dumay made changes -
          Labels New: technical-debt
          James Dumay made changes -
          Sprint New: Blue Ocean 1.1 [ 271 ]
          James Dumay made changes -
          Rank New: Ranked lower
          James Dumay made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          James Dumay made changes -
          Rank New: Ranked higher

            Unassigned Unassigned
            cliffmeyers Cliff Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: