-
Task
-
Resolution: Fixed
-
Minor
-
-
Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2, Blue Ocean 1.1-beta4, Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2, Blue Ocean 1.3
As discussed in an earlier meeting, there are some improvements we should look to make in core-js and across the code base.
- Avoid swallowing of promise errors by using a different promise lib / polyfill. Bluebird looks promising:
- We should add test coverage for core-js' Fetch utility especially around the area of error handling. We've just recently had to add more intricate logic for error handling (validation in creation flows) and we should assert these errors propagate when they should, and are caught properly when the UI can gracefully recover.
- Nock can be used to facilitate this; see this example from smart-fetch: https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/test/js/smart-fetch-spec.js#L16
- is duplicated by
-
-
- Closed
-
- links to
[JENKINS-42283] Fetch and Promise enhancements
| Epic Link | New: JENKINS-35749 [ 171790 ] |
| Labels | New: technical-debt |
| Link |
New:
This issue is duplicated by |
| Sprint | New: Blue Ocean - techdebt sprint 1 [ 291 ] | |
| Assignee | New: Cliff Meyers [ cliffmeyers ] |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Sprint | Original: Blue Ocean - 1.1-beta-1 [ 291 ] | New: Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2 [ 291, 306 ] |
| Sprint | Original: Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2 [ 291, 306 ] | New: Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2, Blue Ocean 1.1-beta3 [ 291, 306, 316 ] |
| Sprint | Original: Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2, Blue Ocean 1.1-beta4 [ 291, 306, 316 ] | New: Blue Ocean - 1.1-beta-1, Blue Ocean - 1.1-beta2, Blue Ocean 1.1-beta4, Blue Ocean 1.1-beta5 [ 291, 306, 316, 321 ] |
jdumay do we have an appropriate epic for this kind of purely technical work?