Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42417

Skipped tests should not use "unstable" coloring

    XMLWordPrintable

Details

    • 1.0, Blue Ocean - 1.1-beta2

    Description

      Scope

      • Change skipped tests to use the "not built" style and status indicator instead of the yellow "unstable" style and status indicator

      Original request
      In an unstable build, there can be

      • failed tests
      • skipped tests

      The skipped tests are the same color and icon as the overall build (orange and ! ) while the tests that actually made the build unstable are red and x. This makes no sense, as it implies a relationship between build status and skipped tests that's just not there.

      Attachments

        Activity

          danielbeck Daniel Beck created issue -
          jamesdumay James Dumay made changes -
          Field Original Value New Value
          Link This issue duplicates JENKINS-39203 [ JENKINS-39203 ]
          jamesdumay James Dumay made changes -
          Resolution Duplicate [ 3 ]
          Status Open [ 1 ] Resolved [ 5 ]
          jamesdumay James Dumay added a comment -

          You are right - it does not make sense. Pipeline actually sets every node as unstable and Blue Ocean just reports on what pipeline tells it. I do have internal commitment from CloudBees OSS team that they will fix it this year for me. Need to narrow down when because it annoys me a lot.

          jamesdumay James Dumay added a comment - You are right - it does not make sense. Pipeline actually sets every node as unstable and Blue Ocean just reports on what pipeline tells it. I do have internal commitment from CloudBees OSS team that they will fix it this year for me. Need to narrow down when because it annoys me a lot.
          danielbeck Daniel Beck made changes -
          danielbeck Daniel Beck added a comment -

          jamesdumay Please see the screenshot for what this is about.

          danielbeck Daniel Beck added a comment - jamesdumay Please see the screenshot for what this is about.
          danielbeck Daniel Beck made changes -
          Resolution Duplicate [ 3 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          jamesdumay James Dumay added a comment -

          danielbeck oh are you saying "skipped" tests shouldn't have the same state as "unstable"? I agree. Since skipped tests are not built, WDYT about using the "not built" status here brody?

          jamesdumay James Dumay added a comment - danielbeck oh are you saying "skipped" tests shouldn't have the same state as "unstable"? I agree. Since skipped tests are not built, WDYT about using the "not built" status here brody ?
          jamesdumay James Dumay made changes -
          Link This issue duplicates JENKINS-39203 [ JENKINS-39203 ]
          jamesdumay James Dumay made changes -
          Assignee James Dumay [ jamesdumay ]
          jamesdumay James Dumay made changes -
          Sprint 1.0 [ 221 ]
          danielbeck Daniel Beck added a comment -

          Yes. It was actually confusing to me trying to understand the icons here – the tests with the same icon as "the entire build" were basically irrelevant. Something grey would be better here, and perhaps even consider changing the failed "red x" icon to "orange !" to match the build step.

          danielbeck Daniel Beck added a comment - Yes. It was actually confusing to me trying to understand the icons here – the tests with the same icon as "the entire build" were basically irrelevant. Something grey would be better here, and perhaps even consider changing the failed "red x" icon to "orange !" to match the build step.
          brody Brody Maclean made changes -
          Attachment screenshot-1.png [ 36217 ]
          brody Brody Maclean made changes -
          Attachment screenshot-1.png [ 36217 ]
          brody Brody Maclean added a comment -

          jamesdumay skipped ≠ unstable so it doesn't make sense to have the same status or colour.
          grey currently is used for aborted... which does have some relation to skipped so that could work.

          brody Brody Maclean added a comment - jamesdumay skipped ≠ unstable so it doesn't make sense to have the same status or colour. grey currently is used for aborted... which does have some relation to skipped so that could work.
          jamesdumay James Dumay made changes -
          Sprint 1.0 [ 221 ] 1.0, 1.0-rc1 [ 221, 261 ]
          mmoreno Matias Moreno made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Summary Inconsistent presentation for unstable builds Skipped tests should not use "unstable" coloring
          jamesdumay James Dumay made changes -
          Epic Link JENKINS-36296 [ 172305 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0, Blue Ocean 1.0-rc2 [ 221, 261 ] 1.0, Blue Ocean 1.1 [ 221, 271 ]
          Description In an unstable build, there can be

          - failed tests
          - skipped tests

          The skipped tests are the same color and icon as the overall build (orange and ! ) while the tests that actually made the build unstable are red and x. This makes no sense, as it implies a relationship between build status and skipped tests that's just not there.
          *Scope*
          * Change skipped tests to use the "not built" style and status indicator instead of the yellow "unstable" style and status indicator

          *Original request*
          In an unstable build, there can be

          - failed tests
          - skipped tests

          The skipped tests are the same color and icon as the overall build (orange and ! ) while the tests that actually made the build unstable are red and x. This makes no sense, as it implies a relationship between build status and skipped tests that's just not there.
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Assignee James Dumay [ jamesdumay ]
          jamesdumay James Dumay made changes -
          Status Reopened [ 4 ] In Progress [ 3 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0, Blue Ocean 1.1 [ 221, 271 ] 1.0, Blue Ocean - 1.1-beta2 [ 221, 306 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Assignee James Dumay [ jamesdumay ]
          jamesdumay James Dumay made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          jamesdumay James Dumay made changes -
          jamesdumay James Dumay added a comment -

          danielbeck it now looks like this

          jamesdumay James Dumay added a comment - danielbeck it now looks like this
          jamesdumay James Dumay added a comment -

          Will be released in Blue Ocean 1.1

          jamesdumay James Dumay added a comment - Will be released in Blue Ocean 1.1
          jamesdumay James Dumay made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          jbriden Jenn Briden made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            jamesdumay James Dumay
            danielbeck Daniel Beck
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: