Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42421

BROKEN: Team names/slugs show up as 'org.kohsuke.github.GHTeam@e004985'

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • github-oauth-plugin
    • None
    • github-oauth-plugin 0.25

      Before, team names would show up. Now they show as `org.kohsuke.github.GHTeam@e004985`.

      Example:

      Given the github org 'foo' with the team 'bar', the Organization would show up in my /user/ page as foo*bar.

      Now, it shows up as foo*org.kohsuke.github.GHTeam@e004985.

      This is breaking permissions, since I cannot give permissions to teams!

          [JENKINS-42421] BROKEN: Team names/slugs show up as 'org.kohsuke.github.GHTeam@e004985'

          Christian Höltje added a comment -

          This may possibly be related to JENKINS-34835

          Christian Höltje added a comment - This may possibly be related to JENKINS-34835

          Sam Gleske added a comment - - edited

          Thanks for filing this issue. I have confirmed it and will personally be working on a fix.

          For what it's worth, it only seems to affect viewing a user page. If you still visit https://<jenkins>/whoAmI, then it still properly renders granted authorities. It's a UI bug but still a bug.

          Sam Gleske added a comment - - edited Thanks for filing this issue. I have confirmed it and will personally be working on a fix. For what it's worth, it only seems to affect viewing a user page. If you still visit https://<jenkins>/whoAmI , then it still properly renders granted authorities. It's a UI bug but still a bug.

          Christian Höltje added a comment -

          Huh. I didn't know about /whoAmI

          Christian Höltje added a comment - Huh. I didn't know about /whoAmI

          Christian Höltje added a comment -

          The permissions problem I was having is due to the command line jar not having being able to get GitHub Orgs/Teams because there are no cached credentials.

          Christian Höltje added a comment - The permissions problem I was having is due to the command line jar not having being able to get GitHub Orgs/Teams because there are no cached credentials.

          Guiomar Tuñón added a comment -

          I think it is related to this issue. I have found different behaviours related to GitHub teams and users:

          1. User1:
            • already registered in Jenkins before actualisation.
            • Member of team p1.
            • granted permissions over user: "User1"... 
            • Can access and see teams in WhoAmI. ****
          2. User2*:*
            • granted access to Jenkins after actualisation 
            • member of team p1.
            • granted permissions over team: "organisation*p1"
            • Can not access****
          3. User3:
            • granted access to Jenkins after actualisation 
            • member of team p1.
            • granted permissions over organisation: "organisation"
            • Can access but cannot see teams in WhoAmI **

           

          At the moment this behaviour interferes with the authorisation model we need to deploy. As not all the members of our GitHub organisation should be granted access to Jenkins. And we have enough users and variable collaborators that should be managed by teams, instead of individually. 

           

          Guiomar Tuñón added a comment - I think it is related to this issue. I have found different behaviours related to GitHub teams and users: User1: already registered in Jenkins before actualisation. Member of team p1. granted permissions over user: "User1"...  Can access and see teams in WhoAmI.  **** User2*:* granted access to Jenkins after actualisation  member of team p1. granted permissions over team: "organisation*p1" Can not access **** User3: granted access to Jenkins after actualisation  member of team p1. granted permissions over organisation: "organisation" Can access but cannot see teams in WhoAmI  **   At the moment this behaviour interferes with the authorisation model we need to deploy. As not all the members of our GitHub organisation should be granted access to Jenkins. And we have enough users and variable collaborators that should be managed by teams, instead of individually.   

          Guiomar Tuñón added a comment -

          I think something I did crashed this and I have resolved it. 

          So I'm closing the issue. 

           

          Guiomar Tuñón added a comment - I think something I did crashed this and I have resolved it.  So I'm closing the issue.   

          Christian Höltje added a comment -

          gtunon – Why did you close this? There is still the UI issue that sag47 was working on.

          Christian Höltje added a comment - gtunon – Why did you close this? There is still the UI issue that sag47 was working on.

          Guiomar Tuñón added a comment -

          Sorry docwhat thats true. Reopening

          Guiomar Tuñón added a comment - Sorry docwhat  thats true. Reopening

          Sam Gleske added a comment -

          After attempting to work on this, I released 0.27 and bootstrapped the latest Jenkins 2.58, I notice the issue is no longer there for me.  I wonder if it was a problem in core.  Please let me know if others confirm it is fixed.

          Sam Gleske added a comment - After attempting to work on this, I released 0.27 and bootstrapped the latest Jenkins 2.58, I notice the issue is no longer there for me.  I wonder if it was a problem in core.  Please let me know if others confirm it is fixed.

          Christian Höltje added a comment - - edited

           I'll check it out once I can work around JENKINS-44020

          Christian Höltje added a comment - - edited  I'll check it out once I can work around  JENKINS-44020

          Anthony Agresta added a comment -

          This is still broken for me on 0.27, using Jenkins LTS 2.60.1

          Anthony Agresta added a comment - This is still broken for me on 0.27, using Jenkins LTS 2.60.1

          Sam Gleske added a comment -

          This issue has been resolved by pull request https://github.com/jenkinsci/github-oauth-plugin/pull/92

          Sam Gleske added a comment - This issue has been resolved by pull request  https://github.com/jenkinsci/github-oauth-plugin/pull/92

          Sam Gleske added a comment -

          The fix will be available in the next release.

          Sam Gleske added a comment - The fix will be available in the next release.

          Sam Gleske added a comment -

          0.29 has been released.

          Sam Gleske added a comment - 0.29 has been released.

            sag47 Sam Gleske
            docwhat Christian Höltje
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: