Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42551

Able to generate invalid declarative Jenkinsfiles

    XMLWordPrintable

Details

    Description

      In certain cases, it is possible to generate invalid Jenkinsfiles.

      For one thing, we need to escape backslashes.

      Additionally, I suggest during the JSON validation, we convert to declarative, and then also validate the declarative file, just to prevent invalid files from ever being created, since we can't actually load them into the editor again.

      An example JSON request that generates invalid declarative:

      {"pipeline":{"agent":{"type":"any"},"stages":[{"name":"Build","branches":[{"name":"default","steps":[{"name":"sh","arguments":[{"key":"script","value":{"isLiteral":true,"value":"echo 'hello\\'"}}]}]}]}]}}

       

      Attachments

        Issue Links

          Activity

            People

              abayer Andrew Bayer
              kzantow Keith Zantow
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: