Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42597

Percent character (%) in filenames is not url-encoded in the CHANGES page

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Percent character (%) in filenames is not url-encoded in the CHANGES page.  It results in broken links. See screenshot.  In this example the URL generated is 

      https://github.beescloud.com/support-team/ZD-44831/blob/d51bb5f9d80eea1a9d7d3b5d52dc6485c25c4e33/conf_%.txt

      whereas it should be 

      https://github.beescloud.com/support-team/ZD-44831/blob/d51bb5f9d80eea1a9d7d3b5d52dc6485c25c4e33/conf_%25.txt

      with the %25 encoding.  I believe change need in:

      https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/browser/GithubWeb.java

        Attachments

        1. changes.png
          changes.png
          309 kB
        2. step-01.PNG
          step-01.PNG
          89 kB
        3. step-02.PNG
          step-02.PNG
          79 kB
        4. step-03.PNG
          step-03.PNG
          62 kB

          Activity

          afein_cb Aaron Fein created issue -
          lanwen Kirill Merkushev made changes -
          Field Original Value New Value
          Component/s git-plugin [ 15543 ]
          Component/s github-plugin [ 15896 ]
          lanwen Kirill Merkushev made changes -
          Assignee Kirill Merkushev [ lanwen ] Mark Waite [ markewaite ]
          markewaite Mark Waite made changes -
          Assignee Mark Waite [ markewaite ]
          Hide
          markewaite Mark Waite added a comment - - edited

          I've duplicated the problem with the JENKINS-42597 job and with the JENKINS-42597 branch which creates a pipeline job in my Docker image. The steps I'd missed (note, this is not the complete set of steps to duplicate the problem, just the steps that I had failed to take from the user interface after defining the job):

          1. Submit a change to the github repository
          2. Poll the github repository for changes (in my case, in response to a notifyCommit)
          3. Confirm the build ran to completion
          4. Click the link for that specific build (number 12 in my case)
          5. Click the Changes link, confirm the summary shows a change to build-100%-number
          6. Click the link to build-100%-number, and see github report 404. Clicking the diff link in at least one of my jobs correctly navigates to the diff on github

          You can see the job definitions that show the problem in the JENKINS-42597 branch in my jenkins-bugs repository and in the JENKINS-42597 job in my Docker image.

          Pictures captured the steps so that I'll remember them...

          Show
          markewaite Mark Waite added a comment - - edited I've duplicated the problem with the JENKINS-42597 job and with the JENKINS-42597 branch which creates a pipeline job in my Docker image. The steps I'd missed (note, this is not the complete set of steps to duplicate the problem, just the steps that I had failed to take from the user interface after defining the job): Submit a change to the github repository Poll the github repository for changes (in my case, in response to a notifyCommit) Confirm the build ran to completion Click the link for that specific build (number 12 in my case) Click the Changes link, confirm the summary shows a change to build-100%-number Click the link to build-100%-number, and see github report 404. Clicking the diff link in at least one of my jobs correctly navigates to the diff on github You can see the job definitions that show the problem in the JENKINS-42597 branch in my jenkins-bugs repository and in the JENKINS-42597 job in my Docker image. Pictures captured the steps so that I'll remember them...
          markewaite Mark Waite made changes -
          Attachment step-02.PNG [ 38214 ]
          Attachment step-03.PNG [ 38215 ]
          Attachment step-01.PNG [ 38216 ]
          cloudbees CloudBees Inc. made changes -
          Remote Link This issue links to "CloudBees Internal CD-148 (Web Link)" [ 19045 ]
          jtaboada Jose Blas Camacho Taboada made changes -
          Assignee Jose Blas Camacho Taboada [ jtaboada ]
          jtaboada Jose Blas Camacho Taboada made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          jtaboada Jose Blas Camacho Taboada made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          dnusbaum Devin Nusbaum made changes -
          Remote Link This issue links to "jenkinsci/git-plugin#619 (Web Link)" [ 21809 ]
          dnusbaum Devin Nusbaum made changes -
          Status In Review [ 10005 ] In Progress [ 3 ]
          Hide
          dnusbaum Devin Nusbaum added a comment -

          Should be included in version 4.0.0 of the git plugin once it is released.

          Show
          dnusbaum Devin Nusbaum added a comment - Should be included in version 4.0.0 of the git plugin once it is released.
          dnusbaum Devin Nusbaum made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Fixed but Unreleased [ 10203 ]
          Hide
          markewaite Mark Waite added a comment -

          Included in git plugin 4.0.0 released Nov 2, 2019

          Show
          markewaite Mark Waite added a comment - Included in git plugin 4.0.0 released Nov 2, 2019
          markewaite Mark Waite made changes -
          Status Fixed but Unreleased [ 10203 ] Closed [ 6 ]

            People

            Assignee:
            jtaboada Jose Blas Camacho Taboada
            Reporter:
            afein_cb Aaron Fein
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: