Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42597

Percent character (%) in filenames is not url-encoded in the CHANGES page

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Percent character (%) in filenames is not url-encoded in the CHANGES page.  It results in broken links. See screenshot.  In this example the URL generated is 

      https://github.beescloud.com/support-team/ZD-44831/blob/d51bb5f9d80eea1a9d7d3b5d52dc6485c25c4e33/conf_%.txt

      whereas it should be 

      https://github.beescloud.com/support-team/ZD-44831/blob/d51bb5f9d80eea1a9d7d3b5d52dc6485c25c4e33/conf_%25.txt

      with the %25 encoding.  I believe change need in:

      https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/browser/GithubWeb.java

        Attachments

        1. changes.png
          changes.png
          309 kB
        2. step-01.PNG
          step-01.PNG
          89 kB
        3. step-02.PNG
          step-02.PNG
          79 kB
        4. step-03.PNG
          step-03.PNG
          62 kB

          Activity

          afein_cb Aaron Fein created issue -
          lanwen Kirill Merkushev made changes -
          Field Original Value New Value
          Component/s git-plugin [ 15543 ]
          Component/s github-plugin [ 15896 ]
          lanwen Kirill Merkushev made changes -
          Assignee Kirill Merkushev [ lanwen ] Mark Waite [ markewaite ]
          markewaite Mark Waite made changes -
          Assignee Mark Waite [ markewaite ]
          markewaite Mark Waite made changes -
          Attachment step-02.PNG [ 38214 ]
          Attachment step-03.PNG [ 38215 ]
          Attachment step-01.PNG [ 38216 ]
          cloudbees CloudBees Inc. made changes -
          Remote Link This issue links to "CloudBees Internal CD-148 (Web Link)" [ 19045 ]
          jtaboada Jose Blas Camacho Taboada made changes -
          Assignee Jose Blas Camacho Taboada [ jtaboada ]
          jtaboada Jose Blas Camacho Taboada made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          jtaboada Jose Blas Camacho Taboada made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          dnusbaum Devin Nusbaum made changes -
          Remote Link This issue links to "jenkinsci/git-plugin#619 (Web Link)" [ 21809 ]
          dnusbaum Devin Nusbaum made changes -
          Status In Review [ 10005 ] In Progress [ 3 ]
          dnusbaum Devin Nusbaum made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Fixed but Unreleased [ 10203 ]
          markewaite Mark Waite made changes -
          Status Fixed but Unreleased [ 10203 ] Closed [ 6 ]

            People

            Assignee:
            jtaboada Jose Blas Camacho Taboada
            Reporter:
            afein_cb Aaron Fein
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: