Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4260

False Warnings reported when using the exclude

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • warnings-plugin
    • None
    • Platform: All, OS: All

    Description

      Hudson v1.320, Warnings Plugin v2.11

      I just upgraded the plugin and now we are seeing a lot Critical warnings that
      were not there before. I have it set to ignore warnings in cppunit. Upon
      investigation, it seems that it does ignore that warning, but when the GCC
      compiler tells me where the object of the warning was instantied from, the
      plugin picks this up as a warning. So now I have a ton of warnings, all just
      reporting "instantiated from here" in the details.

      /<somelocation>/cppunit-1.10.0-vx_rtp/include/cppunit/extensions/TestFixtureFactory.h:17:
      warning: ‘class CppUnit::TestFixtureFactory’ has virtual functions but
      non-virtual destructor
      /<somelocation>/cppunit-1.10.0-vx_rtp/include/cppunit/extensions/TestFixtureFactory.h:
      In instantiation of ‘CppUnit::ConcretTestFixtureFactory<TestCase_MYdvc>’:
      TestCase_MYdvc.h:67: instantiated from here

      Attachments

        Activity

          drulli Ulli Hafner added a comment -

          Is the first warning ok? Or are both warnings false positives?

          Are there other false positives?

          drulli Ulli Hafner added a comment - Is the first warning ok? Or are both warnings false positives? Are there other false positives?
          jmboulos jmboulos added a comment -

          The plugin correctly ignores the first warning as it should have (since I have
          it excluding */cppunit/*/). Only that last one comes up.

          I didn't notice any other false positive other than the 60 or 70 instances of
          the "instantiated from here" one.

          jmboulos jmboulos added a comment - The plugin correctly ignores the first warning as it should have (since I have it excluding * /cppunit /* / ). Only that last one comes up. I didn't notice any other false positive other than the 60 or 70 instances of the "instantiated from here" one.
          drulli Ulli Hafner added a comment -

          I see. Since the new "warning" starts at a new line, the cpp prefix is not
          present.

          I'll add a special handling for these "instantiated from here" messages.

          drulli Ulli Hafner added a comment - I see. Since the new "warning" starts at a new line, the cpp prefix is not present. I'll add a special handling for these "instantiated from here" messages.

          Code changed in hudson
          User: : drulli
          Path:
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/parser/GccParser.java
          trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/parser/RegexpParser.java
          trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/GccParserTest.java
          trunk/hudson/plugins/warnings/src/test/resources/hudson/plugins/warnings/parser/issue4260.txt
          http://fisheye4.cenqua.com/changelog/hudson/?cs=20847
          Log:
          [FIXED JENKINS-4260] Fixed reporting of some GCC false positive.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : drulli Path: trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/parser/GccParser.java trunk/hudson/plugins/warnings/src/main/java/hudson/plugins/warnings/parser/RegexpParser.java trunk/hudson/plugins/warnings/src/test/java/hudson/plugins/warnings/parser/GccParserTest.java trunk/hudson/plugins/warnings/src/test/resources/hudson/plugins/warnings/parser/issue4260.txt http://fisheye4.cenqua.com/changelog/hudson/?cs=20847 Log: [FIXED JENKINS-4260] Fixed reporting of some GCC false positive.

          People

            drulli Ulli Hafner
            jmboulos jmboulos
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: