Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42740

Consider newline characters in commit messages also for summary of build changes section

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • subversion-plugin
    • None

      Related (or a follow-up) to JENKINS-36521.

      I like the fix/improvement of the aforementioned issue, but there also seems to be a "Summary" section in old/classic UI's "Changes" section, that I think should also be adapted like this (if possible):

      • see
      • see "src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly", line 33

       

      ljader added the following comment:

      I've ran an initial analysis and I think parsing commit message should be implemented as in Git Plugin.
      The git-plugin checks if there is a blank 2nd line (commit message with format http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) and displays only this line on main job page and each build page,
      but it displays full commit message on "Changes" section (job/test-git-repo/4/changes).

      Just for reference, please checkout usage of "msgAnnotated" and "commentAnnotated" here:
      https://github.com/jenkinsci/git-plugin/blob/master/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly

          [JENKINS-42740] Consider newline characters in commit messages also for summary of build changes section

          Reinhold Füreder created issue -
          Reinhold Füreder made changes -
          Description Original: Related (or a follow-up) to -JENKINS-36521-.

          I like the fix/improvement of the aforementioned issue, but there also seems to be a "Summary" section in old/classic UI's "Changes" section, that I think should also be adapted like this (if possible):
           * see !image-2017-03-14-08-13-38-771.png!
           * see "src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly", line 33

           

          [~ljader] added the following comment:
          {quote}I've ran an initial analysis and I think parsing commit message should be implemented as in Git Plugin.
           The git-plugin checks if there is a blank 2nd line (commit message with format [http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html]) and displays only this line on main job page and each build page,
           but it displays full commit message on "Changes" section (job/test-git-repo/4/changes).

          Just for reference, please checkout usage of "msgAnnotated" and "commentAnnotated" here:
           [https://github.com/jenkinsci/git-plugin/blob/master/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly]
          {quote}
          New: Related (or a follow-up) to -JENKINS-36521-.

          I like the fix/improvement of the aforementioned issue, but there also seems to be a "Summary" section in old/classic UI's "Changes" section, that I think should also be adapted like this (if possible):
           * see !image-2017-03-14-08-13-38-771.png|thumbnail!
           * see "src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly", line 33

           

          [~ljader] added the following comment:
          {quote}I've ran an initial analysis and I think parsing commit message should be implemented as in Git Plugin.
           The git-plugin checks if there is a blank 2nd line (commit message with format [http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html]) and displays only this line on main job page and each build page,
           but it displays full commit message on "Changes" section (job/test-git-repo/4/changes).

          Just for reference, please checkout usage of "msgAnnotated" and "commentAnnotated" here:
           [https://github.com/jenkinsci/git-plugin/blob/master/src/main/resources/hudson/plugins/git/GitChangeSetList/index.jelly]
          {quote}
          Reinhold Füreder made changes -
          Link New: This issue is related to JENKINS-36521 [ JENKINS-36521 ]

          Jesse Glick added a comment -

          PRs may be applied, eventually (depending on spare time of non-maintainers alas).

          Jesse Glick added a comment - PRs may be applied, eventually (depending on spare time of non-maintainers alas).

            Unassigned Unassigned
            reinholdfuereder Reinhold Füreder
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: