-
Bug
-
Resolution: Fixed
-
Major
-
None
Currently the API produces a configuration with unresolved macros.
There was an intention to deprecate the API, but use-case like JENKINS-42743 are actually valid. The old API should produce the formally correct XML at least
- blocks
-
JENKINS-42743 Windows Slaves plugin should use API of the Windows Agent Installer Module
-
- Closed
-
[JENKINS-42745] WindowsSlaveInstaller#generateXml() produces invalid XML in 1.7
Link |
New:
This issue blocks |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Priority | Original: Minor [ 4 ] | New: Major [ 3 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |
Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java
src/test/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstallerTest.java
http://jenkins-ci.org/commit/windows-slave-installer-module/89cffceb16b9969bc79c4f7308cab0c19dce7f07
Log:
JENKINS-42745- Windows Agent Installer should generate valid jenkins-slave.xml for old APIsThis change is maybe quite over-engineered, but this engine allows retaining the backward compatibility of the configuration generation logic.
Then this engine can be reused in plugins like Windows Agents Plugin (FKA Windows Slaves Plugin).