Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42746

Windows Slaves Plugin should use internal jenkins-slave.xml

XMLWordPrintable

      Currently the code implements the macro engine on its own, but then it takes the config file from the core, which may actually change at any moment. A Longer-term fix is JENKINS-42743, but now it makes sense to have a hotfix like a local copy of the file.

          [JENKINS-42746] Windows Slaves Plugin should use internal jenkins-slave.xml

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-42743 [ JENKINS-42743 ]
          Oleg Nenashev made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ]
          Oleg Nenashev made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-42724 [ JENKINS-42724 ]
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "https://github.com/jenkinsci/windows-slaves-plugin/pull/6 (Web Link)" [ 15706 ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
          src/main/resources/hudson/os/windows/configsamples/jenkins-slave.xml
          src/test/java/hudson/os/windows/ManagedWindowsServiceLauncherTest.java
          http://jenkins-ci.org/commit/windows-slaves-plugin/0872fc38409a7efe05f239650e944aef4e174456
          Log:
          JENKINS-42746 - Make the plugin independent from the XML sample in the core

          In Jenkins 2.50 we have got JENKINS-42724, which has been caused by the usage of the old resource file located within the Jenkins core.
          It is likely a leftover from the migration of the windows-slaves-installer module.

          Since the Windows Slaves plugin has its internal macro resolution logic, the sample should be also inside plugin. A longer-term fix is to make the plugin depent on the Windows Agent Installer module

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java src/main/resources/hudson/os/windows/configsamples/jenkins-slave.xml src/test/java/hudson/os/windows/ManagedWindowsServiceLauncherTest.java http://jenkins-ci.org/commit/windows-slaves-plugin/0872fc38409a7efe05f239650e944aef4e174456 Log: JENKINS-42746 - Make the plugin independent from the XML sample in the core In Jenkins 2.50 we have got JENKINS-42724 , which has been caused by the usage of the old resource file located within the Jenkins core. It is likely a leftover from the migration of the windows-slaves-installer module. Since the Windows Slaves plugin has its internal macro resolution logic, the sample should be also inside plugin. A longer-term fix is to make the plugin depent on the Windows Agent Installer module

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
          http://jenkins-ci.org/commit/windows-slaves-plugin/63fc71dd1207cda5a6d3884fa304f9bee82de2be
          Log:
          JENKINS-42746 - Amend the TODO comment for JENKINS-42743

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java http://jenkins-ci.org/commit/windows-slaves-plugin/63fc71dd1207cda5a6d3884fa304f9bee82de2be Log: JENKINS-42746 - Amend the TODO comment for JENKINS-42743

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: