Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42863

Docker pipeline steps reported as successful even when failing

    • Blue Ocean 1.0-rc3

      Problem
      On this jenkins file it sometimes fails to do a docker pull. This results in a step that fails from time to time. This ends up as an exception that is caught and prints out the error here. The problem is the actual failing step is reported as successful, which isn't helpful when highlighting where the problem is. 

      What should happen
      The step that threw the exception should be marked as a failure.

      Screenshot

       

       

       

       

       

       

          [JENKINS-42863] Docker pipeline steps reported as successful even when failing

          Michael Neale created issue -
          Michael Neale made changes -
          Assignee New: Vivek Pandey [ vivek ]
          Michael Neale made changes -
          Epic Link New: JENKINS-35750 [ 171713 ]
          Michael Neale made changes -
          Attachment New: Screen Shot 2017-03-17 at 10.48.01 am.png [ 36567 ]

          Michael Neale added a comment - - edited

          vivek jamesdumay - this needs triaging, maybe we need to rewrite this ticket for docker pipeline, or steps api, if this can be solved. 

          I don't think this is specific to blue ocean (stage view shows even less helpful information) however as steps are front and centre in blue ocean - the impact is big: 

           

           

           

          Michael Neale added a comment - - edited vivek jamesdumay - this needs triaging, maybe we need to rewrite this ticket for docker pipeline, or steps api, if this can be solved.  I don't think this is specific to blue ocean (stage view shows even less helpful information) however as steps are front and centre in blue ocean - the impact is big:       
          Michael Neale made changes -
          Sprint New: up next [ 251 ]
          James Dumay made changes -
          Sprint Original: up next [ 251 ] New: 1.0-rc1 [ 261 ]

          James Dumay added a comment -

          vivek could you please investigate? Agree that this is really strange that the step isnt failed in this example

          James Dumay added a comment - vivek could you please investigate? Agree that this is really strange that the step isnt failed in this example
          James Dumay made changes -
          Description Original: – putting in blue ocean purely for triaging, I am not sure where the solution really should be –

           

          On this jenkins file - it sometimes fails to do a docker pull: 

          [https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L60]

           

          This results in a step that fails from time to time. This ends up as an exception that is caught

          and prints out the error here: [https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L135]

           

          The problem is the actual failing step is reported as successful, which isn't helpful when highlighting where the problem is. 

           

          What should happen: 

          The step that threw the exception should be marked as a failure. 

           

          This may be an issue with docker pipeline... or design

           

           

           

           

           

           
          New: *Problem*
          On [this jenkins file|https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L60] it sometimes fails to do a docker pull. This results in a step that fails from time to time. This ends up as an exception that is caught and [prints out the error here|https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L135]. The problem is the actual failing step is reported as successful, which isn't helpful when highlighting where the problem is. 

          *What should happen*
          The step that threw the exception should be marked as a failure.

           

           

           

           

           

           
          James Dumay made changes -
          Description Original: *Problem*
          On [this jenkins file|https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L60] it sometimes fails to do a docker pull. This results in a step that fails from time to time. This ends up as an exception that is caught and [prints out the error here|https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L135]. The problem is the actual failing step is reported as successful, which isn't helpful when highlighting where the problem is. 

          *What should happen*
          The step that threw the exception should be marked as a failure.

           

           

           

           

           

           
          New: *Problem*
          On [this jenkins file|https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L60] it sometimes fails to do a docker pull. This results in a step that fails from time to time. This ends up as an exception that is caught and [prints out the error here|https://github.com/jenkins-infra/jenkins.io/blob/master/Jenkinsfile#L135]. The problem is the actual failing step is reported as successful, which isn't helpful when highlighting where the problem is. 

          *What should happen*
          The step that threw the exception should be marked as a failure.

          *Screenshot*
           !Screen Shot 2017-03-17 at 10.48.01 am.png|thumbnail!
           

           

           

           

           

           

            Unassigned Unassigned
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: