Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-42924

Favourite pipelines working oddly when there is no default branch to favourite

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • blueocean-plugin
    • 1.0.0-rc1 · Core 2.32.3 · 9ac3256

      If favouriting fails the state of the favourite should not be favourited.

      Steps to reproduce (see video with reproducible steps):

      • Go to /blue
      • Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't
      • Then star another pipeline successfully. The pipeline before gets unstarred
      • Refreshing the screen will show the failed favourite as unfavourited

          [JENKINS-42924] Favourite pipelines working oddly when there is no default branch to favourite

          Isa Vilacides created issue -
          Isa Vilacides made changes -
          Issue Type Original: Improvement [ 4 ] New: Bug [ 1 ]

          Cliff Meyers added a comment -

          jamesdumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well?

          In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in?

          Cliff Meyers added a comment - jamesdumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well? In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in?
          James Dumay made changes -
          Labels New: technical-debt
          James Dumay made changes -
          Epic Link New: JENKINS-35761 [ 171656 ]
          James Dumay made changes -
          Sprint New: Blue Ocean 1.1 [ 271 ]
          Description Original: *Steps to reproduce (see [video|https://drive.google.com/file/d/0B8uklOZI9kkqNmx1dUUxRUlsQ28/view] with reproducible steps)*:
           * Go to [/|http://ec2-52-200-141-179.compute-1.amazonaws.com:8080/]blue
           * Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't
           * Then star another pipeline successfully. The pipeline before gets unstarred
          New: If favouriting fails the state of the favourite should not be favourited.

          *Steps to reproduce (see [video|https://drive.google.com/file/d/0B8uklOZI9kkqNmx1dUUxRUlsQ28/view] with reproducible steps)*:
           * Go to [/|http://ec2-52-200-141-179.compute-1.amazonaws.com:8080/]blue
           * Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't
           * Then star another pipeline successfully. The pipeline before gets unstarred
           * Refreshing the screen will show the failed favourite as unfavourited

          Cliff Meyers added a comment - - edited

          The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just lead to confusion. Should we display some kind of error toast?

          Cliff Meyers added a comment - - edited The error handling won't be too difficult here, but we probably need to give some additional feedback that an error occurred? Clicking the star and having it do nothing will just lead to confusion. Should we display some kind of error toast?
          James Dumay made changes -
          Priority Original: Major [ 3 ] New: Minor [ 4 ]
          James Dumay made changes -
          Rank New: Ranked higher
          James Dumay made changes -
          Rank New: Ranked lower

            Unassigned Unassigned
            vilacides Isa Vilacides
            Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: