-
Bug
-
Resolution: Unresolved
-
Minor
-
1.0.0-rc1 · Core 2.32.3 · 9ac3256
If favouriting fails the state of the favourite should not be favourited.
Steps to reproduce (see video with reproducible steps):
- Go to /blue
- Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't
- Then star another pipeline successfully. The pipeline before gets unstarred
- Refreshing the screen will show the failed favourite as unfavourited
- is duplicated by
-
JENKINS-45167 Poor UX/error messaging on default branch favoriting error
-
- Closed
-
[JENKINS-42924] Favourite pipelines working oddly when there is no default branch to favourite
Issue Type | Original: Improvement [ 4 ] | New: Bug [ 1 ] |
Labels | New: technical-debt |
Epic Link | New: JENKINS-35761 [ 171656 ] |
Sprint | New: Blue Ocean 1.1 [ 271 ] | |
Description |
Original:
*Steps to reproduce (see [video|https://drive.google.com/file/d/0B8uklOZI9kkqNmx1dUUxRUlsQ28/view] with reproducible steps)*: * Go to [/|http://ec2-52-200-141-179.compute-1.amazonaws.com:8080/]blue * Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't * Then star another pipeline successfully. The pipeline before gets unstarred |
New:
If favouriting fails the state of the favourite should not be favourited. *Steps to reproduce (see [video|https://drive.google.com/file/d/0B8uklOZI9kkqNmx1dUUxRUlsQ28/view] with reproducible steps)*: * Go to [/|http://ec2-52-200-141-179.compute-1.amazonaws.com:8080/]blue * Star the hudson pipeline (or a pipeline that has no master to favorite) → you will get an error saying that there is an error starring this pipeline because there is no master. But the pipeline is starred when it shouldn't * Then star another pipeline successfully. The pipeline before gets unstarred * Refreshing the screen will show the failed favourite as unfavourited |
Priority | Original: Major [ 3 ] | New: Minor [ 4 ] |
Rank | New: Ranked higher |
Rank | New: Ranked lower |
jamesdumay I recall this default branch issue being discussed quite a long ways back - perhaps there is another related ticket as well?
In the event there's an error, should we display a friendly error message and ensure the favorite star isn't shaded in?