-
Bug
-
Resolution: Fixed
-
Critical
The fix of (in 2.30) reverted some of the code introduced in JENKINS-39555, to fix some regressions there. Unfortunately it failed to revert one of the simplifications that was legitimately made in JENKINS-39404 to code originally introduced in JENKINS-39404: so now Computer.addAction is again inherited from Actionable, but will not work since getActions is an immutable list.JENKINS-18224
Probably no one noticed this before because no one was trying to call Computer.addAction, but egutierrez noticed that yesterday's security release of ssh-slaves by mc1arke introduced code which does, and which causes a failure in TrustHostKeyActionTest.testSubmitNotAuthorised when run against 2.32.3:
java.lang.UnsupportedOperationException at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055) at hudson.model.Actionable.addAction(Actionable.java:134) at hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy.verify(ManuallyTrustedKeyVerificationStrategy.java:70)
- blocks
-
JENKINS-39555 Stage view is empty
-
- Closed
-
-
JENKINS-42968 Fix PCT for 2.32.3
-
- Resolved
-
- is duplicated by
-
JENKINS-42963 Jenkins 2.51 breaks XUnitPublisher step in Pipeline
-
- Closed
-
- links to
[JENKINS-42969] Computer.addAction will throw UnsupportedOperationException
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Link | New: This issue blocks SECURITY-161 [ SECURITY-161 ] |
Link |
New:
This issue blocks |
Link |
New:
This issue blocks |
Description |
Original:
The fix of Probably no one noticed this before because no one was trying to call {{Computer.addAction}}, but [~egutierrez] noticed that yesterday's security release of {{ssh-slaves}} introduced code which does, and which causes a failure in {{TrustHostKeyActionTest.testSubmitNotAuthorised}} when run against 2.32.3. |
New:
The fix of - Probably no one noticed this before because no one was trying to call {{Computer.addAction}}, but [~egutierrez] noticed that yesterday's security release of {{ssh-slaves}} by [~mc1arke] introduced code which does, and which causes a failure in {{TrustHostKeyActionTest.testSubmitNotAuthorised}} when run against 2.32.3: {code:none} java.lang.UnsupportedOperationException at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055) at hudson.model.Actionable.addAction(Actionable.java:134) at hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy.verify(ManuallyTrustedKeyVerificationStrategy.java:70) {code} |
Remote Link | New: This issue links to "ssh-slaves PR 50 (Web Link)" [ 15742 ] |
Remote Link | New: This issue links to "PR 2819 (Web Link)" [ 15743 ] |
Priority | Original: Blocker [ 1 ] | New: Critical [ 2 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Resolution | New: Fixed [ 1 ] | |
Status | Original: In Review [ 10005 ] | New: Resolved [ 5 ] |