Details
-
Bug
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Fixed
-
Jenkins 2.32.2
P4 Plugin 1.5.1
P4 Server Version: P4D/NTX64/2016.2/1487173
Windows 10
Description
I am getting an NPE on exit that is causing my build to fail. I am hoping it is misconfiguration, so the resolution will be simple. I am running the build via "Build Now".
F:\Jenkins\jobs\Omniwar\workspace>exit 0
FATAL: null
java.lang.NullPointerException
at org.jenkinsci.plugins.p4.client.ConnectionHelper.getSwarm(ConnectionHelper.java:544)
at org.jenkinsci.plugins.p4.PerforceScm.guessBrowser(PerforceScm.java:225)
at hudson.scm.SCM.getEffectiveBrowser(SCM.java:146)
at hudson.scm.ChangeLogParser.parse(ChangeLogParser.java:57)
at hudson.model.AbstractBuild.calcChangeSet(AbstractBuild.java:911)
at hudson.model.AbstractBuild.getChangeSet(AbstractBuild.java:879)
at hudson.model.AbstractBuild.getCulprits(AbstractBuild.java:349)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
at hudson.model.Run.execute(Run.java:1753)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Finished: FAILURE
It looks like it is looking for a browser and decides that that browser should be Swarm. I do not have any repo browser installed (i.e. I'm not using Swarm, P4Web, etc.) and the "Repository browser" setting is set to Auto.
Full configuration can be found below.
Attachments
Activity
Paul Allen
added a comment - Released in 1.7.0 This still errors out with NPE in the latest version (1.7.0). It is intermittent (but it always has been).
And I still can't set the browser to anything except "auto" without it causing the same error on save previously mentioned above.
Relevant trace from latest run
F:\Jenkins\jobs\Omniwar\workspace>exit 0
FATAL: null
java.lang.NullPointerException
at org.jenkinsci.plugins.p4.client.ConnectionHelper.getSwarm(ConnectionHelper.java:583)
at org.jenkinsci.plugins.p4.PerforceScm.guessBrowser(PerforceScm.java:248)
at hudson.scm.SCM.getEffectiveBrowser(SCM.java:147)
at hudson.scm.ChangeLogParser.parse(ChangeLogParser.java:57)
at hudson.model.AbstractBuild.calcChangeSet(AbstractBuild.java:910)
at hudson.model.AbstractBuild.getChangeSet(AbstractBuild.java:878)
at hudson.model.AbstractBuild.getCulprits(AbstractBuild.java:349)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
at hudson.model.Run.execute(Run.java:1753)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Finished: FAILURE
Ethan Thornburg
added a comment - - edited This still errors out with NPE in the latest version (1.7.0). It is intermittent (but it always has been).
And I still can't set the browser to anything except "auto" without it causing the same error on save previously mentioned above.
Relevant trace from latest run
F:\Jenkins\jobs\Omniwar\workspace>exit 0
FATAL: null
java.lang.NullPointerException
at org.jenkinsci.plugins.p4.client.ConnectionHelper.getSwarm(ConnectionHelper.java:583)
at org.jenkinsci.plugins.p4.PerforceScm.guessBrowser(PerforceScm.java:248)
at hudson.scm.SCM.getEffectiveBrowser(SCM.java:147)
at hudson.scm.ChangeLogParser.parse(ChangeLogParser.java:57)
at hudson.model.AbstractBuild.calcChangeSet(AbstractBuild.java:910)
at hudson.model.AbstractBuild.getChangeSet(AbstractBuild.java:878)
at hudson.model.AbstractBuild.getCulprits(AbstractBuild.java:349)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:669)
at hudson.model.Run.execute(Run.java:1753)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Finished: FAILURE
Code changed in jenkins
User: Paul Allen
Path:
src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
src/main/java/org/jenkinsci/plugins/p4/browsers/FishEyeBrowser.java
src/main/java/org/jenkinsci/plugins/p4/browsers/OpenGrokBrowser.java
src/main/java/org/jenkinsci/plugins/p4/browsers/P4Browser.java
src/main/java/org/jenkinsci/plugins/p4/browsers/P4WebBrowser.java
src/main/java/org/jenkinsci/plugins/p4/browsers/SwarmBrowser.java
src/main/resources/org/jenkinsci/plugins/p4/browsers/FishEyeBrowser/config.jelly
src/main/resources/org/jenkinsci/plugins/p4/browsers/OpenGrokBrowser/config.jelly
src/main/resources/org/jenkinsci/plugins/p4/browsers/P4WebBrowser/config.jelly
src/main/resources/org/jenkinsci/plugins/p4/browsers/SwarmBrowser/config.jelly
src/main/resources/org/jenkinsci/plugins/p4/changes/P4ChangeSet/index.jelly
http://jenkins-ci.org/commit/p4-plugin/dc460806d1b78d5766aefb2b7514f981c0a43a03
Log:
Update Repository Browser for use with Pipeline.
May fix the following: JENKINS-43069 JENKINS-37094
Paul Allen
added a comment - Release 1.7.1 
Ready for release.