Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43199

Credentials Binding plugin causes File Descriptor leak

      Our deployment of Jenkins with this plugin is currently on an NFS share. In testing a job with this plugin, a file descriptor was apparently left open. We found this out when attempting to delete the test job after it ran. (It was a simple echo job to make sure masking worked as expected, nothing else)

      The issue appears to be related to the anonymous sub-class of the LineTransformationOutputStream class returned by the Wrapper class and similar to the bug resolved in JENKINS-28409 for EnvInject. The sub-class needs to clean up it's parent outputstream and the super class on close.

       

      @Override
       public void close() throws IOException {
       super.close();
       out.close();
       }

          [JENKINS-43199] Credentials Binding plugin causes File Descriptor leak

          Elliott Butler created issue -
          RAVIKUMAR t made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          RAVIKUMAR t made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Bill Agee made changes -
          Priority Original: Minor [ 4 ] New: Critical [ 2 ]
          Bill Agee made changes -
          Priority Original: Critical [ 2 ] New: Major [ 3 ]
          Bill Agee made changes -
          Comment [ Marked this as major since after completing the install of the blue ocean plugin (which seems to have been when this bug appeared on my system), I suddenly needed to restart my Jenkins master process every two days to avoid jobs failing with "too many open files" errors. My max open FD limit for jenkins was set to 8196.

          Initially I worked around this by removing the credentials plugin from some frequently-running jobs.

          Today, I realized that a rollback of the Credentials Binding plugin to 1.11 was possible in the Plugin Manager, so I tried that. It seems to have stopped the FD leak!

          What's strange is that 1.11 is displayed as the most recent version on [https://wiki.jenkins-ci.org/display/JENKINS/Credentials+Binding+Plugin]

          Was a newer version pulled from release? Or perhaps the blue ocean installation I did last week pulled in a newer, unadvertised version somehow? ]
          Oleg Nenashev made changes -
          Status Original: In Review [ 10005 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Jesse Glick made changes -
          Link New: This issue relates to JENKINS-28409 [ JENKINS-28409 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

            Unassigned Unassigned
            ebutler Elliott Butler
            Votes:
            6 Vote for this issue
            Watchers:
            16 Start watching this issue

              Created:
              Updated:
              Resolved: