Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43211

Remove unneeded dependencies (markdown, redux)

    XMLWordPrintable

Details

    • Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2, Blue Ocean 1.4 - beta 5

    Description

      Once karaoke has moved off redux, and personalisation, redux may be removed as a dependency saving download and eval time. 

      Ditty for markdown (which cliffmeyers mentioned may not be needed now with the new empty states, but correct me if wrong). 

      Well worth trimming things we know aren't needed. 

      Attachments

        Issue Links

          Activity

            cliffmeyers Cliff Meyers added a comment -

            To eliminate redux, following areas need to be ported:

            • blueocean-personalization (full module)
            • blueocean-web (all bootstrapping code for stores, middleware, etc)
            • blueocean-dashboard
              • Dashboard
              • TestResults
              • various tests / specs

            To eliminate "react-remarkable", following areas need porting:

            • All remaining empty states (at present, only for RunDetailsArtifacts)
            • ParametersRunButton
            • inputStep
            cliffmeyers Cliff Meyers added a comment - To eliminate redux, following areas need to be ported: blueocean-personalization (full module) blueocean-web (all bootstrapping code for stores, middleware, etc) blueocean-dashboard Dashboard TestResults various tests / specs To eliminate "react-remarkable", following areas need porting: All remaining empty states (at present, only for RunDetailsArtifacts) ParametersRunButton inputStep
            michaelneale Michael Neale added a comment -

            cliffmeyers so based on that - my finger int he air guess is probably a good few days solid work to a week to flush it all out? If so - no hurry for this as "minor". Low cost-benefit return. 

            michaelneale Michael Neale added a comment - cliffmeyers so based on that - my finger int he air guess is probably a good few days solid work to a week to flush it all out? If so - no hurry for this as "minor". Low cost-benefit return. 
            cliffmeyers Cliff Meyers added a comment -

            Since I am likely to add a new dep in JENKINS-38323 I think it's time to remove some old ones

            cliffmeyers Cliff Meyers added a comment - Since I am likely to add a new dep in JENKINS-38323 I think it's time to remove some old ones
            cliffmeyers Cliff Meyers added a comment -

            Added link to WIP PR.

            cliffmeyers Cliff Meyers added a comment - Added link to WIP PR.
            cliffmeyers Cliff Meyers added a comment -

            This work was completed and ran fine locally but causes 100% failure of ATH in CI (but only in CI). This is effectively on-hold for now, refer to comments in PR for details.

            cliffmeyers Cliff Meyers added a comment - This work was completed and ran fine locally but causes 100% failure of ATH in CI (but only in CI). This is effectively on-hold for now, refer to comments in PR for details.
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • There are already new tests in the PR, which are being run and discussed
            • Automated testing is already catching problems that this change might introduce, which is great.
            kshultz Karl Shultz added a comment - Testing Notes: There are already new tests in the PR, which are being run and discussed Automated testing is already catching problems that this change might introduce, which is great.
            cliffmeyers Cliff Meyers added a comment -

            Added link to the new / latest PR that should allow this be merged: https://github.com/jenkinsci/blueocean-plugin/pull/1627

            cliffmeyers Cliff Meyers added a comment - Added link to the new / latest PR that should allow this be merged: https://github.com/jenkinsci/blueocean-plugin/pull/1627

            People

              cliffmeyers Cliff Meyers
              michaelneale Michael Neale
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: