Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43265

REGRESSION Dashboard showPipelineList prevents extension point rendering

    • Blue Ocean - 1.1-beta-1

      https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/js/components/Pipelines.jsx#L76

       

      const showPipelineList = !this.pager.pending && pipelines && pipelines.length > 0;
      const showEmptyState = !this.pager.pending && (!pipelines || !pipelines.length);
      
      { showEmptyState && <DashboardPlaceholder t={translate} /> }
      { showPipelineList &&
      <main>
      <article>
      { /* TODO: need to adjust Extensions to make store available */ }
      <Extensions.Renderer
      extensionPoint="jenkins.pipeline.list.top"
      store={ this.context.store }
      router={ this.context.router }
      />

      The above prevents that the extension point "jenkins.pipeline.list.top" is rendered when no pipelines are there. However in my use case I want to render a navigation box but it has nothing to do with pipelines (not directly) so it should always show.

      In case the point is that this extension point is thought to be only there in case pipeline exists, then IMO we need another extension renderer call outside.

      REGRESSION because before we always rendered the extension point.

          [JENKINS-43265] REGRESSION Dashboard showPipelineList prevents extension point rendering

          Thorsten Scherler created issue -

          James Dumay added a comment -

          tscherler is this for your new project?

          James Dumay added a comment - tscherler is this for your new project?
          James Dumay made changes -
          Epic Link New: JENKINS-35756 [ 171764 ]

          jamesdumay yeah I discovered it there, but generally IMO we can/should not create conditional extensions points that is a really bad idea.

          Thorsten Scherler added a comment - jamesdumay yeah I discovered it there, but generally IMO we can/should not create conditional extensions points that is a really bad idea.
          James Dumay made changes -
          Labels New: cloudbees-internal-steel technical-debt
          James Dumay made changes -
          Priority Original: Blocker [ 1 ] New: Minor [ 4 ]
          James Dumay made changes -
          Sprint New: Blue Ocean 1.1 [ 271 ]
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.1 [ 271 ] New: Blue Ocean - techdebt sprint 1 [ 291 ]
          James Dumay made changes -
          Rank New: Ranked higher
          James Dumay made changes -
          Rank New: Ranked higher

            cliffmeyers Cliff Meyers
            tscherler Thorsten Scherler
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: