Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43433

Allow SCMSource implementations to expose merge and origin of change request heads

      Acceptance criteria

      • Change requests as implemented in the SCM API expose to consumer code
        • the merge strategy
        • the origin
        • the origin branch name
      • In order to retain binary compatibility, some of this information may only be available / correct when the corresponding SCM API implementation plugin has been updated.
      • The Branch API plugin has been updated with tests of any new significant code paths relating to branch discovery
      • The Branch API plugin exposes the origin and origin branch name when such information is provided by the corresponding SCM API implementation plugin.
      • The GitHub Branch Source plugin has been updated to expose the new change request information.
        • Upgrading from the 2.x.y series of the GitHub Branch Source shall not trigger a rebuild storm.
        • Upgrading from the 1.x series of the GitHub Branch Source should make best effort not to trigger a rebuild storm.
      • The Bitbucket Branch Source plugin has been updated to expose the new change request information
        • Upgrading from the 2.x.y series of the Bitbucket Branch Source shall not trigger a rebuild storm.
        • Upgrading from the 1.x series of the Bitbucket Branch Source should make best effort not to trigger a rebuild storm.
      • The SCM API's implementer guide has been updated to reflect the new recommendations for implementing change requests.

          [JENKINS-43433] Allow SCMSource implementations to expose merge and origin of change request heads

          Stephen Connolly created issue -
          Stephen Connolly made changes -
          Epic Link New: JENKINS-43426 [ 180671 ]
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Stephen Connolly made changes -
          Remote Link New: This issue links to "PR#35 (Web Link)" [ 15914 ]
          Stephen Connolly made changes -
          Description New: h1. Acceptance criteria
           * Change requests expose
           ** the merge strategy
           ** the origin
           ** the origin branch name
           * In order to retain binary compatibility, some of this information may only be available / correct when the corresponding SCM API implementation plugin has been updated.
           * The Branch API plugin has been updated with tests of any new significant code paths relating to branch discovery
           * The Branch API plugin 
          Stephen Connolly made changes -
          Component/s New: bitbucket-branch-source-plugin [ 21428 ]
          Component/s New: branch-api-plugin [ 18621 ]
          Component/s New: github-branch-source-plugin [ 20858 ]
          Stephen Connolly made changes -
          Description Original: h1. Acceptance criteria
           * Change requests expose
           ** the merge strategy
           ** the origin
           ** the origin branch name
           * In order to retain binary compatibility, some of this information may only be available / correct when the corresponding SCM API implementation plugin has been updated.
           * The Branch API plugin has been updated with tests of any new significant code paths relating to branch discovery
           * The Branch API plugin 
          New: h1. Acceptance criteria
           * Change requests expose
           ** the merge strategy
           ** the origin
           ** the origin branch name
           * In order to retain binary compatibility, some of this information may only be available / correct when the corresponding SCM API implementation plugin has been updated.
           * The Branch API plugin has been updated with tests of any new significant code paths relating to branch discovery
           * The Branch API plugin exposes the origin and origin branch name when such information is provided by the corresponding SCM API implementation plugin.
           * The GitHub Branch Source plugin has been updated to expose the new change request information.
           ** Upgrading from the 2.x.y series of the GitHub Branch Source shall not trigger a rebuild storm.
           ** Upgrading from the 1.x series of the GitHub Branch Source should make best effort not to trigger a rebuild storm.
           * The Bitbucket Branch Source plugin has been updated to expose the new change request information
           ** Upgrading from the 2.x.y series of the Bitbucket Branch Source shall not trigger a rebuild storm.
           ** Upgrading from the 1.x series of the Bitbucket Branch Source should make best effort not to trigger a rebuild storm.
           * The SCM API's implementer guide has been updated to reflect the new recommendations for implementing change requests.
          Stephen Connolly made changes -
          Description Original: h1. Acceptance criteria
           * Change requests expose
           ** the merge strategy
           ** the origin
           ** the origin branch name
           * In order to retain binary compatibility, some of this information may only be available / correct when the corresponding SCM API implementation plugin has been updated.
           * The Branch API plugin has been updated with tests of any new significant code paths relating to branch discovery
           * The Branch API plugin exposes the origin and origin branch name when such information is provided by the corresponding SCM API implementation plugin.
           * The GitHub Branch Source plugin has been updated to expose the new change request information.
           ** Upgrading from the 2.x.y series of the GitHub Branch Source shall not trigger a rebuild storm.
           ** Upgrading from the 1.x series of the GitHub Branch Source should make best effort not to trigger a rebuild storm.
           * The Bitbucket Branch Source plugin has been updated to expose the new change request information
           ** Upgrading from the 2.x.y series of the Bitbucket Branch Source shall not trigger a rebuild storm.
           ** Upgrading from the 1.x series of the Bitbucket Branch Source should make best effort not to trigger a rebuild storm.
           * The SCM API's implementer guide has been updated to reflect the new recommendations for implementing change requests.
          New: h1. Acceptance criteria
           * Change requests as implemented in the SCM API expose to consumer code
           ** the merge strategy
           ** the origin
           ** the origin branch name
           * In order to retain binary compatibility, some of this information may only be available / correct when the corresponding SCM API implementation plugin has been updated.
           * The Branch API plugin has been updated with tests of any new significant code paths relating to branch discovery
           * The Branch API plugin exposes the origin and origin branch name when such information is provided by the corresponding SCM API implementation plugin.
           * The GitHub Branch Source plugin has been updated to expose the new change request information.
           ** Upgrading from the 2.x.y series of the GitHub Branch Source shall not trigger a rebuild storm.
           ** Upgrading from the 1.x series of the GitHub Branch Source should make best effort not to trigger a rebuild storm.
           * The Bitbucket Branch Source plugin has been updated to expose the new change request information
           ** Upgrading from the 2.x.y series of the Bitbucket Branch Source shall not trigger a rebuild storm.
           ** Upgrading from the 1.x series of the Bitbucket Branch Source should make best effort not to trigger a rebuild storm.
           * The SCM API's implementer guide has been updated to reflect the new recommendations for implementing change requests.
          Stephen Connolly made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevision.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSource.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/5653575447484d78a5a04a9100ba87ca35d789f0
          Log:
          JENKINS-43433 Adapt to new API

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevision.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSource.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/5653575447484d78a5a04a9100ba87ca35d789f0 Log: JENKINS-43433 Adapt to new API

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: