Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43507

Allow SCMSource and SCMNavigator subtypes to share common traits

      Examples of traits from the JENKINS-43426 epic:

      • There will be a strategy to use switch the checkout to over SSH and this will have a option to select the SSH Credentials for checkout.
      • There will be at least one strategy to subset the branches by name (include / exclude)
        • There will one implementation that uses the existing wildcard style
        • Other strategies may be added later to support different branch name matching rules, e.g. Regex, etc. These secondary strategies do not form part of the MVP but it may prove assist extension point API validation to proof-of-concept implement a second one.
      • There will be three strategies to subset the branches by type:
        • There will be a strategy to select origin branches. This strategy will have a drop-down mode selection:
          • Only origin branches that are not filed as PRs
          • Only origin branches that are filed as PRs
          • All origin branches irrespective of whether filed as PR or not
        • There will be a strategy to select origin PRs. This strategy will have a drop-down mode selection:
          • Merge commit PRs
          • Head commit PRs
          • Both merge commit and head commit PRs
        • There will be a strategy to select fork PRs. This strategy will have a drop-down mode selection:
          • Merge commit PRs
          • Head commit PRs
          • Both merge commit and head commit PRs
      • There will also be a drop-down for trust selection:
          • Show all fork PRs but only trust fork PRs from repository contributors
          • Only show PRs from repository contributors
          • Show and trust all fork PRs
             TBD determine if we need to expose suppression of automatic builds of untrusted PRs here.
        • There will be a proof-of-concept implementation of a tag support branch selector. This is not a feature experienced by users today, but there are api's & code which is ready to provide it. We won't ship this enabled by default in the release.
      • There will be the ability to control a subset of the Git plugin’s additional behaviours for the generated SCM of branches. This will be an applies to all setting. The available options will be subject to a whitelisting extension point (so that plugins can define additional Git behaviours and whitelist them in at the same time). The default whitelist will be:
        • Advanced Checkout behaviours
        • Advanced Clone behaviours
        • Advanced Submodule behaviours
        • Clean after checkout
        • Clean before checkout
        • Custom user name / email address
        • Git LFS pull after checkout
        • Use commit author in changelog (says it requires workspace polling, but really does not / should not require workspace polling)
        • Wipe out repository & force clone

      Acceptance criteria

      • The SCM API provides the concept of a trait that applies to SCMSource and SCMNavigator
      • Traits will be opt-in, i.e. the SCMSource implementation must be written to use traits
      • Common trait implementations can be shared by multiple implementations.
      • Trait implementations can be specific to a single SCMSource or SCMNavigator
      • The SCM API will provide a trait implementation that allows for filtering branches based on include/exclude wildcard name matching
      • The SCM API MockSCM implementation will support traits
      • The common trait implementations in SCM API will have tests
      • The implementers guide will be updated to highlight the trait style of implementation and encourage following that path. 

          [JENKINS-43507] Allow SCMSource and SCMNavigator subtypes to share common traits

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/git-plugin/ee664b5638ee3fe33df4380de5526718f0a80161
          Log:
          JENKINS-43507 Pickup SCM-API timestamped snapshot

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/git-plugin/ee664b5638ee3fe33df4380de5526718f0a80161 Log: JENKINS-43507 Pickup SCM-API timestamped snapshot

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/git/GitSCM.java
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMBuilder.java
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          src/main/java/jenkins/plugins/git/traits/GitBrowserSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTrait.java
          src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTraitDescriptor.java
          src/main/java/jenkins/plugins/git/traits/GitToolSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/IgnoreOnPushNotificationTrait.java
          src/main/java/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/RemoteNameSCMSourceTrait.java
          src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java
          src/test/java/jenkins/plugins/git/traits/GitSCMExtensionTraitTest.java
          http://jenkins-ci.org/commit/git-plugin/639674899c03e0c2e002c9fa4fc9b1af5dfb221f
          Log:
          JENKINS-43507 Allow adding additional remotes to the GitSCMBuilder

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/traits/GitBrowserSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTrait.java src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTraitDescriptor.java src/main/java/jenkins/plugins/git/traits/GitToolSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/IgnoreOnPushNotificationTrait.java src/main/java/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/RemoteNameSCMSourceTrait.java src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java src/test/java/jenkins/plugins/git/traits/GitSCMExtensionTraitTest.java http://jenkins-ci.org/commit/git-plugin/639674899c03e0c2e002c9fa4fc9b1af5dfb221f Log: JENKINS-43507 Allow adding additional remotes to the GitSCMBuilder

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          http://jenkins-ci.org/commit/git-plugin/4cfcc5177dae91872034afe46c4042c561d274c3
          Log:
          JENKINS-43507 Lower restrictions on deprecated methods

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSource.java http://jenkins-ci.org/commit/git-plugin/4cfcc5177dae91872034afe46c4042c561d274c3 Log: JENKINS-43507 Lower restrictions on deprecated methods

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/MethodUtils.java
          http://jenkins-ci.org/commit/git-plugin/c3a66f296ef1ccbf117b4a1f85cdd56577c7b1c0
          Log:
          JENKINS-43507 Add workaround for JENKINS-30002 until available in baseline version of Jenkins core

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/MethodUtils.java http://jenkins-ci.org/commit/git-plugin/c3a66f296ef1ccbf117b4a1f85cdd56577c7b1c0 Log: JENKINS-43507 Add workaround for JENKINS-30002 until available in baseline version of Jenkins core

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/GitSCMBuilder.java
          src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java
          src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java
          http://jenkins-ci.org/commit/git-plugin/a2afab28641c8f957109f8358e2183361bbd66d0
          Log:
          JENKINS-43507 Handle refspec aggregation correctly and GitSCM built by GitSCMSource should honour refspecs on clone and not fetch tags

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java http://jenkins-ci.org/commit/git-plugin/a2afab28641c8f957109f8358e2183361bbd66d0 Log: JENKINS-43507 Handle refspec aggregation correctly and GitSCM built by GitSCMSource should honour refspecs on clone and not fetch tags

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/GitSCMBuilder.java
          src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java
          http://jenkins-ci.org/commit/git-plugin/1f0d0e15e0dd91db6819d4b38fb371c1908f2392
          Log:
          JENKINS-43507 Future-proof for if we implement TagSCMHead discovery

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java http://jenkins-ci.org/commit/git-plugin/1f0d0e15e0dd91db6819d4b38fb371c1908f2392 Log: JENKINS-43507 Future-proof for if we implement TagSCMHead discovery

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          src/test/java/hudson/plugins/git/browser/GithubWebTest.java
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTrivialTest.java
          http://jenkins-ci.org/commit/git-plugin/07ba4b5735c6c2a57b41b384b3a2e16569b89be3
          Log:
          JENKINS-43507 Pick up changes for JENKINS-44891

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/test/java/hudson/plugins/git/browser/GithubWebTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTrivialTest.java http://jenkins-ci.org/commit/git-plugin/07ba4b5735c6c2a57b41b384b3a2e16569b89be3 Log: JENKINS-43507 Pick up changes for JENKINS-44891

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
          http://jenkins-ci.org/commit/git-plugin/dd3e427593857367cbec598c693155f05bb6fb0b
          Log:
          JENKINS-43507 Bump structs to 1.8 and fix tests

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java http://jenkins-ci.org/commit/git-plugin/dd3e427593857367cbec598c693155f05bb6fb0b Log: JENKINS-43507 Bump structs to 1.8 and fix tests

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/git-plugin/a894dfbb14cd226c2be55589eb922efc6d32e9b2
          Log:
          JENKINS-43507 Pick up alpha-1 of scm-api

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/git-plugin/a894dfbb14cd226c2be55589eb922efc6d32e9b2 Log: JENKINS-43507 Pick up alpha-1 of scm-api

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorContext.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorRequest.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/LazyIterable.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/LazySet.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SinglePassIterable.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-excludes.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-includes.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/config.jelly
          http://jenkins-ci.org/commit/github-branch-source-plugin/e14433f5f65abe165c8c78b68ba4c234860e099e
          Log:
          JENKINS-43507 Check-pointing work in progress

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorContext.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorRequest.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java src/main/java/org/jenkinsci/plugins/github_branch_source/LazyIterable.java src/main/java/org/jenkinsci/plugins/github_branch_source/LazySet.java src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/SinglePassIterable.java src/main/resources/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-excludes.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-includes.html src/main/resources/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/config.jelly http://jenkins-ci.org/commit/github-branch-source-plugin/e14433f5f65abe165c8c78b68ba4c234860e099e Log: JENKINS-43507 Check-pointing work in progress

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/83d93c5fe1fc8897d0b3dea993f54ab46de72d17
          Log:
          JENKINS-43507 More documentation

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java http://jenkins-ci.org/commit/github-branch-source-plugin/83d93c5fe1fc8897d0b3dea993f54ab46de72d17 Log: JENKINS-43507 More documentation

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/8d9f4ffd7268c3181f711670eade8ae8179c743b
          Log:
          JENKINS-43507 Documenting GitSCMBuilder

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/8d9f4ffd7268c3181f711670eade8ae8179c743b Log: JENKINS-43507 Documenting GitSCMBuilder

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/8e11cf86761c98b8b12f2a914704db7628f1c09b
          Log:
          JENKINS-43507 More javadoc documentation

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java http://jenkins-ci.org/commit/github-branch-source-plugin/8e11cf86761c98b8b12f2a914704db7628f1c09b Log: JENKINS-43507 More javadoc documentation

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/6c581b0a5e5d3f0ef75dc899d8b62e92e0297ddf
          Log:
          JENKINS-43507 Refactoring names

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/6c581b0a5e5d3f0ef75dc899d8b62e92e0297ddf Log: JENKINS-43507 Refactoring names

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/0978e5df727681f3d8fa0f134dbaacfc7228e452
          Log:
          JENKINS-43507 Documenting SCMHeadAuthority

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java http://jenkins-ci.org/commit/github-branch-source-plugin/0978e5df727681f3d8fa0f134dbaacfc7228e452 Log: JENKINS-43507 Documenting SCMHeadAuthority

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/42bcfe1aea0a8118352a38f3018fbbdb9eeb93d8
          Log:
          JENKINS-43507 Documentation drives code improvements

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java http://jenkins-ci.org/commit/github-branch-source-plugin/42bcfe1aea0a8118352a38f3018fbbdb9eeb93d8 Log: JENKINS-43507 Documentation drives code improvements

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorContext.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/f61a31b145710292679c346487772292a03639da
          Log:
          JENKINS-43507 Annotate overridden methods correctly

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorContext.java http://jenkins-ci.org/commit/github-branch-source-plugin/f61a31b145710292679c346487772292a03639da Log: JENKINS-43507 Annotate overridden methods correctly

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/6d85a9a12c96a85f05d8aa7c0f15899bc7d57fee
          Log:
          JENKINS-43507 Documenting SCMNavigatorRequest

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java http://jenkins-ci.org/commit/github-branch-source-plugin/6d85a9a12c96a85f05d8aa7c0f15899bc7d57fee Log: JENKINS-43507 Documenting SCMNavigatorRequest

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/77ea2b27b177a5f362e86f0fcb16a7bbeefad7db
          Log:
          JENKINS-43507 Documenting SCMNavigatorTrait and SCMNavigatorTraitDescriptor

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java http://jenkins-ci.org/commit/github-branch-source-plugin/77ea2b27b177a5f362e86f0fcb16a7bbeefad7db Log: JENKINS-43507 Documenting SCMNavigatorTrait and SCMNavigatorTraitDescriptor

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/ecada1f1a8116a668908527b612f42e198a70d42
          Log:
          JENKINS-43507 Should be first round complete for scm-api changes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/ecada1f1a8116a668908527b612f42e198a70d42 Log: JENKINS-43507 Should be first round complete for scm-api changes

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.jelly
          http://jenkins-ci.org/commit/github-branch-source-plugin/338984cb581e25bd7611a27f6acfcd61254ffa17
          Log:
          JENKINS-43507 Fix the <scm:traits> taglib

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.jelly http://jenkins-ci.org/commit/github-branch-source-plugin/338984cb581e25bd7611a27f6acfcd61254ffa17 Log: JENKINS-43507 Fix the <scm:traits> taglib

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMBuilder.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevision.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PushGHEventSubscriber.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.properties
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildForkPRHead.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildForkPRMerge.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginBranch.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginBranchWithPR.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginPRHead.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginPRMerge.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-checkoutCredentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-credentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-excludes.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-includes.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-pattern.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-scanCredentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.jelly
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.properties
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildForkPRHead.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildForkPRMerge.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginBranch.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginBranchWithPR.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginPRHead.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginPRMerge.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-checkoutCredentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties
          src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/config.jelly
          src/test/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTraitTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTraitTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMBuilderTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTraitTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTraitTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/10b52c1f381e6080865fe039afbe658ff4958206
          Log:
          JENKINS-43507 Switch to GitHubSCMBuilder

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMBuilder.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java src/main/java/org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension.java src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestGHEventSubscriber.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevision.java src/main/java/org/jenkinsci/plugins/github_branch_source/PushGHEventSubscriber.java src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config.properties src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildForkPRHead.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildForkPRMerge.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginBranch.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginBranchWithPR.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginPRHead.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-buildOriginPRMerge.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-checkoutCredentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-credentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-excludes.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-includes.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-pattern.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-scanCredentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.jelly src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail.properties src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildForkPRHead.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildForkPRMerge.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginBranch.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginBranchWithPR.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginPRHead.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-buildOriginPRMerge.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-checkoutCredentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/Messages.properties src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/config.jelly src/test/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTraitTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTraitTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMBuilderTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTraitTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTraitTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/10b52c1f381e6080865fe039afbe658ff4958206 Log: JENKINS-43507 Switch to GitHubSCMBuilder

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMBuilder.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/basic_cloud.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/basic_server.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/exclude_branches.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/limit_branches.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/limit_repositories.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/modern.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/use_agent_checkout.xml
          http://jenkins-ci.org/commit/github-branch-source-plugin/19b1697519ca20bd08022ed96a5a591a25e78abe
          Log:
          JENKINS-43507 Tidy up GitHubSCMNavigator

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMBuilder.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/basic_cloud.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/basic_server.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_000111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_001111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_010111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_011111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_100111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_101111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_110111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/build_111111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/exclude_branches.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/limit_branches.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/limit_repositories.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/modern.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest/use_agent_checkout.xml http://jenkins-ci.org/commit/github-branch-source-plugin/19b1697519ca20bd08022ed96a5a591a25e78abe Log: JENKINS-43507 Tidy up GitHubSCMNavigator

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/da85c3797caaf35ee0ef01db2d738bb3ddd2e299
          Log:
          JENKINS-43507 Javadocs

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/da85c3797caaf35ee0ef01db2d738bb3ddd2e299 Log: JENKINS-43507 Javadocs

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/642695b819ff185919cf9724998dfd3421a94c5b
          Log:
          JENKINS-43507 Allow extension plugins to disable notifications

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubBuildStatusNotification.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java http://jenkins-ci.org/commit/github-branch-source-plugin/642695b819ff185919cf9724998dfd3421a94c5b Log: JENKINS-43507 Allow extension plugins to disable notifications

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorContext.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorRequest.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/LazyIterable.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/LazySet.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SinglePassIterable.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/cbdb2bd016fe735f34e8453cda6c0642c3da545e
          Log:
          JENKINS-43507 Documentation and formatting

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorContext.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorRequest.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceBuilder.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java src/main/java/org/jenkinsci/plugins/github_branch_source/LazyIterable.java src/main/java/org/jenkinsci/plugins/github_branch_source/LazySet.java src/main/java/org/jenkinsci/plugins/github_branch_source/SinglePassIterable.java http://jenkins-ci.org/commit/github-branch-source-plugin/cbdb2bd016fe735f34e8453cda6c0642c3da545e Log: JENKINS-43507 Documentation and formatting

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/basic_cloud.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/basic_server.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111000.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111001.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111010.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111011.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111100.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111101.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111110.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111111.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/custom_checkout_credentials.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/exclude_branches.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/limit_branches.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/modern.xml
          src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/use_agent_checkout.xml
          http://jenkins-ci.org/commit/github-branch-source-plugin/f9a02c67f9dff2bb6522ca0b8fad95406feacb96
          Log:
          JENKINS-43507 Add tests for GitHubSCMSource

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/basic_cloud.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/basic_server.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_000111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_001111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_010111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_011111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_100111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_101111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_110111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111000.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111001.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111010.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111011.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111100.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111101.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111110.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/build_111111.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/custom_checkout_credentials.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/exclude_branches.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/limit_branches.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/modern.xml src/test/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest/use_agent_checkout.xml http://jenkins-ci.org/commit/github-branch-source-plugin/f9a02c67f9dff2bb6522ca0b8fad95406feacb96 Log: JENKINS-43507 Add tests for GitHubSCMSource

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevision.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSource.java
          src/main/resources/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait/help-strategyId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait/help.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help-strategyId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help-trust.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-apiUri.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-traits.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-apiUri.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-credentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-repository.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-scanCredentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-traits.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/help-strategyId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/help.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/help-credentialsId.html
          src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/help.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/46d3cb501ff63bebd153abb79fad3c8f36c1c669
          Log:
          JENKINS-43507 Add help files and tidy up misc code changes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMRevision.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSource.java src/main/resources/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait/help-strategyId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait/help.html src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help-strategyId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help-trust.html src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-apiUri.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/help-traits.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-apiUri.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-credentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-repository.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-scanCredentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/help-traits.html src/main/resources/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/help-strategyId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait/help.html src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/help-credentialsId.html src/main/resources/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait/help.html http://jenkins-ci.org/commit/github-branch-source-plugin/46d3cb501ff63bebd153abb79fad3c8f36c1c669 Log: JENKINS-43507 Add help files and tidy up misc code changes

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystemTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/854aa02f61f11c5defdd129f03216df977a3505b
          Log:
          JENKINS-43507 Fix tests with invalid nulls

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMFileSystemTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/854aa02f61f11c5defdd129f03216df977a3505b Log: JENKINS-43507 Fix tests with invalid nulls

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/FillErrorResponse.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/ae7a939175d161edf8ac196b3617e9e8d75f4db0
          Log:
          JENKINS-43507 re-use Throwable.getMessage()

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/FillErrorResponse.java http://jenkins-ci.org/commit/github-branch-source-plugin/ae7a939175d161edf8ac196b3617e9e8d75f4db0 Log: JENKINS-43507 re-use Throwable.getMessage()

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/56b44abb24fba177cb3dadfce49dd0e49954386f
          Log:
          JENKINS-43507 Remove redundant check (only ever called when value is `true` anyway)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java http://jenkins-ci.org/commit/github-branch-source-plugin/56b44abb24fba177cb3dadfce49dd0e49954386f Log: JENKINS-43507 Remove redundant check (only ever called when value is `true` anyway)

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/github-branch-source-plugin/b84fa6194c7daf36f121d4eb997c1fcb818b3b3a
          Log:
          JENKINS-43507 Pick up alpha-1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/github-branch-source-plugin/b84fa6194c7daf36f121d4eb997c1fcb818b3b3a Log: JENKINS-43507 Pick up alpha-1

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSourceContext.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSourceRequest.java
          src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail.jelly
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-branchPattern.html
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-clean.html
          src/main/resources/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait/config.jelly
          src/main/resources/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait/config.jelly
          src/main/resources/hudson/plugins/mercurial/traits/Messages.properties
          http://jenkins-ci.org/commit/mercurial-plugin/fe7b13e9769a83b0ba9a75034054ec622d22d33e
          Log:
          JENKINS-43507 Adapt MercurialSCMSource to use traits

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java src/main/java/hudson/plugins/mercurial/MercurialSCMSourceContext.java src/main/java/hudson/plugins/mercurial/MercurialSCMSourceRequest.java src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail.jelly src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-branchPattern.html src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-clean.html src/main/resources/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait/config.jelly src/main/resources/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait/config.jelly src/main/resources/hudson/plugins/mercurial/traits/Messages.properties http://jenkins-ci.org/commit/mercurial-plugin/fe7b13e9769a83b0ba9a75034054ec622d22d33e Log: JENKINS-43507 Adapt MercurialSCMSource to use traits

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-modules.html
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-subdir.html
          src/main/resources/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait/help.html
          http://jenkins-ci.org/commit/mercurial-plugin/a87b60abb9a827e7a551984350ab68273a79c295
          Log:
          JENKINS-43507 Remove dead help files and restore live one

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-modules.html src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-subdir.html src/main/resources/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait/help.html http://jenkins-ci.org/commit/mercurial-plugin/a87b60abb9a827e7a551984350ab68273a79c295 Log: JENKINS-43507 Remove dead help files and restore live one

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/mercurial-plugin/18514a4916ecde2381eacbcbd0fc47f4f867df12
          Log:
          JENKINS-43507 Flag that the data model changes and bump to 2.0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/mercurial-plugin/18514a4916ecde2381eacbcbd0fc47f4f867df12 Log: JENKINS-43507 Flag that the data model changes and bump to 2.0

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialStatus.java
          http://jenkins-ci.org/commit/mercurial-plugin/e09089d2ecfcef2cb690b28496f0cddd1ade7f1a
          Log:
          JENKINS-43507 Fix check of repository source

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialStatus.java http://jenkins-ci.org/commit/mercurial-plugin/e09089d2ecfcef2cb690b28496f0cddd1ade7f1a Log: JENKINS-43507 Fix check of repository source

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/fc225569f9de83bc21aa43806223b95e1d34fc45
          Log:
          JENKINS-43507 Fix optionality of configuration

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/fc225569f9de83bc21aa43806223b95e1d34fc45 Log: JENKINS-43507 Fix optionality of configuration

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java
          http://jenkins-ci.org/commit/mercurial-plugin/d41c75101388fd42b4939dab62000329c8e2c6fa
          Log:
          JENKINS-43507 Update to latest -SNAPSHOT of scm-api

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java http://jenkins-ci.org/commit/mercurial-plugin/d41c75101388fd42b4939dab62000329c8e2c6fa Log: JENKINS-43507 Update to latest -SNAPSHOT of scm-api

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/b380c2f26987daaaf55d55353fec30e54590e12d
          Log:
          JENKINS-43507 Pick up changes for JENKINS-44891

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/b380c2f26987daaaf55d55353fec30e54590e12d Log: JENKINS-43507 Pick up changes for JENKINS-44891

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/mercurial-plugin/c519a25a811a2662a784757cfa84aee3f5ac30b1
          Log:
          JENKINS-43507 Pick up structs 1.8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/mercurial-plugin/c519a25a811a2662a784757cfa84aee3f5ac30b1 Log: JENKINS-43507 Pick up structs 1.8

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/900cbd038e4e6c24b1590c62edaa0f69fd7a3b49
          Log:
          JENKINS-43507 Code review comments

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/900cbd038e4e6c24b1590c62edaa0f69fd7a3b49 Log: JENKINS-43507 Code review comments

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java
          src/main/resources/hudson/plugins/mercurial/traits/Messages.properties
          http://jenkins-ci.org/commit/mercurial-plugin/f08319695b43f1e062619007761cfd16cf2216fd
          Log:
          JENKINS-43507 I18n

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java src/main/resources/hudson/plugins/mercurial/traits/Messages.properties http://jenkins-ci.org/commit/mercurial-plugin/f08319695b43f1e062619007761cfd16cf2216fd Log: JENKINS-43507 I18n

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSourceContext.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSourceRequest.java
          http://jenkins-ci.org/commit/mercurial-plugin/58a659549babed18bef6684647b5e3e72bd6237c
          Log:
          JENKINS-43507 Copyright headers

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java src/main/java/hudson/plugins/mercurial/MercurialSCMSourceContext.java src/main/java/hudson/plugins/mercurial/MercurialSCMSourceRequest.java http://jenkins-ci.org/commit/mercurial-plugin/58a659549babed18bef6684647b5e3e72bd6237c Log: JENKINS-43507 Copyright headers

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/mercurial-plugin/075a1ba42a03056ab6cb3c61f010e2b03994b619
          Log:
          JENKINS-43507 Plugin maintainer doesn't want

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/mercurial-plugin/075a1ba42a03056ab6cb3c61f010e2b03994b619 Log: JENKINS-43507 Plugin maintainer doesn't want

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/e8bbfc981e21f0f4176b1ccd2da4954e822388ed
          Log:
          JENKINS-43507 Plugin requested formatting changes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/e8bbfc981e21f0f4176b1ccd2da4954e822388ed Log: JENKINS-43507 Plugin requested formatting changes

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/mercurial-plugin/01fe831d00e1e137e9ec8a21fe8e3d3f7ef1e77f
          Log:
          JENKINS-43507 Whitespace

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/mercurial-plugin/01fe831d00e1e137e9ec8a21fe8e3d3f7ef1e77f Log: JENKINS-43507 Whitespace

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/mercurial-plugin/26f4d2846d88e550d66f41b17e268ab22e56dec9
          Log:
          JENKINS-43507 Pick up -alpha-1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/mercurial-plugin/26f4d2846d88e550d66f41b17e268ab22e56dec9 Log: JENKINS-43507 Pick up -alpha-1

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config_en.properties
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config_en_US.properties
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail_en.properties
          src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail_en_US.properties
          http://jenkins-ci.org/commit/github-branch-source-plugin/efaf706d116b2c956fbe6c8eb8df4a5e69b34ff6
          Log:
          JENKINS-43507 US people want to spell things incorrectly

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config_en.properties src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator/config_en_US.properties src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail_en.properties src/main/resources/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource/config-detail_en_US.properties http://jenkins-ci.org/commit/github-branch-source-plugin/efaf706d116b2c956fbe6c8eb8df4a5e69b34ff6 Log: JENKINS-43507 US people want to spell things incorrectly

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/d4f2fda50687538058312e635c78605dde7be66c
          Log:
          JENKINS-43507 There will be no 2.1.0 release

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSCMHead.java src/main/java/org/jenkinsci/plugins/github_branch_source/PullRequestSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/d4f2fda50687538058312e635c78605dde7be66c Log: JENKINS-43507 There will be no 2.1.0 release

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/394d016d15970d1abf9f085f63dea741137ad4bc
          Log:
          JENKINS-43507 Legacy constructor needs to apply default discovery behaviours

          • BlueOcean continually destroys and recreates the SCMNavigator without round-tripping through stapler form-binding
            consequently it does not pick up the legacy default discovery traits.
          • Also found a trait duplication bug in GitHubSCMSource that was missed due to a faulty test but caught when replicating
            the new legacy constructor tests from navigator into source 'just to be sure to be sure'

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/394d016d15970d1abf9f085f63dea741137ad4bc Log: JENKINS-43507 Legacy constructor needs to apply default discovery behaviours BlueOcean continually destroys and recreates the SCMNavigator without round-tripping through stapler form-binding consequently it does not pick up the legacy default discovery traits. Also found a trait duplication bug in GitHubSCMSource that was missed due to a faulty test but caught when replicating the new legacy constructor tests from navigator into source 'just to be sure to be sure'

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/d60356851c8ae6a37a46fa40f44711e35bd3c1aa
          Log:
          JENKINS-43507 Measure twice, cut once

          • checking with the set eliminates an incorrect copy-pasta error

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/d60356851c8ae6a37a46fa40f44711e35bd3c1aa Log: JENKINS-43507 Measure twice, cut once checking with the set eliminates an incorrect copy-pasta error

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en_US.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_it.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_ja.properties
          http://jenkins-ci.org/commit/git-plugin/f52fe82f16ec96dc1fde3cae53877d455e1ac9e8
          Log:
          JENKINS-43507 US people want to spell things incorrectly

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en.properties src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en_US.properties src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_it.properties src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_ja.properties http://jenkins-ci.org/commit/git-plugin/f52fe82f16ec96dc1fde3cae53877d455e1ac9e8 Log: JENKINS-43507 US people want to spell things incorrectly

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          http://jenkins-ci.org/commit/git-plugin/15f218a5aeb3dc52b777c3e7ba4bb35aed1b8ef7
          Log:
          JENKINS-43507 Found some minor bugs in the form validation action method names

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/GitSCMSource.java http://jenkins-ci.org/commit/git-plugin/15f218a5aeb3dc52b777c3e7ba4bb35aed1b8ef7 Log: JENKINS-43507 Found some minor bugs in the form validation action method names

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSourceContext.java
          src/main/java/jenkins/plugins/git/GitSCMSourceRequest.java
          src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java
          src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/help.html
          src/main/resources/jenkins/plugins/git/traits/Messages.properties
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
          src/test/java/jenkins/plugins/git/GitSCMSourceTraitsTest.java
          src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/modern.xml
          src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/pimpped_out.xml
          http://jenkins-ci.org/commit/git-plugin/1c1c664d1a18c600443a3ffe66f2a30ec2bd47ef
          Log:
          JENKINS-43507 Give GitSCMSource a BranchDiscoveryTrait in preparation for JENKINS-33445

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/GitSCMSourceRequest.java src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/help.html src/main/resources/jenkins/plugins/git/traits/Messages.properties src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTraitsTest.java src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/modern.xml src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/pimpped_out.xml http://jenkins-ci.org/commit/git-plugin/1c1c664d1a18c600443a3ffe66f2a30ec2bd47ef Log: JENKINS-43507 Give GitSCMSource a BranchDiscoveryTrait in preparation for JENKINS-33445

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java
          src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTraitDescriptor.java
          http://jenkins-ci.org/commit/git-plugin/1743eab6b24a52e94847ae3f278c184d0f51eb47
          Log:
          JENKINS-43507 Fix trait drop-down list population

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTraitDescriptor.java http://jenkins-ci.org/commit/git-plugin/1743eab6b24a52e94847ae3f278c184d0f51eb47 Log: JENKINS-43507 Fix trait drop-down list population

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en.properties
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en_US.properties
          http://jenkins-ci.org/commit/mercurial-plugin/d632ecb5ec2ad5bfcdf9381b4f4eca34f8406c48
          Log:
          JENKINS-43507 US people want to spell things incorrectly

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en.properties src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en_US.properties http://jenkins-ci.org/commit/mercurial-plugin/d632ecb5ec2ad5bfcdf9381b4f4eca34f8406c48 Log: JENKINS-43507 US people want to spell things incorrectly

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/b1bc5a40f01db1d23a3ece9ab8dd5ba3bf1e92b2
          Log:
          JENKINS-43507 Fix trait drop-down list population

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/b1bc5a40f01db1d23a3ece9ab8dd5ba3bf1e92b2 Log: JENKINS-43507 Fix trait drop-down list population

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/8c5447bd5014844dd27943a7b76fd8bc24a7aeb2
          Log:
          JENKINS-43507 Found some minor bugs in the form validation action method names

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java http://jenkins-ci.org/commit/github-branch-source-plugin/8c5447bd5014844dd27943a7b76fd8bc24a7aeb2 Log: JENKINS-43507 Found some minor bugs in the form validation action method names

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/2477059d2539af4f414417088f8430061980cdb6
          Log:
          JENKINS-43507 Found some minor documentation errors

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceContext.java http://jenkins-ci.org/commit/github-branch-source-plugin/2477059d2539af4f414417088f8430061980cdb6 Log: JENKINS-43507 Found some minor documentation errors

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/471e5b7b5288628810c4f344647e870fcc96f39f
          Log:
          JENKINS-43507 Fix trait drop-down list population

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/BranchDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/main/java/org/jenkinsci/plugins/github_branch_source/OriginPullRequestDiscoveryTrait.java src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java http://jenkins-ci.org/commit/github-branch-source-plugin/471e5b7b5288628810c4f344647e870fcc96f39f Log: JENKINS-43507 Fix trait drop-down list population

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/b35932383d8d4cd7185dfd1bd8e3c41c03d31b23
          Log:
          JENKINS-43507 Fresh eyes find and fix fresh bugs

          • Need to upgrade to structs 1.9 to pick up JENKINS-45130
          • Two legacy setters were not purging useless traits, and we were missing tests to verify same
          • Pick up git's -alpha-4

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/b35932383d8d4cd7185dfd1bd8e3c41c03d31b23 Log: JENKINS-43507 Fresh eyes find and fix fresh bugs Need to upgrade to structs 1.9 to pick up JENKINS-45130 Two legacy setters were not purging useless traits, and we were missing tests to verify same Pick up git's -alpha-4

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/scm-api-plugin/dc0081a16d00c4de17a64430ae4aacbbbd306bfd
          Log:
          JENKINS-43507 Bump structs to 1.9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/scm-api-plugin/dc0081a16d00c4de17a64430ae4aacbbbd306bfd Log: JENKINS-43507 Bump structs to 1.9

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/branch-api-plugin/baeae5db935b06f6e202ab345236450b388725b9
          Log:
          JENKINS-43507 Bump structs to 1.9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/branch-api-plugin/baeae5db935b06f6e202ab345236450b388725b9 Log: JENKINS-43507 Bump structs to 1.9

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/mercurial-plugin/120115bba0e07af04518ccec06098332ad85c15f
          Log:
          JENKINS-43507 Bump structs to 1.9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/mercurial-plugin/120115bba0e07af04518ccec06098332ad85c15f Log: JENKINS-43507 Bump structs to 1.9

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSourceContext.java
          src/main/java/hudson/plugins/mercurial/MercurialSCMSourceRequest.java
          src/main/java/hudson/plugins/mercurial/MercurialStatus.java
          src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java
          src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail.jelly
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en.properties
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en_US.properties
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-branchPattern.html
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-clean.html
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-modules.html
          src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-subdir.html
          src/main/resources/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait/help.html
          src/main/resources/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait/config.jelly
          src/main/resources/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait/config.jelly
          src/main/resources/hudson/plugins/mercurial/traits/Messages.properties
          http://jenkins-ci.org/commit/mercurial-plugin/bfc7cbd995afc08d0bc0bbefaf741685ab3d2d13
          Log:
          Merge pull request #103 from stephenc/jenkins-43507

          JENKINS-43507 Allow SCMSource and SCMNavigator subtypes to share common traits

          Compare: https://github.com/jenkinsci/mercurial-plugin/compare/eb08ce42afbe...bfc7cbd995af

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMBuilder.java src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java src/main/java/hudson/plugins/mercurial/MercurialSCMSourceContext.java src/main/java/hudson/plugins/mercurial/MercurialSCMSourceRequest.java src/main/java/hudson/plugins/mercurial/MercurialStatus.java src/main/java/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait.java src/main/java/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait.java src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail.jelly src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en.properties src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/config-detail_en_US.properties src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-branchPattern.html src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-clean.html src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-modules.html src/main/resources/hudson/plugins/mercurial/MercurialSCMSource/help-subdir.html src/main/resources/hudson/plugins/mercurial/traits/CleanMercurialSCMSourceTrait/help.html src/main/resources/hudson/plugins/mercurial/traits/MercurialBrowserSCMSourceTrait/config.jelly src/main/resources/hudson/plugins/mercurial/traits/MercurialInstallationSCMSourceTrait/config.jelly src/main/resources/hudson/plugins/mercurial/traits/Messages.properties http://jenkins-ci.org/commit/mercurial-plugin/bfc7cbd995afc08d0bc0bbefaf741685ab3d2d13 Log: Merge pull request #103 from stephenc/jenkins-43507 JENKINS-43507 Allow SCMSource and SCMNavigator subtypes to share common traits Compare: https://github.com/jenkinsci/mercurial-plugin/compare/eb08ce42afbe...bfc7cbd995af

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/trait/SCMTrait.java
          src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java
          src/test/java/jenkins/scm/impl/mock/MockSCMSource.java
          http://jenkins-ci.org/commit/scm-api-plugin/82ee345a8c12df789d13a8962ab06e74960e7480
          Log:
          JENKINS-43507 Add some helper methods

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/trait/SCMTrait.java src/test/java/jenkins/scm/impl/mock/MockSCMNavigator.java src/test/java/jenkins/scm/impl/mock/MockSCMSource.java http://jenkins-ci.org/commit/scm-api-plugin/82ee345a8c12df789d13a8962ab06e74960e7480 Log: JENKINS-43507 Add some helper methods

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/scm/api/trait/SCMTrait.java
          http://jenkins-ci.org/commit/scm-api-plugin/9cefea35ffc7d92da66c38e5b9b8820246da8890
          Log:
          JENKINS-43507 Add javadoc tag

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/scm/api/trait/SCMTrait.java http://jenkins-ci.org/commit/scm-api-plugin/9cefea35ffc7d92da66c38e5b9b8820246da8890 Log: JENKINS-43507 Add javadoc tag

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/branch-api-plugin/2839698af742de05c0489a7f0ef2630d264c23dc
          Log:
          JENKINS-43507 Pick up new releases

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/branch-api-plugin/2839698af742de05c0489a7f0ef2630d264c23dc Log: JENKINS-43507 Pick up new releases

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/19dee71dec66d8f7a6472103f2f07cccccd2e822
          Log:
          JENKINS-43507 Pick up new releases

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/19dee71dec66d8f7a6472103f2f07cccccd2e822 Log: JENKINS-43507 Pick up new releases

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/b70384742a237cee0981801de435c4f739d98efb
          Log:
          JENKINS-43507 Findbugs being a bit of a pain

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/b70384742a237cee0981801de435c4f739d98efb Log: JENKINS-43507 Findbugs being a bit of a pain

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java
          http://jenkins-ci.org/commit/mercurial-plugin/f172e22494279f88bc633047c4606ff777677500
          Log:
          Merge pull request #105 from stephenc/jenkins-43507

          JENKINS-43507 Pick up new releases

          Compare: https://github.com/jenkinsci/mercurial-plugin/compare/8e0581ac7045...f172e2249427

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/mercurial/MercurialSCMSource.java http://jenkins-ci.org/commit/mercurial-plugin/f172e22494279f88bc633047c4606ff777677500 Log: Merge pull request #105 from stephenc/jenkins-43507 JENKINS-43507 Pick up new releases Compare: https://github.com/jenkinsci/mercurial-plugin/compare/8e0581ac7045...f172e2249427

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help-trust.html
          http://jenkins-ci.org/commit/github-branch-source-plugin/9ec1b734b66488a100ccaf78bb79248289359852
          Log:
          JENKINS-43507 Copy-pasta typo

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/org/jenkinsci/plugins/github_branch_source/ForkPullRequestDiscoveryTrait/help-trust.html http://jenkins-ci.org/commit/github-branch-source-plugin/9ec1b734b66488a100ccaf78bb79248289359852 Log: JENKINS-43507 Copy-pasta typo

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/git-plugin/33434848fe9eb41141878bfc2b72e96068b65fe9
          Log:
          JENKINS-43507 Bump structs to 1.9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/git-plugin/33434848fe9eb41141878bfc2b72e96068b65fe9 Log: JENKINS-43507 Bump structs to 1.9

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          http://jenkins-ci.org/commit/git-plugin/d7c3ece2553cf0494a56c766f62a6c9f340bbe4c
          Log:
          JENKINS-43507 Pick up new releases

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSource.java http://jenkins-ci.org/commit/git-plugin/d7c3ece2553cf0494a56c766f62a6c9f340bbe4c Log: JENKINS-43507 Pick up new releases

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          http://jenkins-ci.org/commit/git-plugin/af3d6fd54d85497709a5f6d98d7b94c7d73d3110
          Log:
          JENKINS-43507 Fix tests

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/GitSCMSource.java http://jenkins-ci.org/commit/git-plugin/af3d6fd54d85497709a5f6d98d7b94c7d73d3110 Log: JENKINS-43507 Fix tests

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/hudson/plugins/git/GitSCM.java
          src/main/java/hudson/plugins/git/extensions/impl/AuthorInChangelog.java
          src/main/java/hudson/plugins/git/extensions/impl/CheckoutOption.java
          src/main/java/hudson/plugins/git/extensions/impl/CleanBeforeCheckout.java
          src/main/java/hudson/plugins/git/extensions/impl/CleanCheckout.java
          src/main/java/hudson/plugins/git/extensions/impl/CloneOption.java
          src/main/java/hudson/plugins/git/extensions/impl/GitLFSPull.java
          src/main/java/hudson/plugins/git/extensions/impl/IgnoreNotifyCommit.java
          src/main/java/hudson/plugins/git/extensions/impl/LocalBranch.java
          src/main/java/hudson/plugins/git/extensions/impl/PruneStaleBranch.java
          src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java
          src/main/java/hudson/plugins/git/extensions/impl/UserIdentity.java
          src/main/java/hudson/plugins/git/extensions/impl/WipeWorkspace.java
          src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMBuilder.java
          src/main/java/jenkins/plugins/git/GitSCMFileSystem.java
          src/main/java/jenkins/plugins/git/GitSCMSource.java
          src/main/java/jenkins/plugins/git/GitSCMSourceContext.java
          src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java
          src/main/java/jenkins/plugins/git/GitSCMSourceRequest.java
          src/main/java/jenkins/plugins/git/MethodUtils.java
          src/main/java/jenkins/plugins/git/traits/AuthorInChangelogTrait.java
          src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java
          src/main/java/jenkins/plugins/git/traits/CheckoutOptionTrait.java
          src/main/java/jenkins/plugins/git/traits/CleanAfterCheckoutTrait.java
          src/main/java/jenkins/plugins/git/traits/CleanBeforeCheckoutTrait.java
          src/main/java/jenkins/plugins/git/traits/CloneOptionTrait.java
          src/main/java/jenkins/plugins/git/traits/GitBrowserSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/GitLFSPullTrait.java
          src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTrait.java
          src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTraitDescriptor.java
          src/main/java/jenkins/plugins/git/traits/GitToolSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/IgnoreOnPushNotificationTrait.java
          src/main/java/jenkins/plugins/git/traits/LocalBranchTrait.java
          src/main/java/jenkins/plugins/git/traits/PruneStaleBranchTrait.java
          src/main/java/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/RemoteNameSCMSourceTrait.java
          src/main/java/jenkins/plugins/git/traits/SubmoduleOptionTrait.java
          src/main/java/jenkins/plugins/git/traits/UserIdentityTrait.java
          src/main/java/jenkins/plugins/git/traits/WipeWorkspaceTrait.java
          src/main/java/jenkins/plugins/git/traits/package-info.java
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail.jelly
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en_US.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_it.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_ja.properties
          src/main/resources/jenkins/plugins/git/GitSCMSource/help-excludes.html
          src/main/resources/jenkins/plugins/git/GitSCMSource/help-gitTool.html
          src/main/resources/jenkins/plugins/git/GitSCMSource/help-ignoreOnPushNotifications.html
          src/main/resources/jenkins/plugins/git/GitSCMSource/help-includes.html
          src/main/resources/jenkins/plugins/git/GitSCMSource/help-rawRefSpecs.html
          src/main/resources/jenkins/plugins/git/GitSCMSource/help-remoteName.html
          src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/help.html
          src/main/resources/jenkins/plugins/git/traits/GitBrowserSCMSourceTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/GitSCMExtensionTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/GitToolSCMSourceTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/LocalBranchTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/Messages.properties
          src/main/resources/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait/RefSpecTemplate/config.jelly
          src/main/resources/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait/RefSpecTemplate/help-value.html
          src/main/resources/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait/config.jelly
          src/main/resources/jenkins/plugins/git/traits/RemoteNameSCMSourceTrait/config.jelly
          src/test/java/hudson/plugins/git/browser/GithubWebTest.java
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
          src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTrivialTest.java
          src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java
          src/test/java/jenkins/plugins/git/GitSCMSourceTraitsTest.java
          src/test/java/jenkins/plugins/git/traits/GitSCMExtensionTraitTest.java
          src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/modern.xml
          src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/pimpped_out.xml
          http://jenkins-ci.org/commit/git-plugin/dd2b84217cc967bf908c7f2c02beea27973cd884
          Log:
          Merge pull request #494 from stephenc/jenkins-43507

          JENKINS-43507 Allow SCMSource and SCMNavigator subtypes to share common traits

          Compare: https://github.com/jenkinsci/git-plugin/compare/2cfbf64ed55f...dd2b84217cc9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/hudson/plugins/git/GitSCM.java src/main/java/hudson/plugins/git/extensions/impl/AuthorInChangelog.java src/main/java/hudson/plugins/git/extensions/impl/CheckoutOption.java src/main/java/hudson/plugins/git/extensions/impl/CleanBeforeCheckout.java src/main/java/hudson/plugins/git/extensions/impl/CleanCheckout.java src/main/java/hudson/plugins/git/extensions/impl/CloneOption.java src/main/java/hudson/plugins/git/extensions/impl/GitLFSPull.java src/main/java/hudson/plugins/git/extensions/impl/IgnoreNotifyCommit.java src/main/java/hudson/plugins/git/extensions/impl/LocalBranch.java src/main/java/hudson/plugins/git/extensions/impl/PruneStaleBranch.java src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java src/main/java/hudson/plugins/git/extensions/impl/UserIdentity.java src/main/java/hudson/plugins/git/extensions/impl/WipeWorkspace.java src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMBuilder.java src/main/java/jenkins/plugins/git/GitSCMFileSystem.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/GitSCMSourceDefaults.java src/main/java/jenkins/plugins/git/GitSCMSourceRequest.java src/main/java/jenkins/plugins/git/MethodUtils.java src/main/java/jenkins/plugins/git/traits/AuthorInChangelogTrait.java src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java src/main/java/jenkins/plugins/git/traits/CheckoutOptionTrait.java src/main/java/jenkins/plugins/git/traits/CleanAfterCheckoutTrait.java src/main/java/jenkins/plugins/git/traits/CleanBeforeCheckoutTrait.java src/main/java/jenkins/plugins/git/traits/CloneOptionTrait.java src/main/java/jenkins/plugins/git/traits/GitBrowserSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/GitLFSPullTrait.java src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTrait.java src/main/java/jenkins/plugins/git/traits/GitSCMExtensionTraitDescriptor.java src/main/java/jenkins/plugins/git/traits/GitToolSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/IgnoreOnPushNotificationTrait.java src/main/java/jenkins/plugins/git/traits/LocalBranchTrait.java src/main/java/jenkins/plugins/git/traits/PruneStaleBranchTrait.java src/main/java/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/RemoteNameSCMSourceTrait.java src/main/java/jenkins/plugins/git/traits/SubmoduleOptionTrait.java src/main/java/jenkins/plugins/git/traits/UserIdentityTrait.java src/main/java/jenkins/plugins/git/traits/WipeWorkspaceTrait.java src/main/java/jenkins/plugins/git/traits/package-info.java src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail.jelly src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en.properties src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_en_US.properties src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_it.properties src/main/resources/jenkins/plugins/git/GitSCMSource/config-detail_ja.properties src/main/resources/jenkins/plugins/git/GitSCMSource/help-excludes.html src/main/resources/jenkins/plugins/git/GitSCMSource/help-gitTool.html src/main/resources/jenkins/plugins/git/GitSCMSource/help-ignoreOnPushNotifications.html src/main/resources/jenkins/plugins/git/GitSCMSource/help-includes.html src/main/resources/jenkins/plugins/git/GitSCMSource/help-rawRefSpecs.html src/main/resources/jenkins/plugins/git/GitSCMSource/help-remoteName.html src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/help.html src/main/resources/jenkins/plugins/git/traits/GitBrowserSCMSourceTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/GitSCMExtensionTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/GitToolSCMSourceTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/LocalBranchTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/Messages.properties src/main/resources/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait/RefSpecTemplate/config.jelly src/main/resources/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait/RefSpecTemplate/help-value.html src/main/resources/jenkins/plugins/git/traits/RefSpecsSCMSourceTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/RemoteNameSCMSourceTrait/config.jelly src/test/java/hudson/plugins/git/browser/GithubWebTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceRetrieveHeadsTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTrivialTest.java src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTraitsTest.java src/test/java/jenkins/plugins/git/traits/GitSCMExtensionTraitTest.java src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/modern.xml src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/pimpped_out.xml http://jenkins-ci.org/commit/git-plugin/dd2b84217cc967bf908c7f2c02beea27973cd884 Log: Merge pull request #494 from stephenc/jenkins-43507 JENKINS-43507 Allow SCMSource and SCMNavigator subtypes to share common traits Compare: https://github.com/jenkinsci/git-plugin/compare/2cfbf64ed55f...dd2b84217cc9

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/github-branch-source-plugin/eb6b6b474c32fa6af3c92e055845b756f8fe779f
          Log:
          JENKINS-43507 Pick up beta-1 releases

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/github-branch-source-plugin/eb6b6b474c32fa6af3c92e055845b756f8fe779f Log: JENKINS-43507 Pick up beta-1 releases

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/0395a38c496ee437adfcb58fe7762bb51d3cdc6c
          Log:
          JENKINS-43507 Fix more copy-pasta

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceRequest.java src/main/java/org/jenkinsci/plugins/github_branch_source/SSHCheckoutTrait.java http://jenkins-ci.org/commit/github-branch-source-plugin/0395a38c496ee437adfcb58fe7762bb51d3cdc6c Log: JENKINS-43507 Fix more copy-pasta

          John Mellor added a comment -

          So how are you supposed to use this change?
          I have updated to the GitHub Branch Source plugin v2.2.1, which according to the release note, incorporates this change.
          If I add a behaviour to specify the refspec, it gets ignored.
          Is there another shoe to drop in order to get this behaviour, or is this a bug?

          John Mellor added a comment - So how are you supposed to use this change? I have updated to the GitHub Branch Source plugin v2.2.1, which according to the release note, incorporates this change. If I add a behaviour to specify the refspec, it gets ignored. Is there another shoe to drop in order to get this behaviour, or is this a bug?

          alt_jmellor So when you added the additional refspec, was that refspec fetched when cloning?

          The additional refspec is not to define new branches or discovery of branches, rather to control what gets cloned (hence why it's not in the – Repository – section)

          Stephen Connolly added a comment - alt_jmellor So when you added the additional refspec, was that refspec fetched when cloning? The additional refspec is not to define new branches or discovery of branches, rather to control what gets cloned (hence why it's not in the – Repository – section)

          John Mellor added a comment - - edited

          > So when you added the additional refspec, was that refspec fetched when cloning?
          We're specifying a refspec of:

          +refs/tags/*:refs/remotes/@{remote}/tags/*
          

          and expecting it to pull tags. We can see no evidence in the log that this added refspec does anything at all. What should we be seeing?

          John Mellor added a comment - - edited > So when you added the additional refspec, was that refspec fetched when cloning? We're specifying a refspec of: +refs/tags/*:refs/remotes/@{remote}/tags/* and expecting it to pull tags. We can see no evidence in the log that this added refspec does anything at all. What should we be seeing?

          If you want tags you need to add Advanced Clone Behaviours and request tags. No need to add a refspec for tags (because git will handle tags differently)

          Stephen Connolly added a comment - If you want tags you need to add Advanced Clone Behaviours and request tags. No need to add a refspec for tags (because git will handle tags differently)

          John Mellor added a comment -

          We tried the advanced behaviour as suggested, and it does not pull tags.
          You can't request tags, only ignore tags, suggesting pulling tags is a default.

          So, how are you supposed to build a GitHub tag?

          John Mellor added a comment - We tried the advanced behaviour as suggested, and it does not pull tags. You can't request tags, only ignore tags, suggesting pulling tags is a default. So, how are you supposed to build a GitHub tag?

          Requesting tags is adding the behaviour and not selecting "ignore tags"

          Tag discovery has not been implemented yet, so likely you are trying to do something that would be better handled through tag discovery

          Stephen Connolly added a comment - Requesting tags is adding the behaviour and not selecting "ignore tags" Tag discovery has not been implemented yet, so likely you are trying to do something that would be better handled through tag discovery

          Here is a build log without the advanced behaviour

          Note that it says:

           > git config remote.origin.url https://github.com/cloudbeers/jenkins-45666.git # timeout=10
          Fetching without tags
          Fetching upstream changes from https://github.com/cloudbeers/jenkins-45666.git
           > git --version # timeout=10
          using GIT_ASKPASS to set credentials GitHub Personal Access Token
           > git fetch --no-tags --progress https://github.com/cloudbeers/jenkins-45666.git +refs/heads/master:refs/remotes/origin/master
          

          Now I added the advanced clone behaviour like so:

          Then the next build we get:

          Now the build for a branch says:

          Cloning repository https://github.com/cloudbeers/jenkins-45666.git
           > git init /home/jenkins/workspace/foo_master-FZSKR3Q3UA6Q3PNW2MT2SNMQP7UA3IDOLJFZI6LCOV45WBPS7X5Q # timeout=10
          Fetching upstream changes from https://github.com/cloudbeers/jenkins-45666.git
           > git --version # timeout=10
          using GIT_ASKPASS to set credentials GitHub Personal Access Token
           > git fetch --tags --progress https://github.com/cloudbeers/jenkins-45666.git +refs/heads/*:refs/remotes/origin/*
           > git config remote.origin.url https://github.com/cloudbeers/jenkins-45666.git # timeout=10
          

          So you can see the git fetch --tags which is fetching the tags into the clone used for the build

          Stephen Connolly added a comment - Here is a build log without the advanced behaviour Note that it says: > git config remote.origin.url https: //github.com/cloudbeers/jenkins-45666.git # timeout=10 Fetching without tags Fetching upstream changes from https: //github.com/cloudbeers/jenkins-45666.git > git --version # timeout=10 using GIT_ASKPASS to set credentials GitHub Personal Access Token > git fetch --no-tags --progress https: //github.com/cloudbeers/jenkins-45666.git +refs/heads/master:refs/remotes/origin/master Now I added the advanced clone behaviour like so: Then the next build we get: Now the build for a branch says: Cloning repository https: //github.com/cloudbeers/jenkins-45666.git > git init /home/jenkins/workspace/foo_master-FZSKR3Q3UA6Q3PNW2MT2SNMQP7UA3IDOLJFZI6LCOV45WBPS7X5Q # timeout=10 Fetching upstream changes from https: //github.com/cloudbeers/jenkins-45666.git > git --version # timeout=10 using GIT_ASKPASS to set credentials GitHub Personal Access Token > git fetch --tags --progress https: //github.com/cloudbeers/jenkins-45666.git +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https: //github.com/cloudbeers/jenkins-45666.git # timeout=10 So you can see the git fetch --tags which is fetching the tags into the clone used for the build

          Tag discovery has not been implemented yet

          So this is the missunderstanding

          Stephen, do you have a plan or a JIRA issue for implementing this?

          Thanks

          Alexandru Pătrănescu added a comment - Tag discovery has not been implemented yet So this is the missunderstanding Stephen, do you have a plan or a JIRA issue for implementing this? Thanks

          drealecs that would be JENKINS-34395 IIRC

          Stephen Connolly added a comment - drealecs that would be JENKINS-34395 IIRC

          Similar to alt_jmellor's question, I need tags when checking out our repo in our pipeline scripts.  Our current checkout step is simply

          checkout scm
          

          I don't understand from the previous posts how to add tags to this step

          Trever Wilhelm added a comment - Similar to alt_jmellor 's question, I need tags when checking out our repo in our pipeline scripts.  Our current checkout step is simply checkout scm I don't understand from the previous posts how to add tags to this step

          treverw you need to configure the branch source and just add Advanced Clone Behaviours and then checkout scm will automatically get the tags for you

          Stephen Connolly added a comment - treverw you need to configure the branch source and just add Advanced Clone Behaviours and then checkout scm will automatically get the tags for you

          Hi,

          There is an issue when building pull requests and the clone trait is present with shallow clone option.
          Apparently you need some history in order to be able to do a merge.
          I'm using the Bitbucket Server but I guess this is the same for GitHub...

          How can we fix this?
          a) Disable shallow clone when we know a merge will take place.
          b) Fetch more and more history until you are able to do the merge, checking with merge-base command I guess.

          Can we do this only in one place, maybe in hudson.plugins.git.extensions.impl.PreBuildMerge#decorateMergeCommand? or is it specific to each branch-source-plugin?

          Alexandru Pătrănescu added a comment - Hi, There is an issue when building pull requests and the clone trait is present with shallow clone option. Apparently you need some history in order to be able to do a merge. I'm using the Bitbucket Server but I guess this is the same for GitHub... How can we fix this? a) Disable shallow clone when we know a merge will take place. b) Fetch more and more history until you are able to do the merge, checking with merge-base command I guess. Can we do this only in one place, maybe in hudson.plugins.git.extensions.impl.PreBuildMerge#decorateMergeCommand ? or is it specific to each branch-source-plugin?

          drealecs can you create a separate issue for that.

          Likely we need to go with Disable shallow clone when we know a merge will take place

          For now, that needs to happen in each plugin, but we could refactor https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension.java and it's copies into the Git plugin and switch to use that (and have that turn off shallow clone)

          But all that should take place under a separate JIRA from this

          Stephen Connolly added a comment - drealecs can you create a separate issue for that. Likely we need to go with Disable shallow clone when we know a merge will take place For now, that needs to happen in each plugin, but we could refactor https://github.com/jenkinsci/github-branch-source-plugin/blob/master/src/main/java/org/jenkinsci/plugins/github_branch_source/MergeWithGitSCMExtension.java and it's copies into the Git plugin and switch to use that (and have that turn off shallow clone) But all that should take place under a separate JIRA from this

          Created JENKINS-45771.

          Alexandru Pătrănescu added a comment - Created JENKINS-45771 .

          Riko Eksteen added a comment - - edited

          I think this issue, which is marked as minor, contains a massive breaking change, i.e. above-mentioned fetching without tags. I have just spent almost a day trying to figure out why my builds no longer work.

          This started to surface as a build error when referring to a tag that didn't exist, then progressing to figure out that where previously my scm step executed with git fetch --tags, it is now executing with git fetch --no-tags, and then a wild goose chase of trying to downgrade various plugins that were upgraded recently, including the branch source plugin, the pipeline plugin, the pipeline scm plugin, and also the git plugin (which didn't work because other plugins depended on it).

          I also went down the route of trying to change our Jenkinsfile which is using "checkout scm" step to try and specify more configuration options, all without success.

          I eventually searched google for the string "Cloning with configured refspecs honoured and without tags" from my build output, which led me to https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/extensions/impl/CloneOption.java, and finally this thread.

          To prevent other users being led on this merry chase, I strongly recommend that you make it exceedingly clear that this new feature causes a regression whereby builds that previously fetched with tags now don't.

          It is also very unintuitive and unclear that adding "Advanced clone options" without checking any of its flags or filling out any of its properties magically restores the fetch with tags behaviour.

          It is unexpected that adding something without configuring it would change the behaviour.

          Development tools should lead users into the pit of success, not the pit of failure (and despair!). Please reconsider the impact of this change, or alternatively add a big fat warning for users upgrading to this version that their builds will behave differently now.

          Thanks for the wonderful tool that Jenkins is, and all the great work on the main server, this, and other plugins.

          Riko Eksteen added a comment - - edited I think this issue, which is marked as minor, contains a massive breaking change, i.e. above-mentioned fetching without tags. I have just spent almost a day trying to figure out why my builds no longer work. This started to surface as a build error when referring to a tag that didn't exist, then progressing to figure out that where previously my scm step executed with git fetch --tags, it is now executing with git fetch --no-tags, and then a wild goose chase of trying to downgrade various plugins that were upgraded recently, including the branch source plugin, the pipeline plugin, the pipeline scm plugin, and also the git plugin (which didn't work because other plugins depended on it). I also went down the route of trying to change our Jenkinsfile which is using "checkout scm" step to try and specify more configuration options, all without success. I eventually searched google for the string "Cloning with configured refspecs honoured and without tags" from my build output, which led me to https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/extensions/impl/CloneOption.java,  and finally this thread. To prevent other users being led on this merry chase, I strongly recommend that you make it exceedingly clear that this new feature causes a regression whereby builds that previously fetched with tags now don't. It is also very unintuitive and unclear that adding "Advanced clone options" without checking any of its flags or filling out any of its properties magically restores the fetch with tags behaviour. It is unexpected that adding something without configuring it would change the behaviour. Development tools should lead users into the pit of success, not the pit of failure (and despair!). Please reconsider the impact of this change, or alternatively add a big fat warning for users upgrading to this version that their builds will behave differently now. Thanks for the wonderful tool that Jenkins is, and all the great work on the main server, this, and other plugins.

          Patrick Rose added a comment -

          This is also causing issues for us because the "checkout to subdirectory" option has now been removed. Is there a workaround for that or do I need to handle this manually?

          Patrick Rose added a comment - This is also causing issues for us because the "checkout to subdirectory" option has now been removed. Is there a workaround for that or do I need to handle this manually?

          "Checkout to subdirectory" caused other problems and the correct solution in multibranch has always been to just do

          dir('subdir'){
            checkout scm
          }
          

          instead of

          checkout scm
          

          The extensions that were exposed by mistake have been removed to prevent the bugs that people were encountering

          Stephen Connolly added a comment - "Checkout to subdirectory" caused other problems and the correct solution in multibranch has always been to just do dir( 'subdir' ){ checkout scm } instead of checkout scm The extensions that were exposed by mistake have been removed to prevent the bugs that people were encountering

          Patrick Rose added a comment -

          We're using the declarative syntax, which means we don't have the option of checking out to a subdirectory. Is there a separate workaround we can do?

          Patrick Rose added a comment - We're using the declarative syntax, which means we don't have the option of checking out to a subdirectory. Is there a separate workaround we can do?

          turn off automatic checkout and then you can do the dir trick... abayer can probably tell you how to do that

          Stephen Connolly added a comment - turn off automatic checkout and then you can do the dir trick... abayer can probably tell you how to do that

          Andrew Bayer added a comment -

          Add

          options {
            skipDefaultCheckout(true)
          }
          

          to your pipeline block to skip the default checkout.

          Andrew Bayer added a comment - Add options { skipDefaultCheckout( true ) } to your pipeline block to skip the default checkout.

          Code changed in jenkins
          User: Mark Waite
          Path:
          Jenkinsfile
          http://jenkins-ci.org/commit/git-client-plugin/5cff403b221f58106d85edfcaa2d6ae90a1bc9e0
          Log:
          Clone repo with all history and all tags

          Intentional changes from JENKINS-43507 have reduced server load, disc
          use, and data transfer by honor the refspec which matches the branch of
          the job being built in a multi-branch pipeline, and by not fetching tags.

          Unfortunately, this branch contains tests which assume it is operating
          with a complete clone of the repository, including all tags and all
          branches.

          The tests have been fixed on the master branch, but not on this branch.
          Rather than fix the tests on this branch (with the risk that creates),
          this change modifies the clone to include all history and all tags.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: Jenkinsfile http://jenkins-ci.org/commit/git-client-plugin/5cff403b221f58106d85edfcaa2d6ae90a1bc9e0 Log: Clone repo with all history and all tags Intentional changes from JENKINS-43507 have reduced server load, disc use, and data transfer by honor the refspec which matches the branch of the job being built in a multi-branch pipeline, and by not fetching tags. Unfortunately, this branch contains tests which assume it is operating with a complete clone of the repository, including all tags and all branches. The tests have been fixed on the master branch, but not on this branch. Rather than fix the tests on this branch (with the risk that creates), this change modifies the clone to include all history and all tags.

          Greg Smith added a comment -

          This change – that tags are no longer included by default – also broke all of our builds.

          We are using the Github multi-branch Organization plugin.  I keep seeing reference to "Advanced clone options" – with a cropped screenshot.  Where is this UI?  Is it supposed to be on the configuration page for the Github Organization, because I can't find it.

          We have about 500 github projects that all depend on git tags being present during the build.  Do we have to change all of our builds "checkout scm" lines in all builds to add these options?

          Its a big task to change them all, and also breaks the ability to build old versions of code without any modifications.

          If there is any ability to go back to the old behavior via a global setting, that would be greatly appreciated.  I can not find the referenced UI in the screenshot anywhere under system configuration or Github Organization configuration.

           

           

          Greg Smith added a comment - This change – that tags are no longer included by default – also broke all of our builds. We are using the Github multi-branch Organization plugin.  I keep seeing reference to "Advanced clone options" – with a cropped screenshot.  Where is this UI?  Is it supposed to be on the configuration page for the Github Organization, because I can't find it. We have about 500 github projects that all depend on git tags being present during the build.  Do we have to change all of our builds "checkout scm" lines in all builds to add these options? Its a big task to change them all, and also breaks the ability to build old versions of code without any modifications. If there is any ability to go back to the old behavior via a global setting, that would be greatly appreciated.  I can not find the referenced UI in the screenshot anywhere under system configuration or Github Organization configuration.    

          Greg Smith added a comment - - edited

          OK – Sorry, i was able to find that UI now, via "Add" under "Behaviors" on the github organization UI.

          We added that to our Github organization configuration.  Should that automatically fix all builds using a simple "checkout scm" in their pipeline code?  As we have seen no change in behavior or resolution to the problem yet after adding that extra configuration.

          Under what conditions are those additional behaviors used?

          Greg Smith added a comment - - edited OK – Sorry, i was able to find that UI now, via "Add" under "Behaviors" on the github organization UI. We added that to our Github organization configuration.  Should that automatically fix all builds using a simple "checkout scm" in their pipeline code?  As we have seen no change in behavior or resolution to the problem yet after adding that extra configuration. Under what conditions are those additional behaviors used?

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            4 Vote for this issue
            Watchers:
            21 Start watching this issue

              Created:
              Updated:
              Resolved: