Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43535

Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Lib

XMLWordPrintable

      It is required to improve support of Pipelines in plugins using EnvInject lib: EnvInject, Shared Objects, etc..

          [JENKINS-43535] Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Lib

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-42614 [ 179553 ]

          Oleg Nenashev added a comment -

          https://github.com/jenkinsci/envinject-lib/pull/8

          Oleg Nenashev added a comment - https://github.com/jenkinsci/envinject-lib/pull/8
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Oleg Nenashev made changes -
          Link New: This issue is blocking JENKINS-43536 [ JENKINS-43536 ]
          Oleg Nenashev made changes -
          Link New: This issue is blocked by JENKINS-43845 [ JENKINS-43845 ]

          Oleg Nenashev added a comment -

          3 PRs are involved:

          Oleg Nenashev added a comment - 3 PRs are involved: https://github.com/jenkinsci/envinject-lib/pull/8 https://github.com/jenkinsci/envinject-api-plugin/pull/1 https://github.com/jenkinsci/envinject-plugin/pull/118

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java
          http://jenkins-ci.org/commit/envinject-lib/6e4ec051ce509d20a1d9c7b23b58c45a7190aaaf
          Log:
          JENKINS-43535 - Minimize usage of AbstractProject/AbstractBuild

          After the change, there are only minimal usages in EnvVarsResolver, mostly related to the WORKSPACE access

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-lib/6e4ec051ce509d20a1d9c7b23b58c45a7190aaaf Log: JENKINS-43535 - Minimize usage of AbstractProject/AbstractBuild After the change, there are only minimal usages in EnvVarsResolver, mostly related to the WORKSPACE access

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java
          http://jenkins-ci.org/commit/envinject-lib/9058a65d8c635cdd314b257d5ef9ad96f900b320
          Log:
          JENKINS-43535 - Revert changes in utility classes

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-lib/9058a65d8c635cdd314b257d5ef9ad96f900b320 Log: JENKINS-43535 - Revert changes in utility classes

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: