Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43536

Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Plugin

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • envinject-plugin
    • None

      It is required to simplify Pipeline support and to troubleshoot defects in currently supported cases. depends on JENKINS-43535

          [JENKINS-43536] Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Plugin

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - https://github.com/jenkinsci/envinject-lib/pull/8 https://github.com/jenkinsci/envinject-api-plugin/pull/1 https://github.com/jenkinsci/envinject-plugin/pull/118

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java
          src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java
          src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java
          http://jenkins-ci.org/commit/envinject-plugin/6ec719d3bb7ec84c56f03c10c8ad132ebd33d551
          Log:
          JENKINS-43536 - Avoid usage of AbstractProject/AbstractBuild where possible

          It won't help Jenkins Pipeline much I suppose, but at least it streamlines the handling logic.
          The change depends on EnvInject Lib API update.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java http://jenkins-ci.org/commit/envinject-plugin/6ec719d3bb7ec84c56f03c10c8ad132ebd33d551 Log: JENKINS-43536 - Avoid usage of AbstractProject/AbstractBuild where possible It won't help Jenkins Pipeline much I suppose, but at least it streamlines the handling logic. The change depends on EnvInject Lib API update.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java
          http://jenkins-ci.org/commit/envinject-plugin/af113cfd5008e73b349266891b89d6b043296816
          Log:
          JENKINS-43536 - Pick changes for JENKINS-43845

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java http://jenkins-ci.org/commit/envinject-plugin/af113cfd5008e73b349266891b89d6b043296816 Log: JENKINS-43536 - Pick changes for JENKINS-43845

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java
          src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java
          src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java
          http://jenkins-ci.org/commit/envinject-plugin/f741117e2bb38c980ee804ce2b9a86975eab5029
          Log:
          JENKINS-43536 - Restore full binary compatibility, move some logic to EnvInject API

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java http://jenkins-ci.org/commit/envinject-plugin/f741117e2bb38c980ee804ce2b9a86975eab5029 Log: JENKINS-43536 - Restore full binary compatibility, move some logic to EnvInject API

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapper.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
          src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java
          src/test/java/org/jenkinsci/plugins/envinject/sevice/EnvInjectVariableGetterTest.java
          http://jenkins-ci.org/commit/envinject-plugin/b7b13fd9e735e179d4b4f3c6e2c63812e5ca78f6
          Log:
          JENKINS-43536 - Replace deprecated methods within the plugin

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapper.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java src/test/java/org/jenkinsci/plugins/envinject/sevice/EnvInjectVariableGetterTest.java http://jenkins-ci.org/commit/envinject-plugin/b7b13fd9e735e179d4b4f3c6e2c63812e5ca78f6 Log: JENKINS-43536 - Replace deprecated methods within the plugin

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java
          http://jenkins-ci.org/commit/envinject-plugin/22449c8ffa760ceee53e15012cc2c684ae560dcd
          Log:
          JENKINS-43536 - Fix the last compatibility-breaking change

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java http://jenkins-ci.org/commit/envinject-plugin/22449c8ffa760ceee53e15012cc2c684ae560dcd Log: JENKINS-43536 - Fix the last compatibility-breaking change

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-plugin/cff7ee40b5a922bc19bbe42e626dee475c2e94d1
          Log:
          JENKINS-43536 - Do not use EnvInject API version property and remove dependency on the old JUnit plugin

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-plugin/cff7ee40b5a922bc19bbe42e626dee475c2e94d1 Log: JENKINS-43536 - Do not use EnvInject API version property and remove dependency on the old JUnit plugin

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java
          http://jenkins-ci.org/commit/envinject-plugin/b65c0eae05ac9cddac431e8e43ccdc829e20217d
          Log:
          JENKINS-43536 - Fix typo in the method name

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java http://jenkins-ci.org/commit/envinject-plugin/b65c0eae05ac9cddac431e8e43ccdc829e20217d Log: JENKINS-43536 - Fix typo in the method name

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-plugin/dd5f3e2c60d3da8d4196b8c71ba9a9bcd041447b
          Log:
          JENKINS-43536 - Use the released EnvInject API 1.0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-plugin/dd5f3e2c60d3da8d4196b8c71ba9a9bcd041447b Log: JENKINS-43536 - Use the released EnvInject API 1.0

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-plugin/61733340b9168ee98cc2d657147b506403eddc34
          Log:
          JENKINS-43536 - Add explicit dependnecy on the new Hamcrest core to make the PR builder happy

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-plugin/61733340b9168ee98cc2d657147b506403eddc34 Log: JENKINS-43536 - Add explicit dependnecy on the new Hamcrest core to make the PR builder happy

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-plugin/b799e3a64974d538836114ebbb99df0e24538ecd
          Log:
          Merge branch 'feature/JENKINS-43536' of https://github.com/oleg-nenashev/envinject-plugin into feature/JENKINS-43536

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-plugin/b799e3a64974d538836114ebbb99df0e24538ecd Log: Merge branch 'feature/ JENKINS-43536 ' of https://github.com/oleg-nenashev/envinject-plugin into feature/ JENKINS-43536

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java
          src/test/java/org/jenkinsci/plugins/envinject/BuildCauseRetrieverTest.java
          src/test/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapperTest.java
          src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java
          http://jenkins-ci.org/commit/envinject-plugin/b273187f177b6d5f0832f7ffabbeea4992c30d3b
          Log:
          JENKINS-43536 - Resolve compatibility issue between the latest JTH and Mockito

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java src/test/java/org/jenkinsci/plugins/envinject/BuildCauseRetrieverTest.java src/test/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapperTest.java src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java http://jenkins-ci.org/commit/envinject-plugin/b273187f177b6d5f0832f7ffabbeea4992c30d3b Log: JENKINS-43536 - Resolve compatibility issue between the latest JTH and Mockito

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapper.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java
          src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java
          src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java
          src/test/java/org/jenkinsci/plugins/envinject/BuildCauseRetrieverTest.java
          src/test/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapperTest.java
          src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java
          src/test/java/org/jenkinsci/plugins/envinject/sevice/EnvInjectVariableGetterTest.java
          http://jenkins-ci.org/commit/envinject-plugin/b5e19916abcb840b41392c06700afec15bb79b37
          Log:
          Merge pull request #118 from oleg-nenashev/feature/JENKINS-43536

          JENKINS-43536 - Avoid usage of AbstractProject/AbstractBuild where possible

          Compare: https://github.com/jenkinsci/envinject-plugin/compare/95033cfeb588...b5e19916abcb

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapper.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java src/test/java/org/jenkinsci/plugins/envinject/BuildCauseRetrieverTest.java src/test/java/org/jenkinsci/plugins/envinject/EnvInjectBuildWrapperTest.java src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEvaluatedGroovyScriptTest.java src/test/java/org/jenkinsci/plugins/envinject/sevice/EnvInjectVariableGetterTest.java http://jenkins-ci.org/commit/envinject-plugin/b5e19916abcb840b41392c06700afec15bb79b37 Log: Merge pull request #118 from oleg-nenashev/feature/ JENKINS-43536 JENKINS-43536 - Avoid usage of AbstractProject/AbstractBuild where possible Compare: https://github.com/jenkinsci/envinject-plugin/compare/95033cfeb588...b5e19916abcb

          Oleg Nenashev added a comment -

          Released

          Oleg Nenashev added a comment - Released

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: