• Type: Bug
• Resolution: Fixed
• Priority: Major
• Component/s: job-dsl-plugin
• Labels:

  None
• Environment:

  Debian 8
  Jenkins 2.46.1 (as service)
  
  Plugins (all newest stable):
  Job DSL 1.61
  Pipeline: Multibranch 2.14

[JENKINS-43693] multibranchPipelineJob overrides old branch indexing sources

Anders Kielsholm created issue - 2017-04-19 15:17

Anders Kielsholm made changes - 2017-04-19 15:18

Description

Original: When running the multibranchPipelineJob step it seems like it overrides the sources of a Multibranch Pipeline Job instead of just updating it. After running the step, even though nothing has changed the output of the branch indexing will become:   {code:java} Checking branch master       ‘Jenkinsfile’ found Met criteria Takeover for job-dsl-plugin_multibranch » master by source #1 from source that no longer exists Branch reopened: master (b409f3996299dd12244d6cf7f8b6d8df3aa674ca) Scheduled build for branch: master {code}     To test this, I have installed a brand new Jenkins with the Pipeline plugins and Job DSL plugin (all as the stable version) and made a freestyle job, with a Job DSL step that has the following script:   {code:java} multibranchPipelineJob('job-dsl-plugin_multibranch') {   branchSources {     git {       remote('https://github.com/jenkinsci/job-dsl-plugin.git')     }   } } {code}     After running the Job DSL step and afterwards running branch indexing a "master" job is created with the following log message from branch indexing: {code:java} Checking branch master       ‘Jenkinsfile’ found Met criteria Scheduled build for branch: master {code} When running branch indexing again, following log message are shown as expected:     {code:java} Checking branch master       ‘Jenkinsfile’ found Met criteria No changes detected: master (still at b409f3996299dd12244d6cf7f8b6d8df3aa674ca) {code} However, if I run the Job DSL again and run branch indexing, the first log message (with takeover and so on) are shown. This is not what I would have expected, I would have expected something like a "no changes detected" message.

New: When running the multibranchPipelineJob step it seems like it overrides the sources of a Multibranch Pipeline Job instead of just updating it. After running the step, even though nothing has changed the output of the branch indexing will become: {code:java} Checking branch master       ‘Jenkinsfile’ found Met criteria Takeover for job-dsl-plugin_multibranch » master by source #1 from source that no longer exists Branch reopened: master (b409f3996299dd12244d6cf7f8b6d8df3aa674ca) Scheduled build for branch: master {code}   To test this, I have installed a brand new Jenkins with the Pipeline plugins and Job DSL plugin (all as the stable version) and made a freestyle job, with a Job DSL step that has the following script: {code:java} multibranchPipelineJob('job-dsl-plugin_multibranch') {   branchSources {     git {       remote('https://github.com/jenkinsci/job-dsl-plugin.git')     }   } } {code}   After running the Job DSL step and afterwards running branch indexing a "master" job is created with the following log message from branch indexing: {code:java} Checking branch master       ‘Jenkinsfile’ found Met criteria Scheduled build for branch: master {code}   When running branch indexing again, following log message are shown as expected: {code:java} Checking branch master       ‘Jenkinsfile’ found Met criteria No changes detected: master (still at b409f3996299dd12244d6cf7f8b6d8df3aa674ca) {code}   However, if I run the Job DSL again and run branch indexing, the first log message (with takeover and so on) are shown. This is not what I would have expected, I would have expected something like a "no changes detected" message.

SCM/JIRA link daemon made changes - 2017-04-30 11:12

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

Daniel Spilker made changes - 2017-05-09 06:49

Status

Original: Resolved [ 5 ]

New: Closed [ 6 ]

Denys Digtiar made changes - 2018-05-14 04:49

Resolution	Original: Fixed [ 1 ]
Status	Original: Closed [ 6 ]	New: Reopened [ 4 ]

Denys Digtiar made changes - 2018-05-17 04:54

Resolution		New: Fixed [ 1 ]
Status	Original: Reopened [ 4 ]	New: Closed [ 6 ]

Ray Kivisto made changes - 2019-05-16 14:27

Resolution	Original: Fixed [ 1 ]
Status	Original: Closed [ 6 ]	New: Reopened [ 4 ]

Daniel Spilker made changes - 2019-06-17 12:11

Status

Original: Reopened [ 4 ]

New: In Progress [ 3 ]

Daniel Spilker made changes - 2019-06-17 12:13

Link

New: This issue is duplicated by JENKINS-57235 [ JENKINS-57235 ]

Daniel Spilker made changes - 2019-08-26 11:17

Released As		New: job-dsl 1.75
Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Closed [ 6 ]