[JENKINS-43845] Rework EnvInject Lib to EnvInject API Plugin

Type: Improvement
Resolution: Fixed
Priority: Minor
Component/s: envinject-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show
Epic Link:
Pipeline support in EnvInject

It is a long-standing issue, which complicates ~~JENKINS-43535~~ since it is impossible to make any breaking changes in the library without causing fallout in plugins.

I want to finally split out the hardcoded dependency on EnvInject lib by converting it to an API plugin

blocks

JENKINS-43535 Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Lib

Resolved

SCM/JIRA link daemon added a comment - 2017-05-05 17:26

Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java
src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java
src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectAction.java
src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectException.java
src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectLogger.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectDetector.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectSavable.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvVarsResolver.java
http://jenkins-ci.org/commit/envinject-api-plugin/924fea55b7b3b96ae05aea9ca515c7e282ada92b
Log:
~~JENKINS-43845~~ - Rework POM and move contents to a new package

SCM/JIRA link daemon added a comment - 2017-05-05 17:26 Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectAction.java src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectException.java src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectLogger.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectDetector.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectSavable.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-api-plugin/924fea55b7b3b96ae05aea9ca515c7e282ada92b Log: JENKINS-43845 - Rework POM and move contents to a new package

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectAction.java
src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectException.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectSavable.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvVarsResolver.java
http://jenkins-ci.org/commit/envinject-api-plugin/1226455abf9aa52fc2d3467036e95f5ed6a8f8dd
Log:
~~JENKINS-43845~~ - Retain dependency on the EnvInject Lib for Action and Exception

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectAction.java src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectException.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectSavable.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-api-plugin/1226455abf9aa52fc2d3467036e95f5ed6a8f8dd Log: JENKINS-43845 - Retain dependency on the EnvInject Lib for Action and Exception

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectLogger.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectDetector.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectSavable.java
src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvVarsResolver.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectDetector.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectLogger.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectSavable.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java
http://jenkins-ci.org/commit/envinject-api-plugin/ec19a1bc87bbff6eaf7c29e90069fe9a2bdb0c7d
Log:
~~JENKINS-43845~~ - Move classes to the util package

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinjectapi/EnvInjectLogger.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectDetector.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvInjectSavable.java src/main/java/org/jenkinsci/plugins/envinjectapi/service/EnvVarsResolver.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectDetector.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectLogger.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectSavable.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-api-plugin/ec19a1bc87bbff6eaf7c29e90069fe9a2bdb0c7d Log: JENKINS-43845 - Move classes to the util package

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectDetector.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectLogger.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectPluginHelper.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectSavable.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java
http://jenkins-ci.org/commit/envinject-api-plugin/89cbbf03da39f08701771347ad3d8d40db22dc04
Log:
~~JENKINS-43845~~ - Refactor the plugin code (annotations + FindBugs)

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectDetector.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectLogger.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectPluginHelper.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectSavable.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-api-plugin/89cbbf03da39f08701771347ad3d8d40db22dc04 Log: JENKINS-43845 - Refactor the plugin code (annotations + FindBugs)

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectPluginHelper.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/JenkinsHelper.java
http://jenkins-ci.org/commit/envinject-api-plugin/4c063a507139aeeb3d059aecf22ce8cc6fe5c825
Log:
~~JENKINS-43845~~ - Migrate the plugin to Java 7 and 1.625.x

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectPluginHelper.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/JenkinsHelper.java http://jenkins-ci.org/commit/envinject-api-plugin/4c063a507139aeeb3d059aecf22ce8cc6fe5c825 Log: JENKINS-43845 - Migrate the plugin to Java 7 and 1.625.x

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java
http://jenkins-ci.org/commit/envinject-api-plugin/571930558fa6da7eb4eac206d9b9604d73bb80b7
Log:
~~JENKINS-43845~~ - Use Java 7 Files API and make FindBugs happy

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java http://jenkins-ci.org/commit/envinject-api-plugin/571930558fa6da7eb4eac206d9b9604d73bb80b7 Log: JENKINS-43845 - Use Java 7 Files API and make FindBugs happy

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectLogger.java
http://jenkins-ci.org/commit/envinject-api-plugin/bdc9dd77580894bb61dab2fa466365409c9ccbb2
Log:
~~JENKINS-43845~~ - EnvInjectLogger stays in EnvInject

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectLogger.java http://jenkins-ci.org/commit/envinject-api-plugin/bdc9dd77580894bb61dab2fa466365409c9ccbb2 Log: JENKINS-43845 - EnvInjectLogger stays in EnvInject

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
src/main/java/org/jenkinsci/plugins/envinjectapi/util/CauseHelper.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java
http://jenkins-ci.org/commit/envinject-api-plugin/a933c474c058efa5937202d56a5239bbc940a5ce
Log:
~~JENKINS-43845~~ - Move Cause EnvVars logic from EnvInject plugin to EnvInject API

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinjectapi/util/CauseHelper.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java http://jenkins-ci.org/commit/envinject-api-plugin/a933c474c058efa5937202d56a5239bbc940a5ce Log: JENKINS-43845 - Move Cause EnvVars logic from EnvInject plugin to EnvInject API

SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Code changed in jenkins
User: Oleg Nenashev
Path:
CHANGELOG.md
Jenkinsfile
LICENSE.txt
README.md
pom.xml
src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java
src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java
src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/CauseHelper.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectActionRetriever.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectPluginHelper.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java
src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java
src/main/resources/org/jenkinsci/plugins/envinjectapi/index.jelly
http://jenkins-ci.org/commit/envinject-api-plugin/300415ca120162fb8f679a1423219ba4c8273a7e
Log:
Merge pull request #1 from jenkinsci/feature/~~JENKINS-43845~~

~~JENKINS-43845~~ - Decouple EnvInject API from EnvInjectLib

Compare: https://github.com/jenkinsci/envinject-api-plugin/compare/6e4ec051ce50...300415ca1201

SCM/JIRA link daemon added a comment - 2017-05-05 17:27 Code changed in jenkins User: Oleg Nenashev Path: CHANGELOG.md Jenkinsfile LICENSE.txt README.md pom.xml src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectDetector.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java src/main/java/org/jenkinsci/lib/envinject/service/EnvVarsResolver.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/CauseHelper.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectPluginHelper.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvInjectVarsIO.java src/main/java/org/jenkinsci/plugins/envinjectapi/util/EnvVarsResolver.java src/main/resources/org/jenkinsci/plugins/envinjectapi/index.jelly http://jenkins-ci.org/commit/envinject-api-plugin/300415ca120162fb8f679a1423219ba4c8273a7e Log: Merge pull request #1 from jenkinsci/feature/ JENKINS-43845 JENKINS-43845 - Decouple EnvInject API from EnvInjectLib Compare: https://github.com/jenkinsci/envinject-api-plugin/compare/6e4ec051ce50...300415ca1201

SCM/JIRA link daemon added a comment - 2017-05-12 07:50

Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java
src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java
http://jenkins-ci.org/commit/envinject-plugin/af113cfd5008e73b349266891b89d6b043296816
Log:
~~JENKINS-43536~~ - Pick changes for ~~JENKINS-43845~~

SCM/JIRA link daemon added a comment - 2017-05-12 07:50 Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java http://jenkins-ci.org/commit/envinject-plugin/af113cfd5008e73b349266891b89d6b043296816 Log: JENKINS-43536 - Pick changes for JENKINS-43845

Assignee:: Oleg Nenashev

Reporter:: Oleg Nenashev

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 2017-04-26 09:30

Updated:: 2017-06-13 08:09

Resolved:: 2017-06-13 08:09

Details

Description

Attachments

Issue Links

Activity

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:26

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:26

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-05 17:27

Collapse comment: SCM/JIRA link daemon added a comment - 2017-05-12 07:50

Expand comment: SCM/JIRA link daemon added a comment - 2017-05-12 07:50

People

Dates