• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Component/s: core, p4-plugin, pipeline
• Labels:

  None

1. 

   Screen Shot 2017-05-08 at 9.27.16 AM.png

   275 kB

   2017-05-08 13:28

2. 

   Screen Shot 2017-05-08 at 9.27.24 AM.png

   205 kB

   2017-05-08 13:28

3. 

   Screen Shot 2017-05-08 at 9.27.32 AM.png

   257 kB

   2017-05-08 13:28

[JENKINS-44125] Creating a pipeline with P4 Plugin breaks the form box lengths for the whole pipeline page

Alex Taylor created issue - 2017-05-08 13:29

Alex Taylor made changes - 2017-05-08 13:32

Description

Original: Issue: Configuring a pipeline script to be pulled from a P4 SCM causes just the forms to extend for the whole page messing with the UI(see attached screenshots). This also happens with the [[CVS|https://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin)[CVS] Plugin|[https://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin|https://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin)[CVS]] and for the [[P|https://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin)[CVS]4 Plugin|[https://wiki.jenkins-ci.org/display/JENKINS/P4+Plugin]], it crams everything so far onto the side that you can not actually configure anything.   Steps to reproduce: -Running in above environment -Create pipeline job "TestPipeline" -Add a "Poll SCM" schedule(this is not required but it will show the form messing up) -Add a "Pipeline Script from SCM" -Choose Perforce(Observe the forms are squashed on the right side making it hard to configure) -Save job -Go back into the configure screen -Observe the forms becoming stretched   It would be best if the configure area would scale to the right so that the page can be configured correctly.

New: Issue: Configuring a pipeline script to be pulled from a P4 SCM causes just the forms to extend for the whole page messing with the UI(see attached screenshots). This also happens with the [CVS Plugin|https://wiki.jenkins-ci.org/display/JENKINS/CVS+Plugin] and for the [P4 Plugin|[https://wiki.jenkins-ci.org/display/JENKINS/P4+Plugin]], it crams everything so far onto the side that you can not actually configure anything.   Steps to reproduce: -Running in above environment -Create pipeline job "TestPipeline" -Add a "Poll SCM" schedule(this is not required but it will show the form messing up) -Add a "Pipeline Script from SCM" -Choose Perforce(Observe the forms are squashed on the right side making it hard to configure) -Save job -Go back into the configure screen -Observe the forms becoming stretched   It would be best if the configure area would scale to the right so that the page can be configured correctly.

Collapse comment: Oleg Nenashev added a comment - 2017-05-08 18:31

Oleg Nenashev added a comment - 2017-05-08 18:31

I doubt it is related to the core, likely the P4 Plugin layout has enforced indenting which kinda breaks in Jenkins 2.0 styling. If you consider it as a core bug, please justify it

Expand comment: Oleg Nenashev added a comment - 2017-05-08 18:31

Oleg Nenashev added a comment - 2017-05-08 18:31 I doubt it is related to the core, likely the P4 Plugin layout has enforced indenting which kinda breaks in Jenkins 2.0 styling. If you consider it as a core bug, please justify it

Oleg Nenashev made changes - 2017-05-08 18:31

Component/s		New: p4-plugin [ 19224 ]
Component/s		New: pipeline [ 21692 ]

Collapse comment: Alex Taylor added a comment - 2017-05-08 18:36

Alex Taylor added a comment - 2017-05-08 18:36

oleg_nenashev I was thinking that the handling of those fields which dont fit properly into the allotted space should be handled differently which would need to be a core UI fix.

I agree that the Perforce and P4 plugin should fix their indenting but I was hoping to get this fixed across the board.

Expand comment: Alex Taylor added a comment - 2017-05-08 18:36

Alex Taylor added a comment - 2017-05-08 18:36 oleg_nenashev I was thinking that the handling of those fields which dont fit properly into the allotted space should be handled differently which would need to be a core UI fix. I agree that the Perforce and P4 plugin should fix their indenting but I was hoping to get this fixed across the board.

Oleg Nenashev made changes - 2017-05-10 08:35

Summary

Original: Creating a pipeline with SCM of Perforce Software breaks the form box lengths for the whole pipeline page

New: Creating a pipeline with P4 Plugin breaks the form box lengths for the whole pipeline page

Collapse comment: Oleg Nenashev added a comment - 2017-05-10 08:37

Oleg Nenashev added a comment - 2017-05-10 08:37

> I was thinking that the handling of those fields which dont fit properly into the allotted space should be handled differently which would need to be a core UI fix.

I would propose to create a separate improvement request for it. Currently plugins are responsible for the correctness of the layout they contribute and for the impact on the overall UX.

Expand comment: Oleg Nenashev added a comment - 2017-05-10 08:37

Oleg Nenashev added a comment - 2017-05-10 08:37 > I was thinking that the handling of those fields which dont fit properly into the allotted space should be handled differently which would need to be a core UI fix. I would propose to create a separate improvement request for it. Currently plugins are responsible for the correctness of the layout they contribute and for the impact on the overall UX.