Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44236

NFS stats related /proc files should also be gathered

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • support-core-plugin
    • None

      Right now, though there are already a decent amount of things retrieved, but this does not get NFS stats if they're available, which can be valuable for diagnosing potential perf related issues.

      Essentially, the missing files are the ones presented also through the nfsstats and mountstats commands:

      • /proc/net/rpc/nfsd
      • /proc/net/rpc/nfs
      • /proc/self/mountstats

      Now:

      cpuinfo.txt
      meminfo.txt
      mounts.txt
      self/
        cmdline
        environ
        limits.txt
        status.txt
      swaps.txt
      system-uptime.txt
      

      NOTE: main issue to watch out/test, probably, is that the current list seems to be unconditionally retrieved. So as those new files may or may not present, we need to make sure the support-bundle generation still works on system where NFS is absent.
      UPDATE: so actually, the standard support-core plugins's FileContent class already handles this: if a file cannot be found, it will carry on and just put a notice that it cannot be found in that file in the zip. Which makes sense in the end indeed: the goal of that plugin being to gather as much things as it can in a prod env. It this fails fast at the first issue, it'd probably be useless.

          [JENKINS-44236] NFS stats related /proc files should also be gathered

          Baptiste Mathus created issue -
          Baptiste Mathus made changes -
          Description Original: Right now, though there are already a decent amount of things retrieved, but this does not get NFS stats if they're available, which can be valuable for diagnosing potential perf related issues.

          Essentially, the missing files are the ones presented also through the {{nfsstats}} and {{mountstats}} commands:
          * /proc/net/rpc/nfsd
          * /proc/net/rpc/nfs
          * /proc/self/mountstats

          Now:
          {noformat}
          cpuinfo.txt
          meminfo.txt
          mounts.txt
          self/
            cmdline
            environ
            limits.txt
            status.txt
          swaps.txt
          system-uptime.txt
          {noformat}
          New: Right now, though there are already a decent amount of things retrieved, but this does not get NFS stats if they're available, which can be valuable for diagnosing potential perf related issues.

          Essentially, the missing files are the ones presented also through the {{nfsstats}} and {{mountstats}} commands:
          * /proc/net/rpc/nfsd
          * /proc/net/rpc/nfs
          * /proc/self/mountstats

          Now:
          {noformat}
          cpuinfo.txt
          meminfo.txt
          mounts.txt
          self/
            cmdline
            environ
            limits.txt
            status.txt
          swaps.txt
          system-uptime.txt
          {noformat}

          *NOTE: main issue to watch out/test, probably, is that the current list seems to be unconditionnally retrieved. So as those new files may or may not present, we need to make sure the support-bundle generation still works on system where NFS is absent.*
          Baptiste Mathus made changes -
          Description Original: Right now, though there are already a decent amount of things retrieved, but this does not get NFS stats if they're available, which can be valuable for diagnosing potential perf related issues.

          Essentially, the missing files are the ones presented also through the {{nfsstats}} and {{mountstats}} commands:
          * /proc/net/rpc/nfsd
          * /proc/net/rpc/nfs
          * /proc/self/mountstats

          Now:
          {noformat}
          cpuinfo.txt
          meminfo.txt
          mounts.txt
          self/
            cmdline
            environ
            limits.txt
            status.txt
          swaps.txt
          system-uptime.txt
          {noformat}

          *NOTE: main issue to watch out/test, probably, is that the current list seems to be unconditionnally retrieved. So as those new files may or may not present, we need to make sure the support-bundle generation still works on system where NFS is absent.*
          New: Right now, though there are already a decent amount of things retrieved, but this does not get NFS stats if they're available, which can be valuable for diagnosing potential perf related issues.

          Essentially, the missing files are the ones presented also through the {{nfsstats}} and {{mountstats}} commands:
          * /proc/net/rpc/nfsd
          * /proc/net/rpc/nfs
          * /proc/self/mountstats

          Now:
          {noformat}
          cpuinfo.txt
          meminfo.txt
          mounts.txt
          self/
            cmdline
            environ
            limits.txt
            status.txt
          swaps.txt
          system-uptime.txt
          {noformat}

          *NOTE: main issue to watch out/test, probably, is that the current list seems to be unconditionally retrieved. So as those new files may or may not present, we need to make sure the support-bundle generation still works on system where NFS is absent.*

          After looking at the code, I think this improvement deserves/requires some factorization of JVMProcessSystemMetricsContents and SystemConfiguration. Those classes are apparently copy one from the other, with very few changes.

          Baptiste Mathus added a comment - After looking at the code, I think this improvement deserves/requires some factorization of JVMProcessSystemMetricsContents and SystemConfiguration . Those classes are apparently copy one from the other, with very few changes.
          Baptiste Mathus made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Baptiste Mathus made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Baptiste Mathus made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Baptiste Mathus made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Baptiste Mathus made changes -
          Remote Link New: Cette demande est liée à "PR-112 (Lien Web)" [ 16701 ]

          Baptiste Mathus added a comment - PR in review https://github.com/jenkinsci/support-core-plugin/pull/112

            batmat Baptiste Mathus
            batmat Baptiste Mathus
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: