-
Bug
-
Resolution: Fixed
-
Minor
-
None
When generating MSI and OSX packages we are inspecting the environment variable JENKINS_SSH_KEY and if present it's used for authentication of CLI commands that invoke the distfork plugin (see here).
The CLI command is then composed with a "-i /path/to/key" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended.
So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this.
I propose using a new environment variable called JENKINS_SSH_USER in a similar way the JENKINS_SSH_KEY one is used. If it has some content, the -ssh -user xx@yy.zz part will be added to the command.
[JENKINS-44319] Need to adapt MSI and OSX packaging scripts for new CLI
| Description |
Original:
When generating MSI and OSX packages we are inspecting the environment variable `JENKINS_SSH_KEY` and if present it's used for authentication of CLI commands that invoke the distfork plugin (see [here|[https://github.com/jenkinsci/packaging/blob/1df9edbb61445632acc1109528ad09c1b6f2fda8/msi/build-on-jenkins.sh#L26]).] The CLI command is then composed with a `-i /path/to/key` option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended. So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this. I propose using a new environment variable called `JENKINS_SSH_USER` in a similar way the JENKINS_SSH_KEY one is used. If it has some content, the `-ssh -user xx@yy.zz` part will be added to the command. |
New:
When generating MSI and OSX packages we are inspecting the environment variable {{JENKINS_SSH_KEY}} and if present it's used for authentication of CLI commands that invoke the distfork plugin (see [here|[https://github.com/jenkinsci/packaging/blob/1df9edbb61445632acc1109528ad09c1b6f2fda8/msi/build-on-jenkins.sh#L26]).] The CLI command is then composed with a "{{-i /path/to/key}}" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended. So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this. I propose using a new environment variable called {{JENKINS_SSH_USER}} in a similar way the {{JENKINS_SSH_KEY}} one is used. If it has some content, the {{-ssh -user xx@yy.zz}} part will be added to the command. |
| Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
| Description |
Original:
When generating MSI and OSX packages we are inspecting the environment variable {{JENKINS_SSH_KEY}} and if present it's used for authentication of CLI commands that invoke the distfork plugin (see [here|[https://github.com/jenkinsci/packaging/blob/1df9edbb61445632acc1109528ad09c1b6f2fda8/msi/build-on-jenkins.sh#L26]).] The CLI command is then composed with a "{{-i /path/to/key}}" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended. So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this. I propose using a new environment variable called {{JENKINS_SSH_USER}} in a similar way the {{JENKINS_SSH_KEY}} one is used. If it has some content, the {{-ssh -user xx@yy.zz}} part will be added to the command. |
New:
When generating MSI and OSX packages we are inspecting the environment variable {{JENKINS_SSH_KEY}} and if present it's used for authentication of CLI commands that invoke the distfork plugin (see [here|[https://github.com/jenkinsci/packaging/blob/1df9edbb61445632acc1109528ad09c1b6f2fda8/msi/build-on-jenkins.sh#L26]]). The CLI command is then composed with a "{{-i /path/to/key}}" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended. So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this. I propose using a new environment variable called {{JENKINS_SSH_USER}} in a similar way the {{JENKINS_SSH_KEY}} one is used. If it has some content, the {{-ssh -user xx@yy.zz}} part will be added to the command. |
| Description |
Original:
When generating MSI and OSX packages we are inspecting the environment variable {{JENKINS_SSH_KEY}} and if present it's used for authentication of CLI commands that invoke the distfork plugin (see [here|[https://github.com/jenkinsci/packaging/blob/1df9edbb61445632acc1109528ad09c1b6f2fda8/msi/build-on-jenkins.sh#L26]]). The CLI command is then composed with a "{{-i /path/to/key}}" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended. So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this. I propose using a new environment variable called {{JENKINS_SSH_USER}} in a similar way the {{JENKINS_SSH_KEY}} one is used. If it has some content, the {{-ssh -user xx@yy.zz}} part will be added to the command. |
New:
When generating MSI and OSX packages we are inspecting the environment variable {{JENKINS_SSH_KEY}} and if present it's used for authentication of CLI commands that invoke the distfork plugin (see [here|https://github.com/jenkinsci/packaging/blob/1df9edbb61445632acc1109528ad09c1b6f2fda8/msi/build-on-jenkins.sh#L26]). The CLI command is then composed with a "{{-i /path/to/key}}" option. AFAIK now in the CLI this option does only make sense if used together with "-ssh" or "-remoting", being the latter not recommended. So basically if the normal thing will be to use "-ssh", which requires specifying a user, we need to enable a way of doing this. I propose using a new environment variable called {{JENKINS_SSH_USER}} in a similar way the {{JENKINS_SSH_KEY}} one is used. If it has some content, the {{-ssh -user xx@yy.zz}} part will be added to the command. |
| Remote Link | New: This issue links to "jenkinsci/packaging#98 (Web Link)" [ 16800 ] |
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: In Progress [ 3 ] | New: Resolved [ 5 ] |
| Remote Link | New: This issue links to "CloudBees Internal CLTS-1834 (Web Link)" [ 19171 ] |