[JENKINS-44322] email-ext sends wrong build status when called from declarative script

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: token-macro-plugin
Labels:
None
Environment:
Jenkins 2.61
email-ext plugin 2.57.2

Similar Issues:
Powered by SuggestiMate

Show

I have a simple declarative script:

pipeline {
    agent { label "mypc1" }
    stages {
        stage('build') {
            steps {
                sh '''
                    python --version
                '''
            }
        }
    }
    post {

        // We want to send notification emails to daldrich and the culprits.
        // The subject and body use the default content set in 'Jenkins > Configure System'

        success {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        failure {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        unstable {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        changed {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}

Problem 1

The email subject uses : '${DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’. In the received email for a successful build the build status is ‘Building!’:

Experimental_LedaAP_gcc_build » trunk - Build # 43 - Building!

This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:

The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.

So I think there is a bug in the plugin.

Problem 2

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran successfully.

On Failure, the recipients are daldrich and the culprits, which is correct.

When the failure is Fixed, the recipients are only daldrich - the culprits are not included, which is incorrect. (In a traditional Jenkins job, recipients and culprits are notified of Fixed, if they are specified in the job configuration).

I think this is also a bug in the plugin.

is caused by

JENKINS-56402 Declarative Pipeline shows SUCCESS even though job FAILED

Reopened

David Aldrich created issue - 2017-05-17 14:58

David Aldrich made changes - 2017-05-17 15:24

Description

Original: I have a simple declarative script:

{code}
pipeline {
    agent { label "carmepc1" }
    stages {
        stage('build') {
            steps {
                sh 'python --version'
            }
        }
    }
    post {
        success {
            // We want to send notification emails to daldrich and the culprits.
            // The subject and body use the default content set in 'Jenkins > Configure System'
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}
{code}

*Problem 1*

The email subject uses : '$\{DEFAULT_SUBJECT\}', which ends with ‘$BUILD_STATUS!’ . In the received email the build status is ‘Building!’. This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:

{panel}
The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.
{panel}

So I think there is a bug in the plugin.

*Problem 2*

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran. But the job only sent emails to daldrich:

{code}
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (build)
[Pipeline] sh
[ntal_LedaAP_gcc_build_trunk-USLWUOYL7YVX3I7JSGOWM7HFTAUAJAGDYQW3ZWS5KMKKC5DUTV4A] Running shell script
+ python --version
Python 2.7.12
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] emailext
Sending email to: David.Aldrich@EMEA.NEC.COM
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS
{code}
Is this a bug?

New: I have a simple declarative script:
{code:java}
pipeline {
    agent { label "mypc1" }
    stages {
        stage('build') {
            steps {
                sh 'python --version'
            }
        }
    }
    post {
        success {
            // We want to send notification emails to daldrich and the culprits.
            // The subject and body use the default content set in 'Jenkins > Configure System'
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}
{code}
*Problem 1*

The email subject uses : '$\{DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’ . In the received email the build status is ‘Building!’. This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:
{panel}
The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.
{panel}
So I think there is a bug in the plugin.

*Problem 2*

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran. But the job only sent emails to daldrich:
{code:java}
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (build)
[Pipeline] sh
[ntal_LedaAP_gcc_build_trunk-USLWUOYL7YVX3I7JSGOWM7HFTAUAJAGDYQW3ZWS5KMKKC5DUTV4A] Running shell script
+ python --version
Python 2.7.12
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] emailext
Sending email to: David.Aldrich@EMEA.NEC.COM
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS
{code}
Is this a bug?

David Aldrich made changes - 2017-05-18 09:48

Description

Original: I have a simple declarative script:
{code:java}
pipeline {
    agent { label "mypc1" }
    stages {
        stage('build') {
            steps {
                sh 'python --version'
            }
        }
    }
    post {
        success {
            // We want to send notification emails to daldrich and the culprits.
            // The subject and body use the default content set in 'Jenkins > Configure System'
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}
{code}
*Problem 1*

The email subject uses : '$\{DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’ . In the received email the build status is ‘Building!’. This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:
{panel}
The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.
{panel}
So I think there is a bug in the plugin.

*Problem 2*

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran. But the job only sent emails to daldrich:
{code:java}
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (build)
[Pipeline] sh
[ntal_LedaAP_gcc_build_trunk-USLWUOYL7YVX3I7JSGOWM7HFTAUAJAGDYQW3ZWS5KMKKC5DUTV4A] Running shell script
+ python --version
Python 2.7.12
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] emailext
Sending email to: David.Aldrich@EMEA.NEC.COM
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS
{code}
Is this a bug?

New: I have a simple declarative script:
{code:java}
pipeline {
    agent { label "mypc1" }
    stages {
        stage('build') {
            steps {
                sh '''
                    python --version
                '''
            }
        }
    }
    post {

        // We want to send notification emails to daldrich and the culprits.
        // The subject and body use the default content set in 'Jenkins > Configure System'

        success {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        failure {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        unstable {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        changed {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}
{code}
*Problem 1*

The email subject uses : '$\{DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’ . In the received email the build status is ‘Building!’:
{panel}
Experimental_LedaAP_gcc_build » trunk - Build # 43 - Building!
{panel}
This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:
{panel}
The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.
{panel}
So I think there is a bug in the plugin.

*Problem 2*

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran successfully.

On Failure, the recipients are daldrich and the culprits, which is correct.

When the failure is Fixed, the recipients are only daldrich - the culprits are not included, +which is incorrect+. (In a traditional Jenkins job, recipients +and+ culprits are notified of Fixed, if they are specified in the job configuration).

I think this is also a bug in the plugin.

David Aldrich made changes - 2017-05-18 10:07

Description

Original: I have a simple declarative script:
{code:java}
pipeline {
    agent { label "mypc1" }
    stages {
        stage('build') {
            steps {
                sh '''
                    python --version
                '''
            }
        }
    }
    post {

        // We want to send notification emails to daldrich and the culprits.
        // The subject and body use the default content set in 'Jenkins > Configure System'

        success {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        failure {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        unstable {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        changed {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}
{code}
*Problem 1*

The email subject uses : '$\{DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’ . In the received email the build status is ‘Building!’:
{panel}
Experimental_LedaAP_gcc_build » trunk - Build # 43 - Building!
{panel}
This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:
{panel}
The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.
{panel}
So I think there is a bug in the plugin.

*Problem 2*

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran successfully.

On Failure, the recipients are daldrich and the culprits, which is correct.

When the failure is Fixed, the recipients are only daldrich - the culprits are not included, +which is incorrect+. (In a traditional Jenkins job, recipients +and+ culprits are notified of Fixed, if they are specified in the job configuration).

I think this is also a bug in the plugin.

New: I have a simple declarative script:
{code:java}
pipeline {
    agent { label "mypc1" }
    stages {
        stage('build') {
            steps {
                sh '''
                    python --version
                '''
            }
        }
    }
    post {

        // We want to send notification emails to daldrich and the culprits.
        // The subject and body use the default content set in 'Jenkins > Configure System'

        success {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        failure {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        unstable {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
        changed {
            script{ emailext (body: '${DEFAULT_CONTENT}',
                              recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                              subject: '${DEFAULT_SUBJECT}',
                              to: 'daldrich')
            }
        }
    }
}
{code}
*Problem 1*

The email subject uses : '$\{DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’. In the received email for a successful build the build status is ‘Building!’:
{panel}
Experimental_LedaAP_gcc_build » trunk - Build # 43 - Building!
{panel}
This is in ‘post’ so I expect the status to be ‘Success!’.

abayer wrote on IRC:
{panel}
The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.
{panel}
So I think there is a bug in the plugin.

*Problem 2*

I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran successfully.

On Failure, the recipients are daldrich and the culprits, which is correct.

When the failure is Fixed, the recipients are only daldrich - the culprits are not included, +which is incorrect+. (In a traditional Jenkins job, recipients +and+ culprits are notified of Fixed, if they are specified in the job configuration).

I think this is also a bug in the plugin.

David van Laatum added a comment - 2017-05-19 06:59

On Problem 2 this problem was fixed some time ago see ~~JENKINS-40653~~

List<Run<?, ?>> builds = new ArrayList<>();
Run<?, ?> build = run;
builds.add(build);
build = build.getPreviousCompletedBuild();
while (build != null) {
    final Result buildResult = build.getResult();
    if (buildResult != null) {
        if (buildResult.isWorseThan(Result.SUCCESS)) {
            debug.send("Including build %s with status %s", build.getId(), buildResult);
            builds.add(build);
        } else {
            break;
        }
    }
    build = build.getPreviousCompletedBuild();
}
Set<User> users = RecipientProviderUtilities.getChangeSetAuthors(builds, debug);
RecipientProviderUtilities.addUsers(users, context, env, to, cc, bcc, debug);

Can you turn on debugging in global settings and see what it says

Problem 1 is actually done by token-macro plugin

David van Laatum added a comment - 2017-05-19 06:59 On Problem 2 this problem was fixed some time ago see JENKINS-40653 List<Run<?, ?>> builds = new ArrayList<>(); Run<?, ?> build = run; builds.add(build); build = build.getPreviousCompletedBuild(); while (build != null ) { final Result buildResult = build.getResult(); if (buildResult != null ) { if (buildResult.isWorseThan(Result.SUCCESS)) { debug.send( "Including build %s with status %s" , build.getId(), buildResult); builds.add(build); } else { break ; } } build = build.getPreviousCompletedBuild(); } Set<User> users = RecipientProviderUtilities.getChangeSetAuthors(builds, debug); RecipientProviderUtilities.addUsers(users, context, env, to, cc, bcc, debug); Can you turn on debugging in global settings and see what it says Problem 1 is actually done by token-macro plugin

Raphaël UNIQUE added a comment - 2017-07-07 09:16

problem 1: +1

Raphaël UNIQUE added a comment - 2017-07-07 09:16 problem 1: +1

David van Laatum added a comment - 2017-07-07 09:55

still waiting for someone with the problem to provide debug output

David van Laatum added a comment - 2017-07-07 09:55 still waiting for someone with the problem to provide debug output

Raphaël UNIQUE added a comment - 2017-07-07 13:44 - edited

Script:

	post 
	
	{ 
		always {
			emailext attachLog: true, body: '$DEFAULT_CONTENT', compressLog: true, recipientProviders: [[$class: 'RequesterRecipientProvider'], [$class: 'DevelopersRecipientProvider']], subject: '$DEFAULT_SUBJECT'
		}
        ....

Log:

[Pipeline] { (Declarative: Post Actions)
[Pipeline] emailext
15:50:11 messageContentType = text/html; charset=UTF-8
15:50:11 Request made to attach build log
15:50:11 Request made to compress build log
15:50:11 Adding recipients from project recipient list
15:50:11   Collecting change authors...
15:50:11     build: 59
15:50:11       adding author: Raphaël Unique
15:50:11       adding author: Raphaël Unique
15:50:11       adding author: Raphaël Unique
15:50:11 Adding Raphaël Unique with address Raphael.Unique@xxx
15:50:11 Adding recipients from trigger recipient list
15:50:11 Successfully created MimeMessage
15:50:11 Sending email to: Raphael.Unique@xxx

Result:
Mail subject: Multibranch » test_pipeline_xxx » trunk - Build # 59 - Building!

Raphaël UNIQUE added a comment - 2017-07-07 13:44 - edited Script: post { always { emailext attachLog: true , body: '$DEFAULT_CONTENT' , compressLog: true , recipientProviders: [[$class: 'RequesterRecipientProvider' ], [$class: 'DevelopersRecipientProvider' ]], subject: '$DEFAULT_SUBJECT' } .... Log: [Pipeline] { (Declarative: Post Actions) [Pipeline] emailext 15:50:11 messageContentType = text/html; charset=UTF-8 15:50:11 Request made to attach build log 15:50:11 Request made to compress build log 15:50:11 Adding recipients from project recipient list 15:50:11 Collecting change authors... 15:50:11 build: 59 15:50:11 adding author: Raphaël Unique 15:50:11 adding author: Raphaël Unique 15:50:11 adding author: Raphaël Unique 15:50:11 Adding Raphaël Unique with address Raphael.Unique@xxx 15:50:11 Adding recipients from trigger recipient list 15:50:11 Successfully created MimeMessage 15:50:11 Sending email to: Raphael.Unique@xxx Result: Mail subject: Multibranch » test_pipeline_xxx » trunk - Build # 59 - Building!

David van Laatum made changes - 2017-07-08 02:48

Component/s		New: token-macro-plugin [ 15832 ]
Component/s	Original: email-ext-plugin [ 15538 ]
Assignee	Original: David van Laatum [ davidvanlaatum ]	New: Alex Earl [ slide_o_mix ]

SCM/JIRA link daemon added a comment - 2017-07-10 16:14

Code changed in jenkins
User: Alex Earl
Path:
src/main/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacro.java
src/test/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacroTest.java
http://jenkins-ci.org/commit/token-macro-plugin/6561df61269e2829757388a67f1fce10a165cbff
Log:
Fix ~~JENKINS-44322~~

SCM/JIRA link daemon added a comment - 2017-07-10 16:14 Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacro.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacroTest.java http://jenkins-ci.org/commit/token-macro-plugin/6561df61269e2829757388a67f1fce10a165cbff Log: Fix JENKINS-44322

Assignee:: Alex Earl

Reporter:: David Aldrich

Votes:: 2 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 2017-05-17 14:58

Updated:: 2019-03-20 14:14

Resolved:: 2019-03-20 14:13

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: David van Laatum added a comment - 2017-05-19 06:59

Expand comment: David van Laatum added a comment - 2017-05-19 06:59

Collapse comment: Raphaël UNIQUE added a comment - 2017-07-07 09:16

Expand comment: Raphaël UNIQUE added a comment - 2017-07-07 09:16

Collapse comment: David van Laatum added a comment - 2017-07-07 09:55

Expand comment: David van Laatum added a comment - 2017-07-07 09:55

Collapse comment: Raphaël UNIQUE added a comment - 2017-07-07 13:44, Edited by Raphaël UNIQUE - 2017-07-07 13:53

Expand comment: Raphaël UNIQUE added a comment - 2017-07-07 13:44, Edited by Raphaël UNIQUE - 2017-07-07 13:53

Collapse comment: SCM/JIRA link daemon added a comment - 2017-07-10 16:14

Expand comment: SCM/JIRA link daemon added a comment - 2017-07-10 16:14

People

Dates