Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44384

Define withMaven() options at the Jenkins Global Config level

XMLWordPrintable

      "withMaven(){...}" 2.3 has introduced "options" to configure / disable the publishers (artifact archiving & fingerprinting, junit report publishing, findbugs reports publishing, open tasks publishing...).

      Sample: "withMaven(options: [myPublisher(...)]){...}".

      We want to define publisher options globally, in the Jenkins "Tools Global Configuration" section, and, for example, disable globally a publisher.

        1. JENKINS-44384.png
          JENKINS-44384.png
          241 kB

          [JENKINS-44384] Define withMaven() options at the Jenkins Global Config level

          Cyrille Le Clerc added a comment -

          FYI work in progress

          Cyrille Le Clerc added a comment - FYI work in progress

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/MavenPublisher/maven-publisher.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/FindbugsAnalysisPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/GeneratedArtifactsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/TasksScannerPublisher/config.jelly
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java
          http://jenkins-ci.org/commit/pipeline-maven-plugin/953d870a7fec0844be954791b1f206384cbdc34b
          Log:
          JENKINS-44384 Support configuration of withMaven publishers in the Jenkins “Global Tools Configuration” section.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/MavenPublisher/maven-publisher.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/FindbugsAnalysisPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/GeneratedArtifactsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/TasksScannerPublisher/config.jelly jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/953d870a7fec0844be954791b1f206384cbdc34b Log: JENKINS-44384 Support configuration of withMaven publishers in the Jenkins “Global Tools Configuration” section.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/MavenPublisher/maven-publisher.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/MavenReporter/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/FindbugsAnalysisPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/GeneratedArtifactsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/TasksScannerPublisher/config.jelly
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java
          http://jenkins-ci.org/commit/pipeline-maven-plugin/3bee359efb77f78f164422697193439f0f7c9478
          Log:
          JENKINS-44384 Support configuration of withMaven publishers in the Jenkins “Global Tools Configuration” section.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/MavenPublisher/maven-publisher.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/MavenReporter/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/FindbugsAnalysisPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/GeneratedArtifactsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/TasksScannerPublisher/config.jelly jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/3bee359efb77f78f164422697193439f0f7c9478 Log: JENKINS-44384 Support configuration of withMaven publishers in the Jenkins “Global Tools Configuration” section.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/MavenPublisher/maven-publisher.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/MavenReporter/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/FindbugsAnalysisPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/GeneratedArtifactsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly
          jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/TasksScannerPublisher/config.jelly
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java
          http://jenkins-ci.org/commit/pipeline-maven-plugin/9a1380f35b1fd85007a3955c7e7912f5d6de9262
          Log:
          Merge pull request #55 from jenkinsci/JENKINS-44384

          WIP JENKINS-44384 Support configuration of withMaven publishers in the …

          Compare: https://github.com/jenkinsci/pipeline-maven-plugin/compare/8c92e443263b...9a1380f35b1f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/MavenPublisher/maven-publisher.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/MavenReporter/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/FindbugsAnalysisPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/GeneratedArtifactsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/JunitTestsPublisher/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/publishers/TasksScannerPublisher/config.jelly jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/9a1380f35b1fd85007a3955c7e7912f5d6de9262 Log: Merge pull request #55 from jenkinsci/ JENKINS-44384 WIP JENKINS-44384 Support configuration of withMaven publishers in the … Compare: https://github.com/jenkinsci/pipeline-maven-plugin/compare/8c92e443263b...9a1380f35b1f

          Cyrille Le Clerc added a comment -

          Beta version available at https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/pipeline-maven/2.4.0-beta-1/pipeline-maven-2.4.0-beta-1.hpi

          baronvonj and timdowney can you test this beta version and define globally configuration parameters of the publishers? Global configuration is located in the Jenkins "Tools Global Configuration" section. 

          We have a limitation: JENKINS-44535 [Publisher config] Support merging of global configuration and pipeline configuration

          Reference JENKINS-43966

           

          Cyrille Le Clerc added a comment - Beta version available at https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/pipeline-maven/2.4.0-beta-1/pipeline-maven-2.4.0-beta-1.hpi baronvonj and timdowney can you test this beta version and define globally configuration parameters of the publishers? Global configuration is located in the Jenkins "Tools Global Configuration" section.  We have a limitation:  JENKINS-44535 [Publisher config] Support merging of global configuration and pipeline configuration Reference  JENKINS-43966  

          Justin Georgeson added a comment -

          Adding publisher option to disable artifact publishing in Global Tool Configuration is working on my staging server. One caveat is that once added I can't delete the option in Global Tool Configuraion. I can successfully toggle the option as enabled/disabled, but simply deleting the option and clicking Save seems to have no effect (reloading Global Tool Configuration page shows the option is still there with the same value).

          Also confirm that using disabled: false in Jenkinsfile overrides the global configured setting to disable (ie JENKINS-44535, which I'm now watching).

          Justin Georgeson added a comment - Adding publisher option to disable artifact publishing in Global Tool Configuration  is working on my staging server. One caveat is that once added I can't delete the option in  Global Tool Configuraion . I can successfully toggle the option as enabled/disabled, but simply deleting the option and clicking  Save  seems to have no effect (reloading  Global Tool Configuration page shows the option is still there with the same value). Also confirm that using  disabled: false in Jenkinsfile overrides the global configured setting to disable (ie JENKINS-44535 , which I'm now watching).

          Cyrille Le Clerc added a comment - - edited

          > One caveat is that once added I can't delete the option in Global Tool Configuration.

           jg_lgc you mean that you don't have the "delete" button that is visible on my screenshot?

          Nevermind, I can reproduce: the deletion is NOT persisted.

          Cyrille Le Clerc added a comment - - edited > One caveat is that once added I can't delete the option in  Global Tool   Configuration .   jg_lgc you mean that you don't have the "delete" button that is visible on my screenshot? Nevermind, I can reproduce: the deletion is NOT persisted.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cyrille Le Clerc
          Path:
          jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java
          jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java
          http://jenkins-ci.org/commit/pipeline-maven-plugin/6b659d6fa5bd3d0ff2fdb4e99ed495096be90ac3
          Log:
          JENKINS-44384 Fix stapler oddity, empty lists coming from the HTTP request are not set on bean by "req.bindJSON(this, json)"

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/GlobalPipelineMavenConfig.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepGlobalConfigurationTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/6b659d6fa5bd3d0ff2fdb4e99ed495096be90ac3 Log: JENKINS-44384 Fix stapler oddity, empty lists coming from the HTTP request are not set on bean by "req.bindJSON(this, json)"

          Cyrille Le Clerc added a comment -

          jg_lgc can you please test the beta-2? https://github.com/jenkinsci/pipeline-maven-plugin/releases/tag/pipeline-maven-2.4.0-beta-2

          Cyrille Le Clerc added a comment - jg_lgc can you please test the beta-2?  https://github.com/jenkinsci/pipeline-maven-plugin/releases/tag/pipeline-maven-2.4.0-beta-2

          Justin Georgeson added a comment -

          The deletion of the publisher is now persisted with beta-2.

          Justin Georgeson added a comment - The deletion of the publisher is now persisted with beta-2.

          Cyrille Le Clerc added a comment -

          Version 2.4.0 released

          Cyrille Le Clerc added a comment - Version 2.4.0 released

            cleclerc Cyrille Le Clerc
            cleclerc Cyrille Le Clerc
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: