Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44538

Blue Ocean organization displayName not being exposed or used

    • Blue Ocean 1.1

      Blue Ocean organizations have a name and display name. But only name seems to be exposed and used for the front-end.

      This is the result of https://ci.blueocean.io/blue/rest/organizations/ where organization name and display name are both exposed as name.

      [
          {
              "_class": "io.jenkins.blueocean.service.embedded.rest.OrganizationImpl",
              "_links": {
                  "pipelines": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/pipelines/"
                  },
                  "self": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/"
                  },
                  "user": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/user/"
                  },
                  "users": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/users/"
                  }
              },
              "name":"jenkins",
              "name":"Jenkins"
          }
      ]
      

      Caused by this line:
      https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18

      Also the frontend seems to be using the name for everything:
      https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73

      The main page displays "jenkins" instead of "Jenkins"

          [JENKINS-44538] Blue Ocean organization displayName not being exposed or used

          Alvaro Lobato created issue -

          James Dumay added a comment -

          alobato what is the improvement you are describing here? This ticket doesn't have any actionable information.

          James Dumay added a comment - alobato what is the improvement you are describing here? This ticket doesn't have any actionable information.
          James Dumay made changes -
          Epic Link New: JENKINS-35759 [ 171771 ]

          Alvaro Lobato added a comment - - edited

          jamesdumay after looking more deeply into this, the problem is that the displayName is not being used. It exists as an attribute to the organization, defaulting to "Jenkins" and name "jenkins", but it isn't used and also it is wrongly exposed through the API as name:

          This is the result of: https://ci.blueocean.io/blue/rest/organizations/

          [
              {
                  "_class": "io.jenkins.blueocean.service.embedded.rest.OrganizationImpl",
                  "_links": {
                      "pipelines": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/pipelines/"
                      },
                      "self": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/"
                      },
                      "user": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/user/"
                      },
                      "users": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/users/"
                      }
                  },
                  "name":"jenkins",
                  "name":"Jenkins"
              }
          ]
          

          Caused by this line:
          https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18

          Also the frontend seems to be using the name for everything:
          https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73

          I'll re-frase the description.

          Alvaro Lobato added a comment - - edited jamesdumay after looking more deeply into this, the problem is that the displayName is not being used. It exists as an attribute to the organization, defaulting to "Jenkins" and name "jenkins", but it isn't used and also it is wrongly exposed through the API as name: This is the result of: https://ci.blueocean.io/blue/rest/organizations/ [ { "_class" : "io.jenkins.blueocean.service.embedded. rest .OrganizationImpl" , "_links" : { "pipelines" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/pipelines/" }, "self" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/" }, "user" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/user/" }, "users" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/users/" } }, "name" : "jenkins" , "name" : "Jenkins" } ] Caused by this line: https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18 Also the frontend seems to be using the name for everything: https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73 I'll re-frase the description.
          Alvaro Lobato made changes -
          Summary Original: Blue Ocean organization displayName New: Blue Ocean organization displayName not being exposed or used
          Alvaro Lobato made changes -
          Issue Type Original: Improvement [ 4 ] New: Bug [ 1 ]
          Alvaro Lobato made changes -
          Description Original: Blue Ocean organizations only have a name and not a display name.

          A display name for the UI should be available which would allow changing the name displayed on the UI for an organization while maintaining the urls and the unique id for that organization (name)
          New: Blue Ocean organizations have a name and display name. But only name seems to be exposed and used for the front-end.

          Alvaro Lobato made changes -
          Attachment New: Screen Shot 2017-06-01 at 02.21.37.png [ 38190 ]
          Alvaro Lobato made changes -
          Description Original: Blue Ocean organizations have a name and display name. But only name seems to be exposed and used for the front-end.

          New: Blue Ocean organizations have a name and display name. But only name seems to be exposed and used for the front-end.

          This is the result of {{https://ci.blueocean.io/blue/rest/organizations/}} where organization name and display name are both exposed as name.
          {code}
          [
              {
                  "_class": "io.jenkins.blueocean.service.embedded.rest.OrganizationImpl",
                  "_links": {
                      "pipelines": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/pipelines/"
                      },
                      "self": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/"
                      },
                      "user": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/user/"
                      },
                      "users": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/users/"
                      }
                  },
                  "name":"jenkins",
                  "name":"Jenkins"
              }
          ]
          {code}

          Caused by this line:
          https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18

          Also the frontend seems to be using the name for everything:
          https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73

          The main page displays "jenkins" instead of "Jenkins"

           !Screen Shot 2017-06-01 at 02.21.37.png|thumbnail!
          Michael Neale made changes -
          Assignee New: Vivek Pandey [ vivek ]

            vivek Vivek Pandey
            alobato Alvaro Lobato
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: