Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44627

blueocean-display-url tests are failing if run in systems without git user.name

XMLWordPrintable

    • Blue Ocean 1.1

      Description

      The blueocean-display-url tests perform some commits as part of the setup, if the tests are executed in an environment without git user.name and user.email properties configured the tests are going to fail.

      Most developer machines already have a global user configured, but for example if the tests are executed in a docker container set up by a CI server (like Jenkins) is possible for them to fail

      The fix is very easy, just add the author to the commit steps of the tests

      To reproduce

      Run the tests in an environment without git user.name and user.email configured

          [JENKINS-44627] blueocean-display-url tests are failing if run in systems without git user.name

          Raul Arabaolaza created issue -
          Raul Arabaolaza made changes -
          Link New: This issue is related to JENKINS-44508 [ JENKINS-44508 ]
          Raul Arabaolaza made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Raul Arabaolaza made changes -
          Remote Link New: This issue links to "PR-6 (Web Link)" [ 16944 ]

          Vivek Pandey added a comment -

          rarabaolaza Thanks for providing the fix, however right fix is to simply use git tests jar. I am going to close your PR https://github.com/jenkinsci/blueocean-display-url-plugin/pull/6 with https://github.com/jenkinsci/blueocean-display-url-plugin/pull/7.

          Vivek Pandey added a comment - rarabaolaza Thanks for providing the fix, however right fix is to simply use git tests jar. I am going to close your PR https://github.com/jenkinsci/blueocean-display-url-plugin/pull/6 with https://github.com/jenkinsci/blueocean-display-url-plugin/pull/7 .
          Vivek Pandey made changes -
          Assignee Original: Raul Arabaolaza [ rarabaolaza ] New: Vivek Pandey [ vivek ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vivek Pandey
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleDVCSRepoRule.java
          src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleRepoRule.java
          src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java
          src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitSampleRepoRule.java
          src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitUtil.java
          http://jenkins-ci.org/commit/blueocean-display-url-plugin/590c9d00a7cbad12e550af5eb42b39ecabbc8b8e
          Log:
          JENKINS-44627# Use git tests jar (#7)

          Fixes issue where if user.name and user.email not set causes tests
          to fail.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vivek Pandey Path: pom.xml src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleDVCSRepoRule.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/AbstractSampleRepoRule.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/BlueOceanDisplayURLImplTest.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitSampleRepoRule.java src/test/java/org/jenkinsci/plugins/blueoceandisplayurl/GitUtil.java http://jenkins-ci.org/commit/blueocean-display-url-plugin/590c9d00a7cbad12e550af5eb42b39ecabbc8b8e Log: JENKINS-44627 # Use git tests jar (#7) Fixes issue where if user.name and user.email not set causes tests to fail.
          James Dumay made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          James Dumay made changes -
          Sprint New: Blue Ocean 1.1 [ 321 ]
          James Dumay made changes -
          Rank New: Ranked higher

            vivek Vivek Pandey
            rarabaolaza Raul Arabaolaza
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: