Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45055

Make EnvInject SpotBugs-clean

XMLWordPrintable

      There are plenty of FindBugs issues discovered in EnvInject Lib and EnvInject Plugin. Although not all of them lead to the real issues, it would be great to cleanup these defects.

          [JENKINS-45055] Make EnvInject SpotBugs-clean

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "envinject-lib/pull/10 (Web Link)" [ 17167 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-lib/b3f4b15f61af17399404627b5dd78078a3c43a7c
          Log:
          JENKINS-45055 - Enable FindBugs by default

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-lib/b3f4b15f61af17399404627b5dd78078a3c43a7c Log: JENKINS-45055 - Enable FindBugs by default

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java
          http://jenkins-ci.org/commit/envinject-lib/af1bcc6c6dcd38bfff53900a819e033a3ed52bf5
          Log:
          JENKINS-45055 - Cleanup issues reported by FindBugs

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java http://jenkins-ci.org/commit/envinject-lib/af1bcc6c6dcd38bfff53900a819e033a3ed52bf5 Log: JENKINS-45055 - Cleanup issues reported by FindBugs

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java
          http://jenkins-ci.org/commit/envinject-lib/62dc34b7745a924b516a303445d5b8af4d8751cd
          Log:
          JENKINS-45055 - Annotate other non-deprecated API methods

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java http://jenkins-ci.org/commit/envinject-lib/62dc34b7745a924b516a303445d5b8af4d8751cd Log: JENKINS-45055 - Annotate other non-deprecated API methods

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java
          src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java
          src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java
          http://jenkins-ci.org/commit/envinject-lib/438588e27cdad7bdd78f3ee043094fa8c6b199ea
          Log:
          Merge pull request #10 from oleg-nenashev/JENKINS-45055-findbugs-cleanup

          JENKINS-45055 - FindBugs cleanup in EnvInject Lib

          Compare: https://github.com/jenkinsci/envinject-lib/compare/9e9ded81dc15...438588e27cda

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/lib/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectException.java src/main/java/org/jenkinsci/lib/envinject/EnvInjectLogger.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectActionRetriever.java src/main/java/org/jenkinsci/lib/envinject/service/EnvInjectSavable.java http://jenkins-ci.org/commit/envinject-lib/438588e27cdad7bdd78f3ee043094fa8c6b199ea Log: Merge pull request #10 from oleg-nenashev/ JENKINS-45055 -findbugs-cleanup JENKINS-45055 - FindBugs cleanup in EnvInject Lib Compare: https://github.com/jenkinsci/envinject-lib/compare/9e9ded81dc15...438588e27cda
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Oleg Nenashev made changes -
          Labels New: newbie-friendly

          Oleg Nenashev added a comment -

          I have cleaned up EnvInject Lib and EnvInject API plugin, but somebody still needs to cleanup EnvInject Plugin itself. I have addressed some issues there, but there is still some work to do

          Oleg Nenashev added a comment - I have cleaned up EnvInject Lib and EnvInject API plugin, but somebody still needs to cleanup EnvInject Plugin itself. I have addressed some issues there, but there is still some work to do

            stefan_spieker Stefan Spieker
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: