Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45109

Metasteps fail to display the delegate symbol in console log

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Split out of a comment in JENKINS-31582. If your Pipeline script writes

      junit '*.xml'

      you would expect the log to say

      [Pipeline] junit

      but currently it says

      [Pipeline] step

        Attachments

          Issue Links

          depends on

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-31582 Log / document the plugin usage in the flow nodes

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is blocking

          New Feature - A new feature of the product, which has yet to be developed. JENKINS-29922 Promote delegates of metasteps to top-level functions, deprecate $class

          • Major - Major loss of function.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-45101 Display meaningful summaries for metasteps

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link PR 148

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/1cd4d63fb731ea6892e5cb45b5f755a1145b7fc2
            Log:
            Deleting comment now tracked as JENKINS-45109.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/workflow/steps/CoreStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/1cd4d63fb731ea6892e5cb45b5f755a1145b7fc2 Log: Deleting comment now tracked as JENKINS-45109 .
            Hide
            Permalink
            jglick Jesse Glick added a comment -

            WorkflowRun is merely calling FlowNode.getDisplayFunctionName() so I think the fix actually needs to be in the getTypeFunctionName() implementations in StepNode subtypes.

            Show
            jglick Jesse Glick added a comment - WorkflowRun is merely calling FlowNode.getDisplayFunctionName() so I think the fix actually needs to be in the getTypeFunctionName() implementations in StepNode subtypes.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepEndNode.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepStartNode.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/41b356172c5753f49f5dbde22915f00958c2f431
            Log:
            [FIXED JENKINS-45109] Making StepNode.typeFunctionName honor metasteps, for example to improve build log output.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepEndNode.java src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepStartNode.java src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/41b356172c5753f49f5dbde22915f00958c2f431 Log: [FIXED JENKINS-45109] Making StepNode.typeFunctionName honor metasteps, for example to improve build log output.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepStartNode.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/8ecadd6ff2f7dd5133cdc27207c21101c0814bc5
            Log:
            JENKINS-45109 Also adjust StepNode.getTypeDisplayName to reflect the delegate descriptor in case of a metastep.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepStartNode.java src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/8ecadd6ff2f7dd5133cdc27207c21101c0814bc5 Log: JENKINS-45109 Also adjust StepNode.getTypeDisplayName to reflect the delegate descriptor in case of a metastep.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepStartNode.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/d9d2e1d621b3f62992604882af48642b1390aeb2
            Log:
            Merge pull request #149 from jglick/typeDisplayName-JENKINS-45109

            JENKINS-45109 Also adjust StepNode.getTypeDisplayName to handle metasteps

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/a30d429af67c...d9d2e1d621b3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepStartNode.java src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/d9d2e1d621b3f62992604882af48642b1390aeb2 Log: Merge pull request #149 from jglick/typeDisplayName- JENKINS-45109 JENKINS-45109 Also adjust StepNode.getTypeDisplayName to handle metasteps Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/a30d429af67c...d9d2e1d621b3
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/0a0e05093fecc8adcf8ba1eaf541d655ba7a7464
            Log:
            JENKINS-31582 Using ArgumentsAction.getResolvedArguments to better handle JENKINS-45109.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/0a0e05093fecc8adcf8ba1eaf541d655ba7a7464 Log: JENKINS-31582 Using ArgumentsAction.getResolvedArguments to better handle JENKINS-45109 .
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java
            src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/b78991523e2ff0868610b770bd3719452452fb2d
            Log:
            Merge pull request #151 from jglick/ArgumentsAction.getResolvedArguments-JENKINS-31582

            JENKINS-31582 Using ArgumentsAction.getResolvedArguments to better handle JENKINS-45109

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/4f703cf1b2c6...b78991523e2f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java src/main/java/org/jenkinsci/plugins/workflow/cps/nodes/StepAtomNode.java src/test/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImplTest.java src/test/java/org/jenkinsci/plugins/workflow/cps/nodes/StepNodeTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/b78991523e2ff0868610b770bd3719452452fb2d Log: Merge pull request #151 from jglick/ArgumentsAction.getResolvedArguments- JENKINS-31582 JENKINS-31582 Using ArgumentsAction.getResolvedArguments to better handle JENKINS-45109 Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/4f703cf1b2c6...b78991523e2f

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: