Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45322

Orphaned MultiBranchProject not properly disabled

      When a branch project is orphaned, setBranch(Branch.Dead) is called, which causes it to appear in strikethrough text in its view (ItemColumn/column.jelly); be deletable (BranchJobProperty.decorateACL); and suppress new builds (BranchJobProperty.isBuildable).

      None of this seems to work in the case that the whole repository folder is orphaned. Based on my readings of the above implementations, it would suffice for ProjectNameProperty to include a new orphaned field (or perhaps this deserves to be a new AbstractFolderProperty<MultiBranchProject<?, ?>>); OrganizationFolder to override orphanedItems to set this field, then set Branch.Dead on all existing branch projects; all other code which might add branch projects (reindexing or event support) to also set Branch.Dead when this flag is set; and make MultiBranchProject.getACL not suppress Item.DELETE when orphaned.

          [JENKINS-45322] Orphaned MultiBranchProject not properly disabled

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue blocks INFRA-1262 [ INFRA-1262 ]

          jglick thanks for filing this, I had come to the same conclusion earlier today but just didn't have time to create the ticket

          Stephen Connolly added a comment - jglick thanks for filing this, I had come to the same conclusion earlier today but just didn't have time to create the ticket
          Stephen Connolly made changes -
          Component/s New: cloudbees-folder-plugin [ 18137 ]
          Stephen Connolly made changes -
          Remote Link New: This issue links to "branch-api-plugin#106 (Web Link)" [ 17251 ]
          Stephen Connolly made changes -
          Remote Link New: This issue links to "cloudbees-folder-plugin#101 (Web Link)" [ 17252 ]
          Stephen Connolly made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Stephen Connolly made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/images/folder-disabled.svg
          src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
          src/main/webapp/images/16x16/folder-disabled.png
          src/main/webapp/images/24x24/folder-disabled.png
          src/main/webapp/images/32x32/folder-disabled.png
          src/main/webapp/images/48x48/folder-disabled.png
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/9e0b0ed41879879ed1f81913ef328173db316fb6
          Log:
          JENKINS-45322 Add icon for a disabled folder

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/images/folder-disabled.svg src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/webapp/images/16x16/folder-disabled.png src/main/webapp/images/24x24/folder-disabled.png src/main/webapp/images/32x32/folder-disabled.png src/main/webapp/images/48x48/folder-disabled.png http://jenkins-ci.org/commit/cloudbees-folder-plugin/9e0b0ed41879879ed1f81913ef328173db316fb6 Log: JENKINS-45322 Add icon for a disabled folder

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          http://jenkins-ci.org/commit/cloudbees-folder-plugin/7364a39cf696ed4111e52c74063aba8d85cbdcef
          Log:
          JENKINS-45322 New API so towards 6.1.0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml http://jenkins-ci.org/commit/cloudbees-folder-plugin/7364a39cf696ed4111e52c74063aba8d85cbdcef Log: JENKINS-45322 New API so towards 6.1.0

            stephenconnolly Stephen Connolly
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: