[JENKINS-45360] creating a pipeline with a duplicate name does not fail gracefully with custom Org - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: blueocean-plugin
Labels:
- blueocean
- cloudbees-internal-steel
Environment:
Jenkins 2.60.1
Blue Ocean 1.1.2 or Blue Ocean 1.1.4

Similar Issues:

Show
Epic Link:
REST API
Sprint:
Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4

Description

If you have a custom organisation folder and try to create a pipeline with a duplicate name then the UI does not fail gracefully (the backend returns a HTTP 500 error as an IllegalArgumentException or Failure is thrown.

I tried to look through the code to see where the duplicate check was done with stock Blue Ocean but could not see any check - and the Jenkins instance will throws the same result.

Caused by: java.lang.IllegalArgumentException: team1/maven-test-project already exists
        at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:640)
        at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:317)
        at com.cloudbees.opscenter.bluesteel.folder.BlueSteelTeamFolder.createProject(BlueSteelTeamFolder.java:135)
        at io.jenkins.blueocean.scm.api.AbstractPipelineCreateRequest.createProject(AbstractPipelineCreateRequest.java:63)
        at io.jenkins.blueocean.scm.api.AbstractMultiBranchCreateRequest.createMultiBranchProject(AbstractMultiBranchCreateRequest.java:80)
        at io.jenkins.blueocean.scm.api.AbstractMultiBranchCreateRequest.create(AbstractMultiBranchCreateRequest.java:54)
        at io.jenkins.blueocean.rest.model.BluePipelineContainer.create(BluePipelineContainer.java:48)
        at io.jenkins.blueocean.rest.model.BluePipelineContainer.create(BluePipelineContainer.java:44)
        at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
        at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)

Attachments

Issue Links

relates to

JENKINS-45482 modifying existing github org incorrect behaviour if custom blue ocean org in use

Closed

JENKINS-45442 When a custom organisation is in use pipeline creation checks permissions on jenkins rather than the organistion root

Closed

links to

CloudBees Internal CJP-7244

CloudBees Internal CJP-7266

Activity

Ascending order - Click to sort in descending order

James Nord created issue - 2017-07-07 12:27

James Nord made changes - 2017-07-07 12:29

Field	Original Value	New Value
Environment		Jenkins 2.60.1 Blue Ocean 1.1.2 or Blue Ocean 1.1.4

James Dumay made changes - 2017-07-11 11:39

Sprint

Blue Ocean 1.2-beta3 [ 346 ]

James Nord made changes - 2017-07-12 16:30

Status

Open [ 1 ]

In Progress [ 3 ]

James Nord made changes - 2017-07-12 16:30

Assignee

James Nord [ teilo ]

James Nord made changes - 2017-07-12 16:31

Link

This issue relates to ~~JENKINS-45482~~ [ ~~JENKINS-45482~~ ]

James Nord made changes - 2017-07-12 16:32

Link

This issue relates to ~~JENKINS-45442~~ [ ~~JENKINS-45442~~ ]

James Dumay made changes - 2017-07-13 03:51

Epic Link

JENKINS-35759 [ 171771 ]

James Nord made changes - 2017-07-19 12:07

Description

If you have a cusomter organisation folder and try to create a pipeline with a duplicate name then the UI does not fail gracefully (the backend returns a HTTP 500 error as an {{IllegalArgumentException}} or {{Failure}} is thrown.

I tried to look through the code to see where the duplicate check was done with stock Blue Ocean but could not see any check - and the Jenkins instance will throws the same result.

{code}
Caused by: java.lang.IllegalArgumentException: team1/maven-test-project already exists
        at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:640)
        at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:317)
        at com.cloudbees.opscenter.bluesteel.folder.BlueSteelTeamFolder.createProject(BlueSteelTeamFolder.java:135)
        at io.jenkins.blueocean.scm.api.AbstractPipelineCreateRequest.createProject(AbstractPipelineCreateRequest.java:63)
        at io.jenkins.blueocean.scm.api.AbstractMultiBranchCreateRequest.createMultiBranchProject(AbstractMultiBranchCreateRequest.java:80)
        at io.jenkins.blueocean.scm.api.AbstractMultiBranchCreateRequest.create(AbstractMultiBranchCreateRequest.java:54)
        at io.jenkins.blueocean.rest.model.BluePipelineContainer.create(BluePipelineContainer.java:48)
        at io.jenkins.blueocean.rest.model.BluePipelineContainer.create(BluePipelineContainer.java:44)
        at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
        at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)
{code}

If you have a custom organisation folder and try to create a pipeline with a duplicate name then the UI does not fail gracefully (the backend returns a HTTP 500 error as an {{IllegalArgumentException}} or {{Failure}} is thrown.

I tried to look through the code to see where the duplicate check was done with stock Blue Ocean but could not see any check - and the Jenkins instance will throws the same result.
{code:java}
Caused by: java.lang.IllegalArgumentException: team1/maven-test-project already exists
        at hudson.model.Items.verifyItemDoesNotAlreadyExist(Items.java:640)
        at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:317)
        at com.cloudbees.opscenter.bluesteel.folder.BlueSteelTeamFolder.createProject(BlueSteelTeamFolder.java:135)
        at io.jenkins.blueocean.scm.api.AbstractPipelineCreateRequest.createProject(AbstractPipelineCreateRequest.java:63)
        at io.jenkins.blueocean.scm.api.AbstractMultiBranchCreateRequest.createMultiBranchProject(AbstractMultiBranchCreateRequest.java:80)
        at io.jenkins.blueocean.scm.api.AbstractMultiBranchCreateRequest.create(AbstractMultiBranchCreateRequest.java:54)
        at io.jenkins.blueocean.rest.model.BluePipelineContainer.create(BluePipelineContainer.java:48)
        at io.jenkins.blueocean.rest.model.BluePipelineContainer.create(BluePipelineContainer.java:44)
        at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627)
        at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343)
{code}

James Dumay made changes - 2017-07-24 00:15

Sprint

Blue Ocean 1.2-beta3 [ 346 ]

Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 346, 361 ]

Michael Neale made changes - 2017-07-25 01:02

Status

In Progress [ 3 ]

In Review [ 10005 ]

Michael Neale made changes - 2017-07-25 01:02

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

CloudBees Inc. made changes - 2017-12-05 08:32

Remote Link

This issue links to "CloudBees Internal CJP-7266 (Web Link)" [ 19076 ]

CloudBees Inc. made changes - 2017-12-05 09:51

Remote Link

This issue links to "CloudBees Internal CJP-7244 (Web Link)" [ 19106 ]

Jenn Briden made changes - 2018-07-06 21:08

Status

Resolved [ 5 ]

Closed [ 6 ]

James Nord made changes - 2020-12-10 13:45

Assignee

James Nord [ teilo ]

People

Assignee:: Unassigned

Reporter:: James Nord

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2017-07-07 12:27

Updated:: 2020-12-10 13:45

Resolved:: 2017-07-25 01:02