Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45401

Chrome Driver Plugin should not install tools synchronously in the Computer Listener

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • chromedriver-plugin
    • None

      Currently Chrome Driver Plugin installs tools in the synchronous calls within the preOnline() hook. This hook happens within Computer connection scope, and it may cause timeouts in the connection logic.

      The installation should be offloaded to an async task.

       

       

      JNLP agent connected from IP
      <===[JENKINS REMOTING CAPACITY]===>Slave.jar version: 2.60.1
      This is a Windows agent
      Installing chromedriver to PATH
      ERROR: Failed to install chromedriver
      java.io.IOException: No installation data is downloaded from chromedriver yet
      at org.jenkinsci.plugins.chromedriver.DownloadableImpl.select(DownloadableImpl.java:74)
      at org.jenkinsci.plugins.chromedriver.DownloadableImpl.resolve(DownloadableImpl.java:35)
      at org.jenkinsci.plugins.chromedriver.ComputerListenerImpl.process(ComputerListenerImpl.java:45)
      at org.jenkinsci.plugins.chromedriver.ComputerListenerImpl.preOnline(ComputerListenerImpl.java:36)
      at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:540)
      at jenkins.slaves.JnlpSlaveAgentProtocol$Handler.jnlpConnect(JnlpSlaveAgentProtocol.java:127)
      at jenkins.slaves.DefaultJnlpSlaveReceiver.handle(DefaultJnlpSlaveReceiver.java:69)
      at jenkins.slaves.JnlpSlaveAgentProtocol2$Handler2.run(JnlpSlaveAgentProtocol2.java:

       

          [JENKINS-45401] Chrome Driver Plugin should not install tools synchronously in the Computer Listener

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Priority Original: Minor [ 4 ] New: Critical [ 2 ]

          Jesse Glick added a comment -

          What is the indication that there is a timeout here? According to the stack trace everything that led up to this error message should have been pretty much instantaneous. That failed, due to tool metadata not having been downloaded, and then the agent launch proceeds without it.

          Jesse Glick added a comment - What is the indication that there is a timeout here? According to the stack trace everything that led up to this error message should have been pretty much instantaneous. That failed, due to tool metadata not having been downloaded, and then the agent launch proceeds without it.

          Ryan Campbell added a comment -

          It seems like fixing these sorts of things requires rewriting the plugin as a tool installer, which is what it really wants to be.

          Ryan Campbell added a comment - It seems like fixing these sorts of things requires rewriting the plugin as a tool installer, which is what it really wants to be.
          James Dumay made changes -
          Remote Link New: This issue links to "CloudBees Internal OSS-2385 (Web Link)" [ 18330 ]

            Unassigned Unassigned
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: