Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45476

Multiple Blue Ocean links are displayed

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2

      Description

      There are situations where multiple Blue Ocean links can be displayed.

      There is no clear path to reproduce but the cause seems to be the use of getActions which is deprecated and does not return the transient actions + the use of replace action and returning the replacement action at the same time:

      https://github.com/jenkinsci/blueocean-plugin/blob/da4a4d5eb3d88be1c844cf4665d3c6b8859cb48b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/TryBlueOceanMenu.java#L52-L56

      https://github.com/jenkinsci/blueocean-plugin/blob/da4a4d5eb3d88be1c844cf4665d3c6b8859cb48b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/TryBlueOceanMenu.java#L63

        Attachments

          Issue Links

            Activity

            alobato Alvaro Lobato created issue -
            alobato Alvaro Lobato made changes -
            Field Original Value New Value
            Attachment Screen Shot 2017-07-12 at 14.52.49.png [ 38838 ]
            alobato Alvaro Lobato made changes -
            Description If you have the root a Blue Ocean organization configured on a folder, the 'Go to Classic Item Creation' will create the item in Jenkins root instead of the Organization root. There are situations where multiple Blue Ocean links can be displayed.

             
            There is no clear path to reproduce but the cause seems to be the use of {{getActions}} which is deprecated and does not return the transient actions + the use of replace action and returning the replacement action at the same time:

            https://github.com/jenkinsci/blueocean-plugin/blob/da4a4d5eb3d88be1c844cf4665d3c6b8859cb48b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/TryBlueOceanMenu.java#L52-L56

            https://github.com/jenkinsci/blueocean-plugin/blob/da4a4d5eb3d88be1c844cf4665d3c6b8859cb48b/blueocean-rest-impl/src/main/java/io/jenkins/blueocean/service/embedded/TryBlueOceanMenu.java#L63
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3 [ 346 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Epic Link JENKINS-35759 [ 171771 ]
            Hide
            jamesdumay James Dumay added a comment -

            Alvaro Lobato so R. Tyler Croy reported a similar one as JENKINS-45269. Ill close JENKINS-45269 as a duplicate of this ticket.

            Show
            jamesdumay James Dumay added a comment - Alvaro Lobato so R. Tyler Croy reported a similar one as JENKINS-45269 . Ill close JENKINS-45269 as a duplicate of this ticket.
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-45269 [ JENKINS-45269 ]
            Hide
            jamesdumay James Dumay added a comment -

            Alvaro Lobato do you need help with this one or should it be assigned to someone else?

            Show
            jamesdumay James Dumay added a comment - Alvaro Lobato do you need help with this one or should it be assigned to someone else?
            Hide
            alobato Alvaro Lobato added a comment -

            James Dumay yes, if someone else can do it, it would be great. I couldn't find the time to work on this. Thanks

            Show
            alobato Alvaro Lobato added a comment - James Dumay yes, if someone else can do it, it would be great. I couldn't find the time to work on this. Thanks
            alobato Alvaro Lobato made changes -
            Assignee Alvaro Lobato [ alobato ]
            jamesdumay James Dumay made changes -
            Link This issue is duplicated by JENKINS-45615 [ JENKINS-45615 ]
            jamesdumay James Dumay made changes -
            Assignee Ivan Meredith [ imeredith ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3 [ 346 ] Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 346, 361 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4 [ 346, 361 ] Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2-beta5 [ 346, 361, 376 ]
            jamesdumay James Dumay made changes -
            Assignee Ivan Meredith [ imeredith ] Vivek Pandey [ vivek ]
            Hide
            jamesdumay James Dumay added a comment -

            Vivek Pandey I suspect JENKINS-45947 is very similar to this one

            Show
            jamesdumay James Dumay added a comment - Vivek Pandey I suspect JENKINS-45947 is very similar to this one
            jamesdumay James Dumay made changes -
            Link This issue relates to JENKINS-45947 [ JENKINS-45947 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2 [ 346, 361, 376 ] Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3 - beta 1 [ 346, 361, 376, 386 ]
            michaelneale Michael Neale made changes -
            Assignee Vivek Pandey [ vivek ] Ivan Meredith [ imeredith ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3 [ 346, 361, 376, 386 ] Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1 [ 346, 361, 376, 386, 401 ]
            Hide
            kkurasz Kristopher Kurasz added a comment - - edited

            +1, I'm also seeing this on Pipeline jobs with the following:

            OS: Windows (core 2012)
            Jenkins: 2.73.1
            Blue Ocean: 1.2.4
            

             It seems specific to the job instance.  For me, build 33 shows "open blue ocean/mercurial build data/artifactory build info" duplicated once, separated by Replay and Pipeline steps, for a total of 2 blue oceans.  Build 34 shows "Open blue ocean (*3) / Mercurial Build Data / artifactory build info / Artifactory Release Promotion" duplicated once, separated by Replay and Pipeline steps, for a total of 6 blue oceans.

            Show
            kkurasz Kristopher Kurasz added a comment - - edited +1, I'm also seeing this on Pipeline jobs with the following: OS: Windows (core 2012) Jenkins: 2.73.1 Blue Ocean: 1.2.4  It seems specific to the job instance.  For me, build 33 shows "open blue ocean/mercurial build data/artifactory build info" duplicated once, separated by Replay and Pipeline steps, for a total of 2 blue oceans.  Build 34 shows "Open blue ocean (*3) / Mercurial Build Data / artifactory build info / Artifactory Release Promotion" duplicated once, separated by Replay and Pipeline steps, for a total of 6 blue oceans.
            Hide
            jamesdumay James Dumay added a comment -

            Kristopher Kurasz we are looking into this ticket soon

            Show
            jamesdumay James Dumay added a comment - Kristopher Kurasz we are looking into this ticket soon
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1 [ 346, 361, 376, 386, 401 ] Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 2 [ 346, 361, 376, 386, 401, 426 ]
            imeredith Ivan Meredith made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            imeredith Ivan Meredith made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 2 [ 346, 361, 376, 386, 401, 426 ] Blue Ocean 1.2-beta3, Blue Ocean 1.2-beta4, Blue Ocean 1.2, Blue Ocean 1.3, Blue Ocean 1.4 - beta 1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2 [ 346, 361, 376, 386, 401, 416, 426 ]
            Hide
            kshultz Karl Shultz added a comment -

            Testing Notes:

            • Once implemented, this seems like something which should be covered by unit tests.
            • A Jenkins ATH test could probably be created (or even an existing one modified) to check for the presence of redundant links on the left hand nav.
            Show
            kshultz Karl Shultz added a comment - Testing Notes: Once implemented, this seems like something which should be covered by unit tests. A Jenkins ATH test could probably be created (or even an existing one modified) to check for the presence of redundant links on the left hand nav.
            kshultz Karl Shultz made changes -
            Labels cloudbees-internal-steel cloudbees-internal-steel testing-notes-reviewed
            Hide
            imeredith Ivan Meredith added a comment -

            Karl Shultz PR is https://github.com/jenkinsci/blueocean-plugin/pull/1560. I donlt really know how to replicate this bug although im fairly sure I have fixed it.

            Show
            imeredith Ivan Meredith added a comment - Karl Shultz PR is https://github.com/jenkinsci/blueocean-plugin/pull/1560 . I donlt really know how to replicate this bug although im fairly sure I have fixed it.
            imeredith Ivan Meredith made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            imeredith Ivan Meredith made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            teilo James Nord made changes -
            Link This issue relates to JENKINS-51584 [ JENKINS-51584 ]
            jbriden Jenn Briden made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              Assignee:
              imeredith Ivan Meredith
              Reporter:
              alobato Alvaro Lobato
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: