• Type: Improvement
• Resolution: Unresolved
• Priority: Major
• Component/s: job-dsl-plugin
• Labels:

  None

[JENKINS-45517] Support JobDSL without security check if called from a global pipeline lib

Georg Henzler created issue - 2017-07-13 15:38

Georg Henzler made changes - 2017-07-13 15:39

Description

Original: When using JobDSL in pipeline scripts [1] that are configured globally (and hence are trusted) [2], the script security should be automatically disabled [3]. At the moment the only workaround is to globally disable the pipeline [4] (but then it can also be used in regular Jenkinsfiles!) or to manually approve all incarnations (not feasible for us, we have way too many incarnations that may come in). It should be possible to check in the implementation of the jobDsl command, if the caller is in trusted context already. If yes, all security checks should be skipped. [1] https://github.com/jenkinsci/job-dsl-plugin/wiki/User-Power-Moves#use-job-dsl-in-pipeline-scripts [2] https://jenkins.io/doc/book/pipeline/shared-libraries/#global-shared-libraries https://github.com/jenkinsci/workflow-cps-global-lib-plugin [3] https://github.com/jenkinsci/job-dsl-plugin/wiki/Migration#migrating-to-160 https://github.com/jenkinsci/job-dsl-plugin/wiki/Script-Security [4] https://github.com/jenkinsci/job-dsl-plugin/wiki/Script-Security#disabling-script-security

New: When using JobDSL in pipeline scripts [1] that are configured globally (and hence are trusted) [2], the script security should be automatically disabled [3]. At the moment the only workaround is to globally disable the script security for the JobDSL plugin [4] (but then it can also be used in regular Jenkinsfiles!) or to manually approve all incarnations (not feasible for us, we have way too many incarnations that may come in). It should be possible to check in the implementation of the jobDsl command, if the caller is in trusted context already. If yes, all security checks should be skipped. [1] https://github.com/jenkinsci/job-dsl-plugin/wiki/User-Power-Moves#use-job-dsl-in-pipeline-scripts [2] https://jenkins.io/doc/book/pipeline/shared-libraries/#global-shared-libraries https://github.com/jenkinsci/workflow-cps-global-lib-plugin [3] https://github.com/jenkinsci/job-dsl-plugin/wiki/Migration#migrating-to-160 https://github.com/jenkinsci/job-dsl-plugin/wiki/Script-Security [4] https://github.com/jenkinsci/job-dsl-plugin/wiki/Script-Security#disabling-script-security

Jamie Tanna made changes - 2021-12-21 11:34

Assignee

Original: Daniel Spilker [ daspilker ]

New: Jamie Tanna [ jamietanna ]