Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45519

Undefined parameters warnings are not suppressed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: In Review (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      The system property 'hudson.model.ParametersAction.keepUndefinedParameters' was updated to take a 'false' value, with the intent of supressing warnings about undefined parameters that are being ignored. This behavior is documented in https://wiki.jenkins.io/display/JENKINS/Features+controlled+by+system+properties

      However, the check implement actually does the reverse, and only shows the warning messages if the system property is set to false (https://github.com/arothian/jenkins/blob/master/core/src/main/java/hudson/model/ParametersAction.java#L329)

       

       

       

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          arothian Kevin Formsma added a comment -

          Proposed fix: https://github.com/jenkinsci/jenkins/pull/2939

          Show
          arothian Kevin Formsma added a comment - Proposed fix:  https://github.com/jenkinsci/jenkins/pull/2939
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kevin Formsma
          Path:
          core/src/main/java/hudson/model/ParametersAction.java
          http://jenkins-ci.org/commit/jenkins/354f3802430bf114869796279305177a0091aa70
          Log:
          JENKINS-45519 Fix keepUndefinedParameters option for suppressing warnings (#2939)

          • Update ParametersAction.java

          Pull request 2687 added a 'false' setting for this flag to prevent warning messages from being logged, but the logic doesn't match the message or the documentation. This updates the check, so that the warning message is correctly suppressed if `hudson.model.ParametersAction.keepUndefinedParameters` is set to false.

          • Updated check to use optBoolean
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kevin Formsma Path: core/src/main/java/hudson/model/ParametersAction.java http://jenkins-ci.org/commit/jenkins/354f3802430bf114869796279305177a0091aa70 Log: JENKINS-45519 Fix keepUndefinedParameters option for suppressing warnings (#2939) Update ParametersAction.java Pull request 2687 added a 'false' setting for this flag to prevent warning messages from being logged, but the logic doesn't match the message or the documentation. This updates the check, so that the warning message is correctly suppressed if `hudson.model.ParametersAction.keepUndefinedParameters` is set to false. Updated check to use optBoolean

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            arothian Kevin Formsma
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: