Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45895

get "DockerComputerJNLPLauncher has no property workDirSettings" when creating new job in jenkins 2.72

    XMLWordPrintable

Details

    Attachments

      Issue Links

        is duplicated by

        Bug - A problem which impairs or prevents the functions of the product. JENKINS-45956 Manage Config throws exception on Docker Plugin

        • Blocker - Blocks development and/or testing work, production could not run.
        • Resolved
        links to

        Web Link https://github.com/jenkinsci/jenkins/pull/2962

        Activity

          Ascending order - Click to sort in descending order
          maksonlee Makson Lee added a comment -

          sorry, i guess i created the issue against wrong project.

          maksonlee Makson Lee added a comment - sorry, i guess i created the issue against wrong project.
          maksonlee Makson Lee added a comment -

          okay, i have changed the project to right one.

          maksonlee Makson Lee added a comment - okay, i have changed the project to right one.
          marcwrobel Marc Wrobel added a comment -

          A similar error is raised when accessing the main configuration page (/configure). The error occurs while rendering the following part of the page : Cloud > Docker > Images > Docker Template. See the stacktrace in configure.log.

          This error appeared after upgrading to jenkins 2.72. It completely breaks the main configuration page (it seems the page stops rendering after the error).

           

          marcwrobel Marc Wrobel added a comment - A similar error is raised when accessing the main configuration page (/configure). The error occurs while rendering the following part of the page : Cloud > Docker > Images > Docker Template. See the stacktrace in configure.log . This error appeared after upgrading to jenkins 2.72. It completely breaks the main configuration page (it seems the page stops rendering after the error).  
          oleg_nenashev Oleg Nenashev added a comment -

          Yes, it is a regression after JENKINS-44112. It seems the Docker Plugin uses the form layout provided by the core. And the layout has changed. I will investigate it.

          oleg_nenashev Oleg Nenashev added a comment - Yes, it is a regression after JENKINS-44112 . It seems the Docker Plugin uses the form layout provided by the core. And the layout has changed. I will investigate it.
          oleg_nenashev Oleg Nenashev added a comment -

          Yes, it happens in the Docker Plugin due to the invalid include: https://github.com/jenkinsci/docker-plugin/blob/master/docker-plugin/src/main/resources/com/nirima/jenkins/plugins/docker/launcher/DockerComputerJNLPLauncher/config.jelly#L8

          I checked other such risks:

          • Yet Another Docker Plugin: safe, custom implementation
          • Spotinst Plugin - safe, no config.jelly
          • JCloudsJnlpLauncher - safe, no config.jelly
          • VMwareLauncher - safe, custom implementation without include
          • MesosComputerLauncher - safe, no config.jelly

          I also see a closed-source plugin using the include pattern similar to DockerComputerJNLPLauncher. I will see if I can prevent it in the core instead of fixing plugins

          oleg_nenashev Oleg Nenashev added a comment - Yes, it happens in the Docker Plugin due to the invalid include: https://github.com/jenkinsci/docker-plugin/blob/master/docker-plugin/src/main/resources/com/nirima/jenkins/plugins/docker/launcher/DockerComputerJNLPLauncher/config.jelly#L8 I checked other such risks: Yet Another Docker Plugin: safe, custom implementation Spotinst Plugin - safe, no config.jelly JCloudsJnlpLauncher - safe, no config.jelly VMwareLauncher - safe, custom implementation without include MesosComputerLauncher - safe, no config.jelly I also see a closed-source plugin using the include pattern similar to DockerComputerJNLPLauncher. I will see if I can prevent it in the core instead of fixing plugins
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/slaves/JNLPLauncher.java
          core/src/main/resources/hudson/slaves/JNLPLauncher/config.jelly
          http://jenkins-ci.org/commit/jenkins/6ed7c7f1d00caa21bfd8e43d34140bf66b579f5f
          Log:
          [FIXED JENKINS-45895] - JNLPLauncher config.jelly should not display Work Dir settings when included from other class

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/slaves/JNLPLauncher.java core/src/main/resources/hudson/slaves/JNLPLauncher/config.jelly http://jenkins-ci.org/commit/jenkins/6ed7c7f1d00caa21bfd8e43d34140bf66b579f5f Log: [FIXED JENKINS-45895] - JNLPLauncher config.jelly should not display Work Dir settings when included from other class
          oleg_nenashev Oleg Nenashev added a comment -

          The Jenkins core patch has been released in 2.73

          oleg_nenashev Oleg Nenashev added a comment - The Jenkins core patch has been released in 2.73

          People

            oleg_nenashev Oleg Nenashev
            maksonlee Makson Lee
            Votes:
            5 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: