[JENKINS-45909] UpstreamTrigger fails with NPE - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Blocker
Resolution: Fixed
Component/s: core
Labels:
- 2.73.1-fixed
Environment:
Jenkins 2.72

Similar Issues:

Show

Description

Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE.

To see the error, just create two "Pipeline" projects via Jenkins Web-UI:

First is named "Kevin", the script is:

pipeline {

  agent any

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Kevin here"
          }
      }
    }
  }

}

Starting this project works fine.

Now, second project is named "Chantalle", the script is:

pipeline {

  agent any

  triggers {
    upstream(
      threshold: hudson.model.Result.SUCCESS,
      upstreamProjects: "../Kevin"
    )
  }

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Chantalle here"
          }
      }
    }
  }

}

Similar, starting this project at its own works fine.

But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start:

Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
INFO: Kevin #6 completed: SUCCESS
Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
    at java.util.StringTokenizer.<init>(StringTokenizer.java:199)
    at java.util.StringTokenizer.<init>(StringTokenizer.java:221)
    at hudson.model.Items.fromNameList(Items.java:231)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966)
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Chantalle_config.xml
2 kB
2017-08-04 14:50
Kevin_config.xml
1 kB
2017-08-04 14:50

Issue Links

is related to

JENKINS-46161 Make ReverseBuildTrigger#getUpstreamProjects null-safe

Closed

links to

PR #2966

Activity

Ascending order - Click to sort in descending order

Stefan Gasterstädt created issue - 2017-08-01 13:48

Stefan Gasterstädt made changes - 2017-08-01 13:50

Field	Original Value	New Value
Description	Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE. To see the error, just create two "Pipeline" projects via Jenkins Web-UI: First is named "Kevin", the script is: {code:java} pipeline { agent any stages { stage("Hello") { steps { script { sh "echo Kevin here" } } } } } {code} Second is named "Chantalle", the script is: {code} pipeline { agent any triggers { upstream( threshold: hudson.model.Result.SUCCESS, upstreamProjects: "../Kevin" ) } stages { stage("Hello") { steps { script { sh "echo Chantalle here" } } } } } {code}	Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE. To see the error, just create two "Pipeline" projects via Jenkins Web-UI: First is named "Kevin", the script is: {code:java} pipeline { agent any stages { stage("Hello") { steps { script { sh "echo Kevin here" } } } } } {code} Starting this project works fine. Now, second project is named "Chantalle", the script is: {code} pipeline { agent any triggers { upstream( threshold: hudson.model.Result.SUCCESS, upstreamProjects: "../Kevin" ) } stages { stage("Hello") { steps { script { sh "echo Chantalle here" } } } } } {code} Again, starting this project works fine. But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start: {code} Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish INFO: Kevin #6 completed: SUCCESS Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report WARNING: RunListener failed java.lang.NullPointerException at java.util.StringTokenizer.<init>(StringTokenizer.java:199) at java.util.StringTokenizer.<init>(StringTokenizer.java:221) at hudson.model.Items.fromNameList(Items.java:231) at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256) at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279) at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211) at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663) at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134) at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966) at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407) at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35) at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112) at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code}

Stefan Gasterstädt made changes - 2017-08-01 13:52

Description

Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE.

To see the error, just create two "Pipeline" projects via Jenkins Web-UI:

First is named "Kevin", the script is:
{code:java}
pipeline {

  agent any

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Kevin here"
          }
      }
    }
  }

}
{code}

Starting this project works fine.

Now, second project is named "Chantalle", the script is:
{code}
pipeline {

  agent any

  triggers {
    upstream(
      threshold: hudson.model.Result.SUCCESS,
      upstreamProjects: "../Kevin"
    )
  }

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Chantalle here"
          }
      }
    }
  }

}
{code}

Again, starting this project works fine.

But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start:

{code}
Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
INFO: Kevin #6 completed: SUCCESS
Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
    at java.util.StringTokenizer.<init>(StringTokenizer.java:199)
    at java.util.StringTokenizer.<init>(StringTokenizer.java:221)
    at hudson.model.Items.fromNameList(Items.java:231)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966)
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
{code}

Within the current Jenkins, the upstrem-trigger mechanism fails with a NPE.

To see the error, just create two "Pipeline" projects via Jenkins Web-UI:

First is named "Kevin", the script is:
{code:java}
pipeline {

  agent any

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Kevin here"
          }
      }
    }
  }

}
{code}

Starting this project works fine.

Now, second project is named "Chantalle", the script is:
{code}
pipeline {

  agent any

  triggers {
    upstream(
      threshold: hudson.model.Result.SUCCESS,
      upstreamProjects: "../Kevin"
    )
  }

  stages {
    stage("Hello") {
      steps {
          script {
              sh "echo Chantalle here"
          }
      }
    }
  }

}
{code}

Similar, starting this project at its own works fine.

But when starting "Kevin" again, I expect "Chantalle" to be executed afterwards. Instead, a NPE is thrown, and "Chantalle" does not start:

{code}
Aug 01, 2017 1:39:38 PM org.jenkinsci.plugins.workflow.job.WorkflowRun finish
INFO: Kevin #6 completed: SUCCESS
Aug 01, 2017 1:39:38 PM hudson.model.listeners.RunListener report
WARNING: RunListener failed
java.lang.NullPointerException
    at java.util.StringTokenizer.<init>(StringTokenizer.java:199)
    at java.util.StringTokenizer.<init>(StringTokenizer.java:221)
    at hudson.model.Items.fromNameList(Items.java:231)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.calculateCache(ReverseBuildTrigger.java:256)
    at jenkins.triggers.ReverseBuildTrigger$RunListenerImpl.onCompleted(ReverseBuildTrigger.java:279)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:211)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.finish(WorkflowRun.java:663)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$1400(WorkflowRun.java:134)
    at org.jenkinsci.plugins.workflow.job.WorkflowRun$GraphL.onNewHead(WorkflowRun.java:966)
    at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1221)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:407)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:35)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
{code}

Stefan Gasterstädt added a comment - 2017-08-01 13:54

Taking a look into the code tells me, the first argument for Java's StringTokenizer is null. This is weird, because its value should be taken from Pipline script's file

[...]
      upstreamProjects: "../Kevin"
[...]

Stefan Gasterstädt added a comment - 2017-08-01 13:54 Taking a look into the code tells me, the first argument for Java's StringTokenizer is null. This is weird, because its value should be taken from Pipline script's file [...] upstreamProjects: "../Kevin" [...]

Stefan Gasterstädt made changes - 2017-08-04 08:35

Component/s

pipeline-model-definition-plugin [ 21706 ]

Sir Tumbleweed added a comment - 2017-08-04 12:39

abayer is there any temporary workaround to this? It seems quite critical to me that the upstream trigger completely doesn't work with the latest revisions. Can you tell which plugins (or jenkins core?) I could downgrade to get around this issue and get my toolchain running again?

Sir Tumbleweed added a comment - 2017-08-04 12:39 abayer is there any temporary workaround to this? It seems quite critical to me that the upstream trigger completely doesn't work with the latest revisions. Can you tell which plugins (or jenkins core?) I could downgrade to get around this issue and get my toolchain running again?

Andrew Bayer made changes - 2017-08-04 12:49

Assignee

Andrew Bayer [ abayer ]

Andrew Bayer added a comment - 2017-08-04 12:49

Will check on this today.

Andrew Bayer added a comment - 2017-08-04 12:49 Will check on this today.

Andrew Bayer added a comment - 2017-08-04 14:07

Ok, so far, this works with core 2.60 and workflow-job 2.11 - trying further combinations...

Andrew Bayer added a comment - 2017-08-04 14:07 Ok, so far, this works with core 2.60 and workflow-job 2.11 - trying further combinations...

Andrew Bayer added a comment - 2017-08-04 14:49

So with latest of everything on 2.72, with new jobs created after upgrading to 2.72, this works. tumbl3w33d is uploading the config.xmls for their failing job(s) so I can see why trigger.upstreamProjects is null...

Andrew Bayer added a comment - 2017-08-04 14:49 So with latest of everything on 2.72, with new jobs created after upgrading to 2.72, this works. tumbl3w33d is uploading the config.xmls for their failing job(s) so I can see why trigger.upstreamProjects is null...

Sir Tumbleweed made changes - 2017-08-04 14:50

Attachment		Chantalle_config.xml [ 39146 ]
Attachment		Kevin_config.xml [ 39147 ]

Sir Tumbleweed added a comment - 2017-08-04 14:53

In the attached version of the config.xml you see the upstream job "Kevin" instead of "../Kevin", but that's just from playing around with different notations. It's broken either way.

Sir Tumbleweed added a comment - 2017-08-04 14:53 In the attached version of the config.xml you see the upstream job "Kevin" instead of "../Kevin", but that's just from playing around with different notations. It's broken either way.

Andrew Bayer added a comment - 2017-08-04 15:24

We're nailing this down over IRC at the moment - the problem seems to be that at least one other job has a ReverseBuildTrigger with a null upstreamProjects. That'd cause the NPE in question, even when you're running an unrelated job. So as a workaround while I figure out a real fix for this, you can run https://gist.github.com/abayer/79700ea922e523d2e82a28675b1181e6 in Manage Jenkins -> Script Console to find job(s) with null upstreamProjects. You then need to fix those jobs to make sure they have non-null upstreamProjects and re-run them.

Meanwhile, I'm trying to decide how we keep this from happening in the future.

Andrew Bayer added a comment - 2017-08-04 15:24 We're nailing this down over IRC at the moment - the problem seems to be that at least one other job has a ReverseBuildTrigger with a null upstreamProjects . That'd cause the NPE in question, even when you're running an unrelated job. So as a workaround while I figure out a real fix for this, you can run https://gist.github.com/abayer/79700ea922e523d2e82a28675b1181e6 in Manage Jenkins -> Script Console to find job(s) with null upstreamProjects . You then need to fix those jobs to make sure they have non-null upstreamProjects and re-run them. Meanwhile, I'm trying to decide how we keep this from happening in the future.

Andrew Bayer made changes - 2017-08-04 15:24

Component/s		core [ 15593 ]
Component/s	pipeline-model-definition-plugin [ 21706 ]
Component/s	workflow-job-plugin [ 21716 ]

Andrew Bayer made changes - 2017-08-04 15:25

Status

Open [ 1 ]

In Progress [ 3 ]

Sir Tumbleweed added a comment - 2017-08-04 15:34

Tons of kudos to abayer for this intensive support. We found a nice way to DoS a jenkins' jobs that depend on upstream triggers.

Sir Tumbleweed added a comment - 2017-08-04 15:34 Tons of kudos to abayer for this intensive support. We found a nice way to DoS a jenkins' jobs that depend on upstream triggers.

Stefan Gasterstädt added a comment - 2017-08-04 15:47

Have been just informed about the problem. Big thank you for your support!

Stefan Gasterstädt added a comment - 2017-08-04 15:47 Have been just informed about the problem. Big thank you for your support!

Andrew Bayer made changes - 2017-08-04 16:02

Status

In Progress [ 3 ]

In Review [ 10005 ]

Andrew Bayer added a comment - 2017-08-04 16:02

PR up at https://github.com/jenkinsci/jenkins/pull/2966

Andrew Bayer added a comment - 2017-08-04 16:02 PR up at https://github.com/jenkinsci/jenkins/pull/2966

Andrew Bayer made changes - 2017-08-04 16:02

Remote Link

This issue links to "PR #2966 (Web Link)" [ 17411 ]

SCM/JIRA link daemon added a comment - 2017-08-12 22:58

Code changed in jenkins
User: Andrew Bayer
Path:
core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
http://jenkins-ci.org/commit/jenkins/f8dd58425f54e27f5bf74a0bb769c50cbb96bc08
Log:
[FIXED JENKINS-45909] ReverseBuildTrigger.upstreamProjects should be null safe

SCM/JIRA link daemon added a comment - 2017-08-12 22:58 Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java http://jenkins-ci.org/commit/jenkins/f8dd58425f54e27f5bf74a0bb769c50cbb96bc08 Log: [FIXED JENKINS-45909] ReverseBuildTrigger.upstreamProjects should be null safe

Oleg Nenashev added a comment - 2017-08-14 10:34

The fix has been integrated towards Jenkins 2.74. Marking it as LTS candidate.

IMHO the fix is not ideal, ~~JENKINS-46161~~ is a follow-up

Oleg Nenashev added a comment - 2017-08-14 10:34 The fix has been integrated towards Jenkins 2.74. Marking it as LTS candidate. IMHO the fix is not ideal, JENKINS-46161 is a follow-up

Oleg Nenashev made changes - 2017-08-14 10:34

Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

Oleg Nenashev made changes - 2017-08-14 10:34

Labels

lts-candidate

Oleg Nenashev made changes - 2017-08-14 10:34

Link

This issue is related to ~~JENKINS-46161~~ [ ~~JENKINS-46161~~ ]

Oliver Gondža made changes - 2017-09-04 13:51

Labels

lts-candidate

2.73.1-fixed

People

Assignee:: Andrew Bayer

Reporter:: Stefan Gasterstädt

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2017-08-01 13:48

Updated:: 2017-09-04 13:51

Resolved:: 2017-08-14 10:34